From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Gary Oberbrunner Newsgroups: gmane.emacs.bugs Subject: bug#3418: Issue with compile.el and compilation-parse-errors-filename-function Date: Tue, 26 Jan 2016 11:19:41 -0500 (EST) Message-ID: <681830756.582148.1453825181223.JavaMail.zimbra@genarts.com> References: <4A1FF55B.4040202@genarts.com> <83vb6g1jwt.fsf@gnu.org> <799658909.580977.1453821327904.JavaMail.zimbra@genarts.com> <83fuxk1fxp.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1453825879 10832 80.91.229.3 (26 Jan 2016 16:31:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Jan 2016 16:31:19 +0000 (UTC) Cc: Andrew Hyatt , 3418 <3418@debbugs.gnu.org> To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 26 17:31:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aO6WM-0000EN-1E for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2016 17:31:10 +0100 Original-Received: from localhost ([::1]:44981 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO6WL-00029u-A5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2016 11:31:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO6WH-00029b-6D for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 11:31:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO6WE-00021K-Ol for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 11:31:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO6WE-00021G-Lr for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 11:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aO6WE-0002Wa-Hk for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 11:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gary Oberbrunner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jan 2016 16:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3418-submit@debbugs.gnu.org id=B3418.14538258479674 (code B ref 3418); Tue, 26 Jan 2016 16:31:02 +0000 Original-Received: (at 3418) by debbugs.gnu.org; 26 Jan 2016 16:30:47 +0000 Original-Received: from localhost ([127.0.0.1]:37837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aO6Vz-0002Vs-Dc for submit@debbugs.gnu.org; Tue, 26 Jan 2016 11:30:47 -0500 Original-Received: from hq.genarts.com ([173.9.65.1]:52968 helo=mail.hq.genarts.com) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aO6LK-0002Eq-KA for 3418@debbugs.gnu.org; Tue, 26 Jan 2016 11:19:46 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hq.genarts.com (Postfix) with ESMTP id 28130BE021A; Tue, 26 Jan 2016 11:19:46 -0500 (EST) Original-Received: from mail.hq.genarts.com ([127.0.0.1]) by localhost (mail.hq.genarts.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id bAuWhzTQ8Qhr; Tue, 26 Jan 2016 11:19:41 -0500 (EST) Original-Received: from localhost (localhost [127.0.0.1]) by mail.hq.genarts.com (Postfix) with ESMTP id 830CABE10D8; Tue, 26 Jan 2016 11:19:41 -0500 (EST) X-Virus-Scanned: amavisd-new at mail.hq.genarts.com Original-Received: from mail.hq.genarts.com ([127.0.0.1]) by localhost (mail.hq.genarts.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cZLkwUoIsb9O; Tue, 26 Jan 2016 11:19:41 -0500 (EST) Original-Received: from mail.hq.genarts.com (localhost [127.0.0.1]) by mail.hq.genarts.com (Postfix) with ESMTP id 53BC7BE10B7; Tue, 26 Jan 2016 11:19:41 -0500 (EST) In-Reply-To: <83fuxk1fxp.fsf@gnu.org> X-Mailer: Zimbra 8.6.0_GA_1182 (ZimbraWebClient - GC47 (Win)/8.6.0_GA_1182) Thread-Topic: bug#3418: Issue with compile.el and compilation-parse-errors-filename-function Thread-Index: SL2L+9QUBfhd71/sNi0sVdOw2rthGg== X-Mailman-Approved-At: Tue, 26 Jan 2016 11:30:45 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111999 Archived-At: Hi, Eli. If a user (such as myself) has an implementation of this function in his .emacs today, like so: (defun process-error-filename (filename) ;;; do stuff with filename filename) (setq compilation-parse-errors-filename-function 'process-error-filename) and we add a new argument that gets passed to that function, it'll throw an error. *Users* will have to add &optional spec-dir to their implementations of it to avoid the error. (And btw, I've already done that in mine, so I'm future-proof. :-)) -- Gary ----- Original Message ----- > From: "Eli Zaretskii" > To: "Gary Oberbrunner" > Cc: "Andrew Hyatt" , "3418" <3418@debbugs.gnu.org> > Sent: Tuesday, January 26, 2016 11:08:50 AM > Subject: Re: bug#3418: Issue with compile.el and compilation-parse-errors-filename-function >> Date: Tue, 26 Jan 2016 10:15:27 -0500 (EST) >> From: Gary Oberbrunner >> Cc: Andrew Hyatt , 3418@debbugs.gnu.org >> >> Wow, a blast from the past! > > Better late than never, right? > >> I am totally happy with soln 1. For all I know, since I added that hook I might >> be the only one using it. :-) But I'm also usually a stickler for backward >> compatibility, so that's why I brought it up. > > But if we make the additional argument optional, the backward > compatibility is preserved, right? Or did I miss something? -- Gary Oberbrunner