From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Mon, 1 Nov 2021 13:49:40 -0700 Message-ID: <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39473"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51556@debbugs.gnu.org To: Eli Zaretskii , =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 01 21:55:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mheL1-000A0i-Ec for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Nov 2021 21:55:27 +0100 Original-Received: from localhost ([::1]:38110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mheKv-0002xc-Tr for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Nov 2021 16:55:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mheFn-00042C-UO for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 16:50:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mheFm-0001Pz-8X for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 16:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mheFm-0008OA-2U for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 16:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Nov 2021 20:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51556 X-GNU-PR-Package: emacs Original-Received: via spool by 51556-submit@debbugs.gnu.org id=B51556.163579979032221 (code B ref 51556); Mon, 01 Nov 2021 20:50:01 +0000 Original-Received: (at 51556) by debbugs.gnu.org; 1 Nov 2021 20:49:50 +0000 Original-Received: from localhost ([127.0.0.1]:36247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mheFZ-0008Nd-WF for submit@debbugs.gnu.org; Mon, 01 Nov 2021 16:49:50 -0400 Original-Received: from mail-pf1-f181.google.com ([209.85.210.181]:41618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mheFX-0008NL-HI for 51556@debbugs.gnu.org; Mon, 01 Nov 2021 16:49:48 -0400 Original-Received: by mail-pf1-f181.google.com with SMTP id u33so5472744pfg.8 for <51556@debbugs.gnu.org>; Mon, 01 Nov 2021 13:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=HBqJWN/INVFsqgBBmJPDKxlQRUfHDc2VFlDpJbj3waY=; b=enUPujny86Blaw+wx+fQtKAyUcpwRBjAo5uqSIfdp7kFowmlq8SvSTxo/+UFHxJVf0 Prs9lyJyN10uZ8/2DHFggUvHoXtuc1HX4zYlhnjh6zmTeCuLyZn0oVnqBkYh5fi8FZdU 3537/9N3tPyq1g1uFUJAbHZ2oMJDtLVUMLBzSWKDJ3ZA6Jg6ry/PLS1vpI48OUWI4NJb ZVWP7EEvhEjmh043fOvvmNJftLAwnP6oxYQfO8KKDpw+7WTCFQ5L37K5zDc2lOI0D6Qp 29hYKCp4jXx1nO3DmEw4l985QwGQtdWoPmDHSaGhUcg/IrNW0QdfxxdYqfxiWsVuXzxT 6n/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HBqJWN/INVFsqgBBmJPDKxlQRUfHDc2VFlDpJbj3waY=; b=EsgmNW+qiEX9BNsI/WUdIYhQ0Dns7AfrbyA2f1V+26zwzuQi/PAJsuBAbENbXqO6fa mLvqon61RK5z0unEXXq1g1BNN8I9uDR/yhWslmnaGXEAKopvVmsBgOi3WdZcpfdzunJ/ SSB4pWEP79D/AwEabG3EE2pYrmFBqUhOtsZIlY1KiNQaCwmcJ1B+DQZsZ5zaWMlhfBdd 28r6nojLE6qBrMaM1GP8H8ZcXWIFkZQl86/zfLYE1tPRLdK0pa/qzneoek0VD55FFEs9 /7La1yPBtL2iKc6gLa0Wuy4WRRk95g8qn1F261hvnoLqgmfggyme785TNb4yRTLhl2fh EQZw== X-Gm-Message-State: AOAM531+MYarGcc1p1GVKPLceiGlZbwhskZWXmNznqkrwTZnHRC7BD27 hsBrGH6BQI4W7Y7Dx5pmwI7H3h+I0k0= X-Google-Smtp-Source: ABdhPJyOPJU4psFc9cpuLoMcgZhsB+iZ/YDj7gjONZErx6NUyTGpZmKfjZU9DJuQz1S6bjASSilW/A== X-Received: by 2002:a63:1d7:: with SMTP id 206mr23952210pgb.387.1635799781609; Mon, 01 Nov 2021 13:49:41 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id m184sm13136298pga.40.2021.11.01.13.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Nov 2021 13:49:41 -0700 (PDT) In-Reply-To: <83fssflmcg.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218788 Archived-At: On 11/1/2021 12:14 PM, Eli Zaretskii wrote: >> From: Kévin Le Gouguec >> Date: Mon, 01 Nov 2021 18:56:13 +0100 >> >> On darker themes (e.g. modus-vivendi), the Customize SVG icons >> (etc/images/right.svg and etc/images/down.svg) are not very visible, due >> to the poor contrast between their fill color (#2e3436) and dark >> backgrounds[1]. > > That's for the themes to resolve, isn't it? They could supply their > own icons, because only they know which colors will go well with the > theme's colors. The method suggested in the original report (see below) would allow for themes to do this by customizing the appropriate face, wouldn't it? That seems like a simpler way for themes to apply the appropriate colors. As someone developing a dark Emacs theme, I think this would be a welcome improvement. On 11/1/2021 10:56 AM, Kévin Le Gouguec wrote: > A quick dive into widget-create-child-and-convert (down to > widget-image-insert) suggests that there's no way to tell widget.el to > slap a face onto an image; perhaps a new keyword could be added to that > effect? > > Then we could add a face that (1) could preserve the original color > (#2e3436) for light backgrounds (2) be set to something more reasonable > for dark backgrounds (3) be themed.