From: Dmitry Gutov <dgutov@yandex.ru>
To: Theodor Thornhill <theo@thornhill.no>,
Eli Zaretskii <eliz@gnu.org>,
Pankaj Jangid <pankaj@codeisgreat.org>,
Yuan Fu <casouri@gmail.com>
Cc: 61502@debbugs.gnu.org
Subject: bug#61502: 29.0.60; c-ts-mode auto-indent not working
Date: Wed, 15 Feb 2023 01:57:17 +0200 [thread overview]
Message-ID: <67e055d8-c709-df09-374e-560057f61731@yandex.ru> (raw)
In-Reply-To: <87edqs11db.fsf@thornhill.no>
On 14/02/2023 21:41, Theodor Thornhill via Bug reports for GNU Emacs,
the Swiss army knife of text editors wrote:
> What do you think?
>
> Theo
>
>
> diff --git a/lisp/treesit.el b/lisp/treesit.el
> index 749781894b..300a703515 100644
> --- a/lisp/treesit.el
> +++ b/lisp/treesit.el
> @@ -1418,6 +1418,8 @@ treesit--indent-1
> ;; encompass the whitespace.
> (parent (cond ((and node parser)
> (treesit-node-parent node))
> + ((equal (treesit-node-type smallest-node) "}")
> + (treesit-node-parent smallest-node))
> (t (treesit-node-on bol bol)))))
> (funcall treesit-indent-function node parent bol))))
Here's a counter-example for this patch:
int
main ()
{}|
press RET at |, and you'll see the next line indented by 2 spaces.
Whereas it shouldn't. This happens, among other things, because the
added code doesn't distinguish between "real" and "virtual" nodes.
BTW, in this example:
int
main
{
for (;;)
{|
}
the "}" node selected by treesit--indent-1 is not "unexisting": it
selects the closer on the next line, which is parsed to be the part of
the "for" node. Thanks to its presence, the parent compound_statement
node contains the point, and everything works out.
And this one
int
main
{
for (;;)|
}
isn't fixed with your patch because the "unexisting" node in place is a
different one: "expression_statement", and it has no closers. And it's
"virtually" placed at the end of the previous line by the parser.
So in most cases if the user has electric-pair-mode on, indentation
should work okay. Without a pairing solution, though, we see different
grammars handling incomplete code in different ways for different
syntactic elements: virtual nodes, container nodes that span after
point, container nodes that don't span after point, statements that
parse into a different node type (usually wrapped in ERROR). We could
report these one by one, hoping for the best. I'm curious how different
editors fare with indentation in these conditions -- perhaps they use a
different, more error-proof approach. But it could be that their uses
are less fussy about indentation than we are.
next prev parent reply other threads:[~2023-02-14 23:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 4:36 bug#61502: 29.0.60; c-ts-mode auto-indent not working Pankaj Jangid
2023-02-14 13:16 ` Eli Zaretskii
2023-02-14 19:41 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-14 20:02 ` Eli Zaretskii
2023-02-14 20:21 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 12:24 ` Eli Zaretskii
2023-02-15 12:41 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 13:35 ` Dmitry Gutov
2023-02-15 14:03 ` Eli Zaretskii
2023-02-15 14:21 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 14:27 ` Eli Zaretskii
2023-02-15 14:53 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 15:02 ` Eli Zaretskii
2023-02-15 15:48 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 15:57 ` Dmitry Gutov
2023-02-15 17:11 ` Eli Zaretskii
2023-02-15 17:57 ` Dmitry Gutov
2023-02-15 18:11 ` Eli Zaretskii
2023-02-15 18:18 ` Dmitry Gutov
2023-02-15 17:09 ` Eli Zaretskii
2023-02-15 17:14 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 17:30 ` Eli Zaretskii
2023-02-15 17:52 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-14 20:59 ` Dmitry Gutov
2023-02-14 21:00 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 0:12 ` Dmitry Gutov
2023-02-14 23:57 ` Dmitry Gutov [this message]
2023-02-15 6:07 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e055d8-c709-df09-374e-560057f61731@yandex.ru \
--to=dgutov@yandex.ru \
--cc=61502@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=pankaj@codeisgreat.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.