From: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
To: Glenn Morris <rgm@gnu.org>
Cc: athird@googlemail.com, 国広卓也 <tkk@misasa.okayama-u.ac.jp>,
emacs-devel@gnu.org
Subject: Re: naming of 26.1 mwheel- user options
Date: Fri, 2 Mar 2018 18:35:22 +0900 [thread overview]
Message-ID: <67D8AA53-92F8-4DE7-A0A2-A8DE517FCA9E@misasa.okayama-u.ac.jp> (raw)
In-Reply-To: <r7eqvxmew.fsf@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
Let me send a patch again, to change names of two variables and
how two variables are defined, as below.
[from mwheel-tilt-scroll-p] --> [to mouse-wheel-tilt-scroll]
[from mwheel-flip-direction] --> [to mouse-wheel-flip-direction]
[from (defcustom mwheel-scroll-left-function 'scroll-left)]
--> [to (defvar mwheel-scroll-left-function 'scroll-left)]
[from (defcustom mwheel-scroll-right-function 'scroll-right)]
--> [to (defvar mwheel-scroll-right-function 'scroll-right)]
* Commit log
Change name and definition of variables to be consistent
Variables mwheel-tilt-scroll-p and mwheel-flip-direction were
renamed to mouse-wheel-tilt-scroll and mouse-wheel-flip-direction,
respectively. Variables mwheel-scroll-left-function and
mwheel-scroll-right-function that were defined by defcustom are
defined by defvar. Suggested by Glenn Morris <rgm@gnu.org> in
emacs-devel@gnu.org.
* etc/NEWS:
* doc/emacs/frames.texi (Mouse Commands):
* lisp/mwheel.el (mouse-wheel-tilt-scroll):
(mouse-wheel-flip-direction): Variables are renamed.
* lisp/mwheel.el (mwheel-scroll-left-function):
(mwheel-scroll-right-function): Defined as defvar.
[-- Attachment #2: frames.texi.diff --]
[-- Type: application/octet-stream, Size: 975 bytes --]
diff --git a/doc/emacs/frames.texi b/doc/emacs/frames.texi
index 8cc4d64..c07e471 100644
--- a/doc/emacs/frames.texi
+++ b/doc/emacs/frames.texi
@@ -207,13 +207,13 @@ Mouse Commands
@code{mouse-wheel-progressive-speed} determines whether the scroll
speed is linked to how fast you move the wheel.
-@vindex mwheel-tilt-scroll-p
-@vindex mwheel-flip-direction
+@vindex mouse-wheel-tilt-scroll
+@vindex mouse-wheel-flip-direction
Emacs can also support horizontal scrolling if your mouse's wheel can
be tilted. This feature is off by default; the variable
-@code{mwheel-tilt-scroll-p} turns it on. If you'd like to reverse the
-direction of horizontal scrolling, customize the variable
-@code{mwheel-flip-direction} to a non-@code{nil} value.
+@code{mouse-wheel-tilt-scroll} turns it on. If you'd like to reverse
+the direction of horizontal scrolling, customize the variable
+@code{mouse-wheel-flip-direction} to a non-@code{nil} value.
@node Word and Line Mouse
[-- Attachment #3: mwheel.el.diff --]
[-- Type: application/octet-stream, Size: 2234 bytes --]
diff --git a/lisp/mwheel.el b/lisp/mwheel.el
index 9718ab8..2e749a9 100644
--- a/lisp/mwheel.el
+++ b/lisp/mwheel.el
@@ -255,13 +255,13 @@ mwheel-scroll
;; Make sure we do indeed scroll to the end of the buffer.
(end-of-buffer (while t (funcall mwheel-scroll-up-function)))))
((eq button mouse-wheel-left-event) ; for tilt scroll
- (when mwheel-tilt-scroll-p
- (funcall (if mwheel-flip-direction
+ (when mouse-wheel-tilt-scroll
+ (funcall (if mouse-wheel-flip-direction
mwheel-scroll-right-function
mwheel-scroll-left-function) amt)))
((eq button mouse-wheel-right-event) ; for tilt scroll
- (when mwheel-tilt-scroll-p
- (funcall (if mwheel-flip-direction
+ (when mouse-wheel-tilt-scroll
+ (funcall (if mouse-wheel-flip-direction
mwheel-scroll-left-function
mwheel-scroll-right-function) amt)))
(t (error "Bad binding in mwheel-scroll"))))
@@ -324,29 +324,23 @@ mwheel-install
;;; For tilt-scroll
;;;
-(defcustom mwheel-tilt-scroll-p nil
+(defcustom mouse-wheel-tilt-scroll nil
"Enable scroll using tilting mouse wheel."
:group 'mouse
:type 'boolean
:version "26.1")
-(defcustom mwheel-flip-direction nil
+(defcustom mouse-wheel-flip-direction nil
"Swap direction of 'wheel-right and 'wheel-left."
:group 'mouse
:type 'boolean
:version "26.1")
-(defcustom mwheel-scroll-left-function 'scroll-left
- "Function that does the job of scrolling left."
- :group 'mouse
- :type 'function
- :version "26.1")
+(defvar mwheel-scroll-left-function 'scroll-left
+ "Function that does the job of scrolling left.")
-(defcustom mwheel-scroll-right-function 'scroll-right
- "Function that does the job of scrolling right."
- :group 'mouse
- :type 'function
- :version "26.1")
+(defvar mwheel-scroll-right-function 'scroll-right
+ "Function that does the job of scrolling right.")
(defvar mouse-wheel-left-event
(if (or (featurep 'w32-win) (featurep 'ns-win))
[-- Attachment #4: NEWS.diff --]
[-- Type: application/octet-stream, Size: 569 bytes --]
diff --git a/etc/NEWS b/etc/NEWS
index cb4048d..abd0792 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -431,9 +431,9 @@ always restricting the margin to a quarter of the window.
+++
** Emacs can scroll horizontally using mouse, touchpad, and trackbar.
-You can enable this by customizing 'mwheel-tilt-scroll-p'. If you
+You can enable this by customizing 'mouse-wheel-tilt-scroll'. If you
want to reverse the direction of the scroll, customize
-'mwheel-flip-direction'.
+'mouse-wheel-flip-direction'.
+++
** The default GnuTLS priority string now includes %DUMBFW.
prev parent reply other threads:[~2018-03-02 9:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 22:22 naming of 26.1 mwheel- user options Glenn Morris
2018-02-27 22:50 ` Tak Kunihiro
2018-02-27 23:15 ` Stefan Monnier
2018-02-28 8:06 ` Tak Kunihiro
2018-03-01 7:58 ` Alan Third
2018-03-01 12:20 ` Tak Kunihiro
2018-03-02 2:04 ` Glenn Morris
2018-03-02 2:56 ` Tak Kunihiro
2018-03-02 9:35 ` Tak Kunihiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67D8AA53-92F8-4DE7-A0A2-A8DE517FCA9E@misasa.okayama-u.ac.jp \
--to=tkk@misasa.okayama-u.ac.jp \
--cc=athird@googlemail.com \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.