From: "Mattias Engdegård" <mattiase@acm.org>
To: 36832@debbugs.gnu.org
Cc: Alan Mackenzie <acm@muc.de>
Subject: bug#36832: Supply option to suppress scrolling in compilation mode buffers.
Date: Sun, 1 Sep 2019 23:50:20 +0200 [thread overview]
Message-ID: <67885E39-7071-4360-90BB-344675251759@acm.org> (raw)
In-Reply-To: <20190728203221.GD5072@ACM>
After 29d1c72d7c, next-error and previous-error no longer work as before in compilation-mode.
The fringe arrow is often not moved at all until the compilation window is made active, and the cursor in that buffer isn't moved at all; scrolling never occurs. This is with a plain NS build on macOS 10.14, compilation-context-lines being nil (the default).
When compilation-context-lines is set to an integer, it seems to work normally.
In compilation-set-window, the expression
(set-window-point w mk)
was previously executed unconditionally if compilation-context-lines was not an integer; now, it is only run if there is no left fringe. The following change restores previous behaviour in that respect:
@@ -2600,7 +2600,8 @@ compilation-set-window
(goto-char mk)
(beginning-of-line 1)
(point)))
- (set-window-point w mk))))
+ (set-window-point w mk))
+ (t (set-window-point w mk))))
but you probably want to reformulate the code to avoid duplication.
next prev parent reply other threads:[~2019-09-01 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 20:32 bug#36832: Supply option to suppress scrolling in compilation mode buffers Alan Mackenzie
2019-07-30 15:14 ` Eli Zaretskii
2019-07-30 15:59 ` Alan Mackenzie
2019-07-30 16:17 ` Eli Zaretskii
2019-07-30 19:20 ` Juri Linkov
2019-07-31 14:20 ` Eli Zaretskii
2019-07-30 19:32 ` Alan Mackenzie
2019-07-31 14:21 ` Eli Zaretskii
2019-08-25 10:32 ` Alan Mackenzie
2019-09-01 21:50 ` Mattias Engdegård [this message]
[not found] ` <handler.36832.B.156434595120203.ack@debbugs.gnu.org>
2019-09-03 17:44 ` Alan Mackenzie
2019-09-04 12:41 ` Mattias Engdegård
2019-09-05 17:50 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67885E39-7071-4360-90BB-344675251759@acm.org \
--to=mattiase@acm.org \
--cc=36832@debbugs.gnu.org \
--cc=acm@muc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.