From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: eldoc error in Emacs 27 Date: Mon, 27 Jul 2020 17:13:17 -0400 Message-ID: <671212F5-7729-4236-A9E5-677930187DCA@gmail.com> References: <33D61A89-7C41-4160-8C79-C756635B205C@gmail.com> <87k0yosp1x.fsf@gmail.com> <87ft9csnuk.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_996B92F9-0F79-4B45-A5C5-8CB2051820AC" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21120"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 27 23:14:00 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0ARb-0005N6-PZ for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Jul 2020 23:13:59 +0200 Original-Received: from localhost ([::1]:46084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0ARa-0006Iu-SD for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Jul 2020 17:13:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0AR2-0005op-Ht for emacs-devel@gnu.org; Mon, 27 Jul 2020 17:13:24 -0400 Original-Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]:41359) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k0AQy-0007AQ-QP for emacs-devel@gnu.org; Mon, 27 Jul 2020 17:13:24 -0400 Original-Received: by mail-qt1-x82e.google.com with SMTP id v22so7464950qtq.8 for ; Mon, 27 Jul 2020 14:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=lIstvzIu7C85rWHlVZMYSlTxa8zbDgPjs3CFHr1LiUo=; b=WPFe2swb9hIxgsopdb5uZeNZl782WhrysLBQbv/udgCsICnvevfjKZXyMhqNZ+FHl0 LSfpx0h9gH2zbSKbnXfZrNWeP2YqVqFjuOcV2wb5KWBlJxiy+MkAoOD53ioxGQvROPlZ 0WaLNCeVu5fVos3ouFj1Zk+ZehlaaNfXdHCYvDfIQTE4a9q4D9HSQpIUp5C2l5oO6OBq HNUkLgy06jYhWUPLuW377FzgIH+PprXanLNvHQ4odJ2fRCoP/1O6Z3CdnfHN4aH4/UXT 8tkOCP+WOGb8EJBUrrrVzrcPYyA0CseKK7RDMaNTHyM6mdbmp9OfH11myD9vTG6DkZzG 7TwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=lIstvzIu7C85rWHlVZMYSlTxa8zbDgPjs3CFHr1LiUo=; b=MinbLWoMhkoxUMFzbInef69na0og33qEIu2YlA90fHxjX6VpAeMTSwT0dvx7W3iXhp azsRJwFqwtszVoEcYDYrgoM2EWT1EEFS0HYUhToGFOok1zym0mprIme70CtUDhnStdN0 GeDTSIhMVcDx4tj1EYHMrjJeNVN9O8YOMx4JhCJBbPjb/10Cvv5FYoU3VwSu25I8ov/1 NWxgVeLwBxHkg74BTkSifLIjUlGmuz+oAAaLCpOX/WL8JLAjUDXRwRu9YLmZVYh9QWC8 Ucuxou+7lwlJ0MX79oIaoUpBa37pbJEperQVTQ/EPBJr+Mnwq+fL5YHj11ywBuiYUnQG TOUw== X-Gm-Message-State: AOAM533Vw/rfCy4jjScbA6ZFDcvUCUxzoIzf6O1puYKx5JvofB861kCG O0yL/fMuBMygFDlkGYwqqMQ= X-Google-Smtp-Source: ABdhPJw767twH3hYhcpUTR7HUHnszaf5Bjhgw9Lz5rPng309gDzzcmwWXBgw9F6AvjP5SUXeRv61Kw== X-Received: by 2002:ac8:2c13:: with SMTP id d19mr24262565qta.137.1595884399262; Mon, 27 Jul 2020 14:13:19 -0700 (PDT) Original-Received: from ?IPv6:2601:98a:4200:9210:fd6c:17ba:2f50:d08a? ([2601:98a:4200:9210:fd6c:17ba:2f50:d08a]) by smtp.gmail.com with ESMTPSA id c21sm12421513qka.9.2020.07.27.14.13.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jul 2020 14:13:18 -0700 (PDT) In-Reply-To: <87ft9csnuk.fsf@gmail.com> X-Mailer: Apple Mail (2.3608.80.23.2.2) Received-SPF: pass client-ip=2607:f8b0:4864:20::82e; envelope-from=casouri@gmail.com; helo=mail-qt1-x82e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253294 Archived-At: --Apple-Mail=_996B92F9-0F79-4B45-A5C5-8CB2051820AC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jul 27, 2020, at 4:29 PM, Jo=C3=A3o T=C3=A1vora = wrote: >=20 > Jo=C3=A3o T=C3=A1vora > writes: >=20 >> Yuan Fu writes: >>=20 >>> 1.5. I looked around in that file and didn=E2=80=99t see = elisp-eldoc-funcall >>> defined anywhere (neither can I in the old eldoc.el that comes with >>> Emacs 27). >>=20 >> Thanks for reporting this. I introduced this bug. The function you = get >> the error for is not defined in eldoc.el ? 1.5.0 but referenced = there: >=20 > Actually, a similar bug was lurking before I touched the function, I > just exposed it by making ElDoc available on GNU Elpa. I think the > patch below is the easiest way to fix it, along with bumping the ElDoc > version to 1.8. Works in my tests of Emacs 27 and Emacs 26. Can you > try it out? Yes, the error went away after I applied the patch :-) Yuan= --Apple-Mail=_996B92F9-0F79-4B45-A5C5-8CB2051820AC Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Jul 27, 2020, at 4:29 PM, Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> wrote:

Jo=C3=A3o = T=C3=A1vora <joaotavora@gmail.com> = writes:

Yuan = Fu <casouri@gmail.com> writes:

1.5. I looked around in = that file and didn=E2=80=99t see elisp-eldoc-funcall
defined= anywhere (neither can I in the old eldoc.el that comes with
Emacs 27).

Thanks = for reporting this.  I introduced this bug.  The function you = get
the error for is not defined in eldoc.el ? 1.5.0 but = referenced there:

Actually, a = similar bug was lurking before I touched the function, I
just exposed it by making ElDoc available on GNU Elpa. =  I think the
patch below is the easiest way to fix it, along with bumping = the ElDoc
version to 1.8.  Works in my tests of Emacs 27 and Emacs = 26.  Can you
try it out?

Yes, the error went away after I applied the = patch :-)

Yuan
= --Apple-Mail=_996B92F9-0F79-4B45-A5C5-8CB2051820AC--