From: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
To: 30964@debbugs.gnu.org
Subject: bug#30964: python-mode failing "overlapping strings" assertion lately
Date: Sun, 17 Jun 2018 09:33:09 +0200 [thread overview]
Message-ID: <66d9224e-631e-8824-8e39-19f41bcdf29f@easy-emacs.de> (raw)
In-Reply-To: <87wouytl3m.fsf@gmail.com>
On 17.06.2018 00:36, Noam Postavsky wrote:
> "Daniel Colascione" <dancol@dancol.org> writes:
>
>> So it turns out that it wasn't an off-by-one problem at all. Instead,
>> python was using (re-search-forward (rx (syntax string-delimiter))), which
>> was matching incorrectly because re-search-forward didn't update syntax as
>> it matched. It didn't do that because regex matching in general wasn't
>> reentrant, and it wasn't reentrant because regex bytecode programs are
>> self-modifying.
>>
>> I checked in some work that makes regex searching update syntax as needed.
>
> It seems there were two separate problems. The off-by-one error still
> happens after your changes, so I pushed my patch to master.
>
> [1: 05345babc9]: 2018-06-16 18:34:19 -0400
> Fix off by one error in python-mode assertion (Bug#30964)
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=05345babc988060cca540770599282102c34f2a7
>
>
>
Hi folks,
sorry, but as long as syntax-ppss has fundamentally issues, all fixing
here will be vain. For the very same reason don't be surprised having
not "found a reliable test case".
Cheers,
Andreas
prev parent reply other threads:[~2018-06-17 7:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 18:09 bug#30964: python-mode failing "overlapping strings" assertion lately dancol
2018-04-02 1:11 ` Noam Postavsky
2018-04-03 18:12 ` Charles A. Roelli
2018-04-03 22:06 ` Dmitry Gutov
2018-05-18 15:46 ` Clément Pit-Claudel
2018-05-18 19:18 ` Andreas Röhler
2018-05-19 1:49 ` Noam Postavsky
2018-05-19 6:49 ` Andreas Röhler
2018-05-30 0:29 ` Noam Postavsky
2018-06-02 19:03 ` Philipp Stephani
2018-06-02 20:35 ` Noam Postavsky
2018-06-16 20:55 ` Daniel Colascione
2018-06-16 22:36 ` Noam Postavsky
2018-06-17 7:33 ` Andreas Röhler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66d9224e-631e-8824-8e39-19f41bcdf29f@easy-emacs.de \
--to=andreas.roehler@easy-emacs.de \
--cc=30964@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.