From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 19548@debbugs.gnu.org, esr@thyrsus.com
Subject: bug#19548: VC changes under-documented, needlessly incompatible
Date: Tue, 24 May 2016 02:07:35 +0300 [thread overview]
Message-ID: <66a5e406-c325-628c-109f-46973d94512d@yandex.ru> (raw)
In-Reply-To: <8360u465fw.fsf@gnu.org>
On 05/23/2016 08:37 PM, Eli Zaretskii wrote:
> I'm not sure I see the gain, given that (AFAIU) CVS is the only
> back-end for which this option is relevant.
For the benefit of someone who customized vc-stay-local 10 years ago?
Not very compelling, I agree.
Does this patch have your blessing?
Someone should test it out, to be safe; the only CVS repo I have to
experiment on doesn't seem to work great with either version of the code
(but then, it's an old public checkout of the Samba repository).
diff --git a/lisp/vc/vc-cvs.el b/lisp/vc/vc-cvs.el
index 2dca708..a2499a2 100644
--- a/lisp/vc/vc-cvs.el
+++ b/lisp/vc/vc-cvs.el
@@ -121,7 +121,7 @@ vc-cvs-use-edit
:version "21.1"
:group 'vc-cvs)
-(defcustom vc-stay-local 'only-file
+(defcustom vc-cvs-stay-local 'only-file
"Non-nil means use local operations when possible for remote
repositories.
This avoids slow queries over the network and instead uses heuristics
and past information to determine the current status of a file.
@@ -131,11 +131,11 @@ vc-stay-local
all other VC operations.
The value can also be a regular expression or list of regular
-expressions to match against the host name of a repository; then VC
-only stays local for hosts that match it. Alternatively, the value
-can be a list of regular expressions where the first element is the
-symbol `except'; then VC always stays local except for hosts matched
-by these regular expressions."
+expressions to match against the host name of a repository; then
+vc-cvs only stays local for hosts that match it. Alternatively,
+the value can be a list of regular expressions where the first
+element is the symbol `except'; then vc-cvs always stays local
+except for hosts matched by these regular expressions."
:type '(choice (const :tag "Always stay local" t)
(const :tag "Only for file operations" only-file)
(const :tag "Don't stay local" nil)
@@ -789,8 +789,7 @@ vc-cvs-stay-local-p
individually should stay local."
(if (listp file)
(delq nil (mapcar (lambda (arg) (vc-cvs-stay-local-p arg)) file))
- (let* ((sym (vc-make-backend-sym 'CVS 'stay-local))
- (stay-local (if (boundp sym) (symbol-value sym) vc-stay-local)))
+ (let ((stay-local vc-cvs-stay-local))
(if (symbolp stay-local) stay-local
(let ((dirname (if (file-directory-p file)
(directory-file-name file)
next prev parent reply other threads:[~2016-05-23 23:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 17:41 bug#19548: VC changes under-documented, needlessly incompatible Glenn Morris
2016-05-08 23:42 ` Dmitry Gutov
2016-05-13 21:05 ` Glenn Morris
2016-05-14 7:41 ` Eli Zaretskii
2016-05-15 23:37 ` Dmitry Gutov
2016-05-23 17:37 ` Eli Zaretskii
2016-05-23 23:07 ` Dmitry Gutov [this message]
2016-05-24 15:34 ` Eli Zaretskii
2016-05-25 1:06 ` Dmitry Gutov
2016-05-23 17:36 ` Eli Zaretskii
2016-05-23 22:49 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66a5e406-c325-628c-109f-46973d94512d@yandex.ru \
--to=dgutov@yandex.ru \
--cc=19548@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=esr@thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.