From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type. Date: Fri, 06 Nov 2020 13:54:08 -0800 Message-ID: <66BCCC51-F7B8-486C-BFA6-F9A250C8C58C@ericabrahamsen.net> References: <20201106130101.11980.32709@vcs0.savannah.gnu.org> <20201106130103.DF32C20CAE@vcs0.savannah.gnu.org> <871rh676cx.fsf@ericabrahamsen.net> <87k0uy5fwy.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9442"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: K-9 Mail for Android Cc: =?ISO-8859-1?Q?Mattias_Engdeg=E5rd?= , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 06 22:55:15 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kb9hT-0002M1-AM for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 22:55:15 +0100 Original-Received: from localhost ([::1]:58022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kb9hS-0003S2-9e for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 16:55:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb9gv-00031e-6v for emacs-devel@gnu.org; Fri, 06 Nov 2020 16:54:41 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:34288 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb9gt-0005DN-Cj for emacs-devel@gnu.org; Fri, 06 Nov 2020 16:54:40 -0500 Original-Received: from [IPv6:2607:fb90:8367:8220:eaca:14e1:e7c9:5a13] (unknown [172.58.46.222]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 2A3E1FA0B0; Fri, 6 Nov 2020 21:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1604699677; bh=ZSim1BKBgIt590TPpm7NL05c548pyY2lL6F4f3/eU2E=; h=Date:In-Reply-To:References:Subject:To:CC:From:From; b=nIlZMO2vq5LzBdOJ9TAwIpjyWkFhIK7NlimQfpERUcRK+LXadjEMSh2npwEt8V4op xSADlplnArns+gm2kIOC0wTN/1zJDdhuAg9ArUiCxyERuFEvNQJuFMhjcMkyTEesVP 5S7vhjBfJNSJZMKB3I6mXzOd2Hi1TM/f6ku8j3SI= In-Reply-To: <87k0uy5fwy.fsf@tcd.ie> Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/06 16:54:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258860 Archived-At: On November 6, 2020 1:33:33 PM PST, "Basil L=2E Contovounesios" wrote: >Eric Abrahamsen writes: > >> Mattias Engdeg=C3=A5rd writes: >> >>> branch: master >>> commit aea936562b033899f0b7160cc492bbea1006863b >>> Author: Mattias Engdeg=C3=A5rd >>> Commit: Mattias Engdeg=C3=A5rd >>> >>> * lisp/gnus/gnus-search=2Eel (gnus-search-contact-tables): Fix >type=2E >>> =20 >>> A more precise type is desirable but at it is now correct >('list' is not)=2E >>> --- >>> lisp/gnus/gnus-search=2Eel | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/lisp/gnus/gnus-search=2Eel b/lisp/gnus/gnus-search=2Eel >>> index 15d96e3=2E=2E7ee7c53 100644 >>> --- a/lisp/gnus/gnus-search=2Eel >>> +++ b/lisp/gnus/gnus-search=2Eel >>> @@ -410,7 +410,7 @@ returned by `completion-at-point-functions'=2E=20 >That usually means >>> a list of strings, a hash table, or an alist=2E" >>> :group 'gnus-search >>> :version "28=2E1" >>> - :type 'list) >>> + :type '(repeat sexp)) >> >> Doesn't this type demand a list of lists? It could also be a list of >> hashtables, or functions, or a mix of >alist/list/function/hashtable=2E=2E=2E > >A sexp in this context is "any Lisp object that can be printed and read >back"=2E That covers most completion table types, right? AFAICT the >only >type more general than that is restricted-sexp=2E Oh, I didn't realize that was the definition of a sexp=2E For some reason = I thought it was more or less equivalent to list=2E Carry on! Thanks,=20 Eric --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E