From: Dmitry Gutov <dmitry@gutov.dev>
To: Spencer Baugh <sbaugh@janestreet.com>, 65137@debbugs.gnu.org
Subject: bug#65137: 29.1; completion-substring-try-completion doesn't return the longest common substring
Date: Fri, 25 Aug 2023 03:40:43 +0300 [thread overview]
Message-ID: <665cd10a-17d9-5586-927e-12b2808c0a71@gutov.dev> (raw)
In-Reply-To: <ierr0oe4esg.fsf@janestreet.com>
Hi Spencer!
On 08/08/2023 02:24, Spencer Baugh wrote:
> However, even this does not work in the project-file and xref-location
> completion categories, for which the "basic" style is not included in
> completion-category-defaults. For such completion categories, there's
> simply no way to use completion to insert a common prefix. This is bad,
> because a filename or identifier might easily be a prefix of another
> filename or identifier.
Could you describe the usage scenario a little more?
From my brief testing, the current behavior seems okay most of the
time: you still get the short input which matches a bunch of strings
(e.g. filenames), you can type a little more chars and narrow down.
With your change, TAB will insert the most common prefix for all those
completions, which in case of project-file can be a pretty long string.
Not a huge problem, but on the face of it that doesn't seem like an
improvement. So which scenario would that make better?
next prev parent reply other threads:[~2023-08-25 0:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 23:24 bug#65137: 29.1; completion-substring-try-completion doesn't return the longest common substring Spencer Baugh
2023-08-07 23:50 ` Spencer Baugh
2023-08-08 0:41 ` Spencer Baugh
2023-08-08 11:04 ` Eli Zaretskii
2023-08-08 12:40 ` sbaugh
2023-08-30 1:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 19:51 ` Spencer Baugh
2023-09-05 21:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-06 11:00 ` Eli Zaretskii
2023-08-25 0:40 ` Dmitry Gutov [this message]
2023-08-25 2:30 ` Drew Adams
2023-08-29 15:45 ` Spencer Baugh
2023-08-29 23:25 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=665cd10a-17d9-5586-927e-12b2808c0a71@gutov.dev \
--to=dmitry@gutov.dev \
--cc=65137@debbugs.gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.