From: Howard Melman <hmelman@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 65411@debbugs.gnu.org
Subject: bug#65411: 29.1; setopt of xref-after-jump-hook gives warning
Date: Sun, 20 Aug 2023 20:21:39 -0400 [thread overview]
Message-ID: <665BB487-07C8-4B9D-8CAA-CE8ECFA6C8E4@gmail.com> (raw)
In-Reply-To: <83edjxwpkj.fsf@gnu.org>
> On Aug 20, 2023, at 2:12 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Howard Melman <hmelman@gmail.com>
>> Date: Sun, 20 Aug 2023 12:12:13 -0400
>> Cc: 65411@debbugs.gnu.org
>>
>> Thanks very much. Indeed, doing this works fine for me:
>>
>> (with-eval-after-load 'xref
>> (setopt xref-after-jump-hook '(reposition-window xref-pulse-momentarily)))
>>
>> Also I found doing (just) this works fine:
>>
>> (setq xref-after-jump-hook '(reposition-window xref-pulse-momentarily))
>>
>> So why does it fail using setopt?
>
> Because until xref is loaded, Emacs doesn't know that
> 'xref-pulse-momentarily' is a symbol of function, whereas the
> defcustom's type is 'hook', which stands for "a list of functions".
Well, that must be correct because doing this also worked fine:
(declare-function xref-pulse-momentarily "xref" ())
(setopt xref-after-jump-hook '(reposition-window xref-pulse-momentarily))
So I guess setopt defers the type check? I get the error when the
hook is run (at which time xref is loaded so I'm still confused about
that).
I'm familiar with reading the lisp code but the innards of custom and
the c code are a bit beyond me. Is it the custom-check-value property
in setopt--set?
If I'm supposed to resolve this warning on my own, then a comment
in setopt--set or something in setopt's docstring (or the manual)
mentioning the asynchrony would help.
Howard
next prev parent reply other threads:[~2023-08-21 0:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 15:03 bug#65411: 29.1; setopt of xref-after-jump-hook gives warning Howard Melman
2023-08-20 15:36 ` Eli Zaretskii
2023-08-20 16:12 ` Howard Melman
2023-08-20 18:12 ` Eli Zaretskii
2023-08-21 0:21 ` Howard Melman [this message]
2023-08-21 12:01 ` Eli Zaretskii
2023-08-21 13:19 ` Howard Melman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=665BB487-07C8-4B9D-8CAA-CE8ECFA6C8E4@gmail.com \
--to=hmelman@gmail.com \
--cc=65411@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.