RE: Need help with Windows implementation of play-sound

[jasonr@btinternet.com]

Please check the GNU coding standards (available as an info file from ftp.gnu.org) and where necessary change your layout and function/variable naming to match them. This will make less work if we decide to use your code.

>  from:    Ben Key <BenK@FreedomScientific.com>
>  date:    Sun, 22 Sep 2002 06:01:04
>  to:      Harald.Maier.BW@t-online.de
>  cc:      emacs-devel@gnu.org
>  subject: RE: Need help with Windows implementation of play-sound
> 
> Thanks.  I will try the change you suggested Monday.  If it works, I will
> attempt to gernerate a patch for Emacs that includes this and the changes to
> the make files, and send it to this list. 
> 
> -----Original Message-----
> From: Harald.Maier.BW@t-online.de
> To: Ben Key
> Cc: emacs-devel@gnu.org
> Sent: 9/21/02 5:34 AM
> Subject: Re: Need help with Windows implementation of play-sound
> 
> 
> Ben Key <BenK@FreedomScientific.com> writes:
> 
> > Can someone take a look at what I have done so far and give me a few 
> > pointers?
> 
> > {
> >   len=XSTRING(attrs[SOUND_FILE])->size;
> >   lpszFile=(char *)alloca(len 1);
> ...
> >   free(lpszFile);
> !!! remove that line !!!
> 
> >   unbind_to (count, Qnil);
> >   return Qnil;
> > }
> 
> You are using alloca so you don't have to call free. free is necessary
> by using malloc. The memory allocated by alloca will be automatically
> be freed by leaving the funciton.
> 
> I am very interested in testing this. 
> 
> Harald
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel