From: Hong Xu <hong@topbug.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 37538@debbugs.gnu.org
Subject: bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'.
Date: Tue, 8 Oct 2019 23:39:08 -0700 [thread overview]
Message-ID: <663aaf32-97c4-0723-1a30-a644938bd21f@topbug.net> (raw)
In-Reply-To: <874l0j1a3j.fsf@gnus.org>
On 10/8/19 9:21 AM, Lars Ingebrigtsen wrote:
>
> The problem is that `(elisp) Programmed Completion' (at least in Emacs
> 27) doesn't mention a WHAT parameter at all, so it's unclear what this
> refers to.
>
How about the following change?
diff --git a/doc/lispref/minibuf.texi b/doc/lispref/minibuf.texi
index a9d6e83cf854..73af67ab083f 100644
--- a/doc/lispref/minibuf.texi
+++ b/doc/lispref/minibuf.texi
@@ -1769,7 +1769,8 @@ Programmed Completion
completion functions, which will then let your function do all
the work.
- The completion function should accept three arguments:
+ The completion function should accept three arguments in the
+following order:
@itemize @bullet
@item
diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el
index 6784894ba87e..d58e2cb2a187 100644
--- a/lisp/progmodes/etags.el
+++ b/lisp/progmodes/etags.el
@@ -1853,8 +1853,8 @@ tags-complete-tags-table-file
"Complete STRING from file names in the current tags table.
The meaning of the arguments are the same as the function form of
COLLECTION as explained in Info node `(elisp) Programmed
-Completion', except that if WHAT does not equal t, it is treated
-as if it were nil."
+Completion', except that if the third argument does not equal t,
+it is treated as if it were nil."
(save-excursion
;; If we need to ask for the tag table, allow that.
(let ((enable-recursive-minibuffers t))
next prev parent reply other threads:[~2019-10-09 6:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-28 7:59 bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file' Hong Xu
2019-09-28 8:11 ` Eli Zaretskii
2019-09-28 18:40 ` Hong Xu
2019-10-07 4:13 ` Lars Ingebrigtsen
2019-10-07 16:18 ` Eli Zaretskii
2019-10-07 17:27 ` Hong Xu
2019-10-08 16:21 ` Lars Ingebrigtsen
2019-10-09 6:39 ` Hong Xu [this message]
2019-10-09 8:09 ` Eli Zaretskii
2019-10-09 22:58 ` Hong Xu
2019-10-10 7:49 ` Eli Zaretskii
2019-10-12 0:48 ` Hong Xu
2019-10-12 9:04 ` Eli Zaretskii
2019-10-12 18:46 ` Hong Xu
2019-10-12 18:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=663aaf32-97c4-0723-1a30-a644938bd21f@topbug.net \
--to=hong@topbug.net \
--cc=37538@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.