From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: JD Smith Newsgroups: gmane.emacs.bugs Subject: bug#67533: SVG images confound position pixel measurements Date: Sun, 3 Dec 2023 16:25:01 -0500 Message-ID: <663EEC8D-2D83-422A-8EAA-262B2E9A4097@gmail.com> References: <9B9C683E-B951-406E-98AA-32F4539B3FF7@gmail.com> <83o7fbb0zf.fsf@gnu.org> <6158BB83-3C05-4CEC-BF65-A6C0DEA329CD@gmail.com> <837clybds3.fsf@gnu.org> <83wmtx83io.fsf@gnu.org> <906A480A-85B4-4AB0-B2E3-1533A48C228D@gmail.com> <835y1g8z7v.fsf@gnu.org> <8334wk8kd1.fsf@gnu.org> <8672011B-4C83-4983-9DEA-43ED009042F8@gmail.com> <616C9D31-F265-4735-B73E-C0574D79F7F1@gmail.com> <83r0k3782q.fsf@gnu.org> <83jzpv707n.fsf@gnu.org> <83h6kz6yeh.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_891791E5-F9D2-40ED-A121-1F2C22011999" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25380"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67533@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 03 22:26:06 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r9tyX-0006P3-H6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Dec 2023 22:26:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9tyO-0000oe-EK; Sun, 03 Dec 2023 16:25:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9tyM-0000oB-EX for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 16:25:54 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9tyK-0004pb-90 for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 16:25:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r9tyU-00084I-CB for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 16:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: JD Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Dec 2023 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67533 X-GNU-PR-Package: emacs Original-Received: via spool by 67533-submit@debbugs.gnu.org id=B67533.170163875030995 (code B ref 67533); Sun, 03 Dec 2023 21:26:02 +0000 Original-Received: (at 67533) by debbugs.gnu.org; 3 Dec 2023 21:25:50 +0000 Original-Received: from localhost ([127.0.0.1]:32874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9tyE-00083m-Ve for submit@debbugs.gnu.org; Sun, 03 Dec 2023 16:25:50 -0500 Original-Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]:49274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9txx-00083C-JU for 67533@debbugs.gnu.org; Sun, 03 Dec 2023 16:25:45 -0500 Original-Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-7b06844971dso115661839f.2 for <67533@debbugs.gnu.org>; Sun, 03 Dec 2023 13:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701638713; x=1702243513; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=Y7e8xXAXxAo6McSXN+4D5whBIOSnd001QT309Sfgtws=; b=NU7ghsvY3U95FhSvcw/tL94/98U8ULP7iHspeM9uX9KJkHpt0AlMlj9qH1FDfi5LRP dq9SVL1sUjbTFz2NwyQS2C7KxXAFKK7qFzpQOZTPWEZF3TbhIqxjIfSXbMEhP9ASPdCJ MO8HXRWekfJeXXPHpykjaO4uxfYL526Hqu2wq+EWMYLjI8a6BrPxg03gqdmcq5kapauP fbaqcr6VVEmPsfsMc0T7mBKWWGw3vHXReYtGcmto3yA0LOORM9c77FM6Wd22c9kSp2Y8 n87YrYj9/X8eaBhsg/7Tul2COJH4xiqStrnodhUVLzgjNSOUz3AlWQkc4sbCvDWCn2Zp 5AfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701638713; x=1702243513; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y7e8xXAXxAo6McSXN+4D5whBIOSnd001QT309Sfgtws=; b=CehuDLcr4WIqzzlbI++AZD8xNaVtp1o2cxf2jxVmCw8BLXMVHDsHiMYM7apgGwPN3O 3Cxdc20kBWryqkouy/djShbQ4JTIGAPHY4M3WNi/wvdssMK7gIn49iS70iw9OSguyNal tGDkg34xNAbYEyS4kwsoXGkSyi/i/lAWYs5x3b91u3GUB5NCZVRgToSqLLZDwoovSCXT XOE38VtA/wfCXdgcsaJDXq821cxrFQ/nB/vX6hCLoXwtral5rzkm9KApwOMDQHJ1gCDR eyb0+9iLlkBxtwbrHh/R7SwZbctNLnLDtgUbRqjGghuJVV8fvzEXGWWxGrWd04CRn6mK jL5w== X-Gm-Message-State: AOJu0YxthezhAtmpmyjrqiuQdKtoZ+eywQAluFS/a/WJmWYTydT3fwpT jx9CPudkq5U5JY/O3Z3+t5U= X-Google-Smtp-Source: AGHT+IGBe+aYTDinH6PRxvMsix9DjsQv2razuMhAX0qK55aISDzh/g7a7DlOXBvWR1L8ajg7APsBuA== X-Received: by 2002:a5d:938f:0:b0:7b3:8d4a:f45 with SMTP id c15-20020a5d938f000000b007b38d4a0f45mr1437031iol.9.1701638712783; Sun, 03 Dec 2023 13:25:12 -0800 (PST) Original-Received: from smtpclient.apple (cm-24-53-187-34.buckeyecom.net. [24.53.187.34]) by smtp.gmail.com with ESMTPSA id p19-20020a6bce13000000b0078647b08ab0sm2318933iob.6.2023.12.03.13.25.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Dec 2023 13:25:11 -0800 (PST) In-Reply-To: <83h6kz6yeh.fsf@gnu.org> X-Mailer: Apple Mail (2.3774.200.91.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275457 Archived-At: --Apple-Mail=_891791E5-F9D2-40ED-A121-1F2C22011999 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 I=E2=80=99m sorry to report that this fix seems to have introduced a = hard lockup in org-display-inline-images, when displaying images in an = org file with larger images. =20 I just confirmed by reverting to the state just before your patch was = applied to master. It may have something to do with the final large = image fix. > On Dec 3, 2023, at 11:31=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> Cc: 67533@debbugs.gnu.org >> Date: Sun, 03 Dec 2023 17:52:12 +0200 >> From: Eli Zaretskii >>=20 >>> From: JD Smith >>> Date: Sun, 3 Dec 2023 10:48:20 -0500 >>> Cc: 67533@debbugs.gnu.org >>>=20 >>>> The cumulative patch below should fix all the problems you threw on = me >>>> till now. >>>=20 >>> Most excellent, thank you for the sleuthing Eli! Your roll-up patch = applies cleanly and fixes all the pixel size related issues in my large = complex org-with-latex-preview file. I can induce the same behavior in = my original svg-generating code by bumping the default width up to: >>>=20 >>> (w (+ 142 (* 2 (round (expt (1+ r) 1.25))))) >>>=20 >>> and it solves it there too. (I=E2=80=99ve updated the gist to do = this, and included the final function below, for posterity). >>=20 >> Thanks, I will install the changes (on master) soon. >=20 > Now done. >=20 > Is there anything else to do here, or can we close this bug? >=20 > Thanks. --Apple-Mail=_891791E5-F9D2-40ED-A121-1F2C22011999 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 I=E2=80=99m = sorry to report that this fix seems to have introduced a hard lockup in = org-display-inline-images, when displaying images in an org file with = larger images.  

I just confirmed by reverting = to the state just before your patch was applied to master.  It may = have something to do with the final large image fix.

On Dec 3, 2023, at 11:31=E2=80=AFAM, Eli Zaretskii = <eliz@gnu.org> wrote:

Cc: 67533@debbugs.gnu.org
Date: Sun, 03 Dec = 2023 17:52:12 +0200
From: Eli Zaretskii = <eliz@gnu.org>

From: JD Smith = <jdtsmith@gmail.com>
Date: Sun, 3 Dec 2023 10:48:20 = -0500
Cc: 67533@debbugs.gnu.org

The = cumulative patch below should fix all the problems you threw on = me
till now.

Most excellent, thank you for the = sleuthing Eli!  Your roll-up patch applies cleanly and fixes all = the pixel size related issues in my large complex org-with-latex-preview = file.  I can induce the same behavior in my original svg-generating = code by bumping the default width up = to:

     (w (+ 142 (* 2 (round (expt (1+ = r) 1.25)))))

and it solves it there too. (I=E2=80=99ve updated = the gist to do this, and included the final function below, for = posterity).

Thanks, I will install the changes (on = master) soon.

Now = done.

Is there anything else = to do here, or can we close this bug?

Thanks.

= --Apple-Mail=_891791E5-F9D2-40ED-A121-1F2C22011999--