From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list Date: Thu, 9 Jan 2025 19:11:14 -0800 Message-ID: <661D61B6-CE81-4DA2-9BF3-6D638448798E@gmail.com> References: <87h66e8u59.fsf@gmail.com> <5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com> <864j294fxo.fsf@gnu.org> <86cygw31ji.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37049"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75362@debbugs.gnu.org, Randy Taylor , jroi.martin@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 10 04:12:28 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tW5Ri-0009Un-RT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jan 2025 04:12:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tW5RM-00058n-1N; Thu, 09 Jan 2025 22:12:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tW5RK-00058d-LJ for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 22:12:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tW5RK-0004KX-CY for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 22:12:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=1S/ntj8Nqd1srZNXN4gIAdzJ0YmwhJvVI60DT5LsgN8=; b=cPRmiqnYIcfe7Qs2wjXvQTW+asz7Pt02G4j153UwvE/hi7tgVcLt2gcunrnLVH7rJHvedYKvLMK5tYewOmw2tivQvVNxuMDZPyzExIgiVXvUmY3d6jf5jw7FRVAUd0Be2lwqQZAc60pAaeLjwiPmkxNRkw8x1wynFNlqbYwjram/gAaTA1bWozuwVFVqoacK1gDv7btryUfSZ6N74O5sa+YLgVF5p8h0qzm3Pvwnt6ihq16gV1NYqs70GXsbfaTcYKKvCqZj3i6K0q/TuKcYFTAVFHSqY7l+Xrlj3Upd11scE8VdoInYsH3ce/P76JzENihDMylpY8fMWEi3WfKcKw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tW5RJ-0006fg-R2 for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 22:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jan 2025 03:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75362 X-GNU-PR-Package: emacs Original-Received: via spool by 75362-submit@debbugs.gnu.org id=B75362.173647869725609 (code B ref 75362); Fri, 10 Jan 2025 03:12:01 +0000 Original-Received: (at 75362) by debbugs.gnu.org; 10 Jan 2025 03:11:37 +0000 Original-Received: from localhost ([127.0.0.1]:55928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tW5Qv-0006ey-0c for submit@debbugs.gnu.org; Thu, 09 Jan 2025 22:11:37 -0500 Original-Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:47425) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tW5Qr-0006ej-3e for 75362@debbugs.gnu.org; Thu, 09 Jan 2025 22:11:34 -0500 Original-Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-2f441791e40so2153991a91.3 for <75362@debbugs.gnu.org>; Thu, 09 Jan 2025 19:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736478687; x=1737083487; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1S/ntj8Nqd1srZNXN4gIAdzJ0YmwhJvVI60DT5LsgN8=; b=RvoLxqAuQ+HkdcNb8/jR7ZVok+g64CjaGE2OONaACaev4UrK3yQHyiMDvRnFl4P9mB CP0nuHHAr0vKtWZH/WJ3LXTPW3EjYLXEovtaGo0yhVRPuYQfpZ6y721hJ1HLcv/yOiWe cWT99FlRJVrhnsIjqsCi0onlwrgvPt1s7AEgSHNtCxOeltjyIQldvB9a90TEfnigbCxA 8grENYaRUEhKagy+h781Sf5qpmgdneRtf1s+tSbODU4tO1q9dlr90QqekwHGOlc+Z8if Leo/yRj3Wu4KCsg0VnHCYf3nVbwpRmEh/B83UffcijhCcEkxbwVqggvOSpnb9HJ/eDU8 GfGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736478687; x=1737083487; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1S/ntj8Nqd1srZNXN4gIAdzJ0YmwhJvVI60DT5LsgN8=; b=bXIAif6lRz6hYypEEVF9Z57ZtXpy0cA8WFzFwhiDSvU73pmOZ+dbJNxSrIfhaYqrYq Z7zqBEJQ/oXTDGanwu65/4WUx0anLnzVelx2RcoJPudGqoNlHYpH2018uyDkfNNbPxw0 uv1FsDlu6ijI1OXrT5IMeONQuLeVZYdShnnRqFH5l9/FoShLYwks3RcefUFE+ZsQ4j7i cM+eMkWXogOcOQ34rpnnd+foIFPBpTjv2Jk44PA3SUV7HD0p6wJj/PWG/0lP98vX5sRD WuEgFnXmUMQ4So31mrfO853fQ/EajPbyXDf0mmJrDYl7tbS2211IdBS04gJkqip7QUYj SscA== X-Forwarded-Encrypted: i=1; AJvYcCUCatb1Wid5qRxot/uPxyCVJDPgnXN+emTWdbVCzooWXr+NnmhUoY5xfkAKgt3+rte1HrzbKw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzOuwlSIdwrMU0bhiwTGOKwcLJ5ieYfFM/lboYsrb7W8h5syIJE TPiKwiwXQwBbXRRgBggfYEquQiFAIcb/5Z93ke7IZIcm2rpd7wEg X-Gm-Gg: ASbGncsxz3tTqt9ewdJozUHHwRIKnaomDxz5gUkuBzHv2ftTtK2mrh1qZdyCzPeSffI JhzNE7GeWmrt1OCzc8hJ9ZBbO6PFQz2q2fsDNwjb+1QZbXc4tAXlyu7T0iOaznFukTdZg191orG 5tFqa6T7UG3S/aPhzNh1cquIJqBygV1CV5fj+8MzzQmq/a8+0cIPQ8p+lJrSM3AQ2Ij2q7rKcRR 3Fd2+T6uklaS/eDlmL2PJT6QyH04Cd4st8vf6BcniAA4ca4ZUORCi7dxMM+EV5zt/0Wnn5dHGX4 KG4S X-Google-Smtp-Source: AGHT+IFtENuZ78sv2Xsr8szDae/Dmyd4X5fqek+FA+UK8Y3q+gE6vCQkb5/TeEkH6xJooxrzyaydZw== X-Received: by 2002:a17:90b:6d0:b0:2ee:889b:b11e with SMTP id 98e67ed59e1d1-2f5490bd257mr13521803a91.30.1736478686953; Thu, 09 Jan 2025 19:11:26 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:d801:ab3e:9baf:5ef1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f26aab9sm4769065ad.256.2025.01.09.19.11.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jan 2025 19:11:26 -0800 (PST) In-Reply-To: <86cygw31ji.fsf@gnu.org> X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298859 Archived-At: > On Jan 8, 2025, at 11:10=E2=80=AFPM, Eli Zaretskii = wrote: >=20 >> Date: Wed, 08 Jan 2025 13:20:19 +0000 >> From: Randy Taylor >> Cc: Yuan Fu , 75362@debbugs.gnu.org, = jroi.martin@gmail.com >>=20 >> On Wednesday, January 8th, 2025 at 08:02, Eli Zaretskii = wrote: >>>=20 >>>=20 >>>> Cc: 75362@debbugs.gnu.org, Roi Martin jroi.martin@gmail.com >>>=20 >>>> From: Yuan Fu casouri@gmail.com >>>> Date: Tue, 7 Jan 2025 22:18:53 -0800 >>>>=20 >>>>> The attached patch fixes it for = me.<0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch> >>>>=20 >>>> Thanks Randy. Eli, should we apply this to emacs-30. >>>=20 >>>=20 >>> Is this backward-compatible to older grammars? If yes, it's okay to >>> install on emacs-30. If it is not compatible, I'd like to see how a >>> compatible patch will look before I decide. >>=20 >> Yes, it's backward-compatible. >=20 > OK, then, Yuan, please feel free to install on emacs-30. Installed. As for cmake-ts-mode=E2=80=99s fix, it=E2=80=99s in = 4def541bbfe67b1a492e8a3b6041a1d8f76d680b Basically, tree-sitter-cmake gives up on parsing cmake generator = expressions. According to the commit message: > feat!: remove parsing generator expressions >=20 > Parsing generator expressions statically is impossible since whether = an argument is interpreted as a generator expression or not depends on = the function itself. Hence, the parsing for it is removed. >=20 Which makes sense to me. The fix is backward-compatible too, since = we=E2=80=99re just removing fontification for angle brackets. Yuan