From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15746: 24.3; [PATCH] bookmark should confirm when overwrite Date: Tue, 29 Oct 2013 07:20:07 -0700 (PDT) Message-ID: <660c7427-6f91-46df-ac04-80bb907e1e85@default> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1383056485 9687 80.91.229.3 (29 Oct 2013 14:21:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Oct 2013 14:21:25 +0000 (UTC) Cc: Karl Fogel To: Leo Liu , 15746@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 29 15:21:28 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VbAAe-0002Lz-CK for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Oct 2013 15:21:24 +0100 Original-Received: from localhost ([::1]:47457 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbAAd-0005qq-NZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Oct 2013 10:21:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbAAR-0005qR-NV for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 10:21:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbAAJ-0007Z7-4C for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 10:21:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbAAJ-0007Z2-0m for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 10:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VbAAI-0001Js-EN for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Oct 2013 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15746-submit@debbugs.gnu.org id=B15746.13830564194995 (code B ref 15746); Tue, 29 Oct 2013 14:21:02 +0000 Original-Received: (at 15746) by debbugs.gnu.org; 29 Oct 2013 14:20:19 +0000 Original-Received: from localhost ([127.0.0.1]:51237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbA9a-0001IU-GA for submit@debbugs.gnu.org; Tue, 29 Oct 2013 10:20:19 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:39276) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbA9Y-0001IH-3t for 15746@debbugs.gnu.org; Tue, 29 Oct 2013 10:20:16 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r9TEK96d025277 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 29 Oct 2013 14:20:10 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9TEK8lr001496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 29 Oct 2013 14:20:09 GMT Original-Received: from abhmt113.oracle.com (abhmt113.oracle.com [141.146.116.65]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9TEK8vA022213; Tue, 29 Oct 2013 14:20:08 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79749 Archived-At: > Occationally I have overwritten bookmarks with regrets. So maybe > something along the following lines is needed. It is not needed, IMO. The point of `bookmark-set' is to set a bookmark, just like the point of `setq' (unlike `defvar') is to set a variable value, whether or not the variable already has a value. As far as I am concerned, it would be OK to add a separate new command for the behavior you want (without binding it to `C-x r m'). Or to add a user option that `bookmark-set' tests, to optionally (not by default) do what you want. But the default behavior of `bookmark-set' should not be changed this way, IMO. (FWIW, even if you do do the wrong thing occasionally, you need not necessarily regret it. Your updated bookmark is not saved=20 immediately, depending on your value of `bookmark-save-flag'. If you are worried about your occasional `bookmark-set' mistakes, consider = setting `bookmark-save-flag' to `nil'. Of course, you might also want to then check such a bookmark before explicitly using `bookmark-save'.) [(OT) Replying to a yes-or-no question is not a *user* error, even if the misnamed `user-error' is appropriate here (which it is). Just one more indication why "user-error" is the wrong name for its intended behavior (=3D any error other than a coding error).]