From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Thu, 24 Aug 2023 18:58:52 -0300 Message-ID: <65eb4677-5ae3-5170-1b37-2e02f974c972@gmail.com> References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> <87h6oo2may.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13387"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Ola x Nilsson , 64046@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 25 00:00:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZINR-0003Io-7D for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Aug 2023 00:00:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZIN2-0006K1-Nh; Thu, 24 Aug 2023 18:00:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZIMw-0006Id-Ik for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 17:59:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZIMw-0003aR-Aa for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 17:59:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZIN0-00069A-Bn for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 18:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 22:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs Original-Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169291434823531 (code B ref 64046); Thu, 24 Aug 2023 22:00:02 +0000 Original-Received: (at 64046) by debbugs.gnu.org; 24 Aug 2023 21:59:08 +0000 Original-Received: from localhost ([127.0.0.1]:38797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZIM8-00067T-5N for submit@debbugs.gnu.org; Thu, 24 Aug 2023 17:59:08 -0400 Original-Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]:50260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZIM6-000672-Hr for 64046@debbugs.gnu.org; Thu, 24 Aug 2023 17:59:07 -0400 Original-Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6bca3311b4fso261882a34.0 for <64046@debbugs.gnu.org>; Thu, 24 Aug 2023 14:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692914336; x=1693519136; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l/XeKwSTuBmhqfrYFX4gwuTjmCyU/fERonidfUJFBjc=; b=hURpkHAJ5Y3t34Uv5dn5VcCaXYVkibIFoiP91/7ZJpzDTqr843YFciOGtmQljxZwgU UWCpSfz8wJhCyELeDN7FJZj4kgW3NK+8GzWcEKmmCuhKW5o6F5//zP9F78mfBe1o8kXA AtJp8HDdxJXFsRi6tRSlILMNmh1IhEcc3vPornJ/VuZZzYeL5bkwxjZYuIEYrkiJ+/WO 1XbCMee1PWlTupQ3M4mqNR1BW9X/JZrvUDoN6RuaJLqGo2Y6DRfryjlHpcgdFs/YSk39 mbhr6oJ8RBKw5l7M3gwXtdCaFTzVw6nigzOyCEoInk5ZOZoPF+CdzRaWdbVcG0Cqy1x5 hTRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692914336; x=1693519136; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l/XeKwSTuBmhqfrYFX4gwuTjmCyU/fERonidfUJFBjc=; b=Wzc09IzaT+AjG9RfpdsiW4NBbhlYS+0UNdk10a+fWiSVdvhjIiL4DQPivRtiOeL2y1 RsygLuaWOTyAGrmtrs6YN00oa3mkd4+WiRwg2xXQpr9kOUi7QXwe1jUuZY8IcM1bWKPn ZXJFT93K4gx87J/LCBA44Cl/MBj+p5hHu2u3tXjk/XJs244zjL4vBHJobpkYMYwG1G4g Ml1fwC0+I0PdWztNED5ms6NY50N8sK8vGkvzHj96V9j61FNZSUexKP6a3q6JIZV/c+BS 9len2OqpIEq4+S4q37aK4cfM2VAb57eNSDEq2zbwbOXsI1dUtG8SD45yzUyXF3MlXd90 hhRg== X-Gm-Message-State: AOJu0Yw2s/zWlYN8LORzZcn40eFM3mtBHIeu9Y5qxcMxdUHbsXp3COmi 3vlPuMS/ysjf/0B/QW/ggzM= X-Google-Smtp-Source: AGHT+IE1uqM4hOGM4VzQllMVFoQ2WHnLFnnmg5pY7P+Iegw4wxC+smD013Zm6hcI20ctYG8/ZhDyYQ== X-Received: by 2002:a05:6870:4289:b0:1c7:ebf5:b6cb with SMTP id y9-20020a056870428900b001c7ebf5b6cbmr1154240oah.25.1692914336376; Thu, 24 Aug 2023 14:58:56 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id eg29-20020a056870989d00b001c4d922b4fasm298537oab.8.2023.08.24.14.58.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 14:58:55 -0700 (PDT) Content-Language: en-US In-Reply-To: <87h6oo2may.fsf@gmx.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268371 Archived-At: Stephen Berman writes: > On Thu, 24 Aug 2023 17:14:53 -0300 Mauro Aranda wrote: > >> Stephen Berman writes: >> >>> Right after sending, I found an obvious problem: only one of the car or >>> the cdr might be a string.  The following patch accounts for this: >>> >>> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el >>> index a70598bb6c9..891e98b6de5 100644 >>> --- a/lisp/wid-edit.el >>> +++ b/lisp/wid-edit.el >>> @@ -285,12 +285,18 @@ widget-choose >>>    ;; Apply quote substitution to customize choice menu item text, >>>    ;; whether it occurs in a widget buffer or in a popup menu. >>>    (let ((items (mapc (lambda (x) >>> -                       (when (consp x) >>> -                         (dotimes (i (1- (length x))) >>> -                           (when (stringp (nth i x)) >>> -                             (setcar (nthcdr i x) >>> - (substitute-command-keys >>> -                                      (car (nthcdr i x)))))))) >>> +                       (if (proper-list-p x) >>> +                           (dotimes (i (1- (length x))) >>> +                             (when (stringp (nth i x)) >>> +                               (setcar (nthcdr i x) >>> + (substitute-command-keys >>> +                                        (car (nthcdr i x)))))) >>> +                         ;; ITEMS has simple item definitions. >>> +                         (when (consp x) >>> +                           (when (stringp (car x)) >>> +                             (setcar x (substitute-command-keys (car x)))) >>> +                           (when (stringp (cdr x)) >>> +                             (setcdr x (substitute-command-keys (cdr >>   x))))))) >> >> Thinking about it, why do we need to call substitute-command-keys on the >> VALUE part (i.e., the cdr of the cons cell), in case of simple item >> definitions? >> >> I re-read the bug report, but I didn't find any reference to why that is >> a need.  Did I miss something? > > Well, the VALUE is displayed on entering a choice.  That is, when I do > > M-: (widget-choose "Title" '(("Use `a'" . "Use `1'") ("Use `b'" . "Use `2'"))) > > I see curve-quoting in the widget-choose buffer: > >    Available choices: > >    0 = Use ‘a’ >    1 = Use ‘b’ > >    C-g = Quit > > and when I enter e.g. `0' at the "Title: " prompt in the minibuffer, it > displays "Use ‘1’", i.e., with curve-quoting.  But if I omit the call to > substitute-command-keys on the cdr in widget-choose, then typing `0' at > the "Title: " prompt displays "Use `1'", i.e. with grave-quoting.  But I > don't know which one is the intended result. I see, thank you.  Your last patch looks good to me, then.