From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Sat, 30 Jul 2022 18:47:04 +0000 Message-ID: <65cb7c73fd6ca16565e1@heytings.org> References: <83zggwcby5.fsf@gnu.org> <83o7xccagi.fsf@gnu.org> <831qu7daxb.fsf@gnu.org> <83sfmnb7yg.fsf@gnu.org> <837d3ybh5z.fsf@gnu.org> <136c4fe0fc74196714aa@heytings.org> <83pmhp89ov.fsf@gnu.org> <136c4fe0fc39573addc9@heytings.org> <83k07x8738.fsf@gnu.org> <136c4fe0fcdf00ef9a11@heytings.org> <83h73183r7.fsf@gnu.org> <136c4fe0fc0fceb0d752@heytings.org> <838roc8ka7.fsf@gnu.org> <83tu706obt.fsf@gnu.org> <83h7306ifa.fsf@gnu.org> <83edy37pul.fsf@gnu.org> <83pmhn55sk.fsf@gnu.org> <65cb7c73fdc753518d35@heytings.org> <83fsii68o3.fsf@gnu.org> <65cb7c73fdf6704d19d5@heytings.org> <835yje62vz.fsf@gnu.org> <65cb7c73fd159efe32af@heytings.org> <83zggq4fgb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17022"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 56682@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 30 20:48:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHrVc-0004Ab-Ex for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Jul 2022 20:48:20 +0200 Original-Received: from localhost ([::1]:53704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHrVa-00014M-88 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Jul 2022 14:48:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHrVL-00013w-QB for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2022 14:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46011) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oHrVK-00064n-50 for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2022 14:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oHrVK-0000Y1-0m for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2022 14:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jul 2022 18:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.16592068281920 (code B ref 56682); Sat, 30 Jul 2022 18:48:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 30 Jul 2022 18:47:08 +0000 Original-Received: from localhost ([127.0.0.1]:35760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oHrUS-0000Ut-6f for submit@debbugs.gnu.org; Sat, 30 Jul 2022 14:47:08 -0400 Original-Received: from heytings.org ([95.142.160.155]:59542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oHrUQ-0000Ul-4O for 56682@debbugs.gnu.org; Sat, 30 Jul 2022 14:47:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1659206825; bh=/GqYo8rd/3Rm0xBcNpeyhUhv8EgKs39mD6E+VZKym78=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=UvjDzgYu6nM3vIxF0dV8U9sf8GJcQetQJPYfRraZuc78A3OXgQndl7rl0x6Bwh3U5 QW1UD8kriVf+OIR0KcCSb9nkNkivEDmZdlGEr5CDocDtfk+ajIUeF9griVLUGJpitt TJHabW8lOZNTnFx5KR6eclHLoq7Qd5/LlW2tYiIQrdAsqjo7K/CvRAz7PzwThUOf52 WCPpK1jwxICHZtwJixyGl2wxOh3MNoX0AOvdP/uiT7vUWq8Qzw9jO6T0TqMqVv6igf IifVcVBCsBDrzD6Tz6afZBAqUZqta2FgASzNYAl283HahuWM8i9qIqJQQTD/strBLu Y4zlQMU+gLj+A== In-Reply-To: <83zggq4fgb.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238308 Archived-At: >> Wouldn't it make sense to also limit the portion of the buffer to which >> pre-/post-command-hook have access (see below)? > > Those generally don't belong to the display department, so I'd hesitate > doing so. Which pre-/post-command-hook functions did you find that > cause slowdown because of long lines. > jit-lock--antiblink-post-command >> With that patch, I was able to open and edit a file with a single 50 GB >> (!) line, in js-mode. Does that still not qualify as "arbitrarily >> large"? > > We don't even claim to be able to edit _files_ of arbitrary size > (because we are limited by fixnums). > That's theory, isn't it? With 64-bit builds we are limited to files that are less than 2047 Po. No computer on this planet has that much RAM. >> I compared that with a 50 GB JSON file with 80 character wide lines. >> With that file it was necessary to disable font-lock-mode, which took >> too much time. > > How so? We now restrict font-lock to a small region, so why does it > matter how much more stuff is there outside of the viewport? What other > aspects of the line size still affect performance? > We do not restrict font-lock in large files _without long lines_, hence the difference.