From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: PL support Date: Sat, 9 May 2020 22:12:06 +0300 Message-ID: <65bfd7bb-34e5-53ca-a7c1-dfd0d22eeb9d@yandex.ru> References: <9mmFgzvrBwjt_n_VJyaJdXINraNi5HsGpwq-0MLeKiJA7kG2BQA4uywrzjyz7lpRS0OZDpjEi8lspOKYUA7P_QsODsDew_8nbH960G55fmY=@protonmail.com> <83imh5hby1.fsf@gnu.org> <2e4e8ce9-d857-f3e3-31cf-a40dee67bd25@yandex.ru> <83y2q1dsvh.fsf@gnu.org> <2468efa6-7dbd-8634-44cc-586bb6985f49@yandex.ru> <83pnbddrfd.fsf@gnu.org> <83k11ldpxs.fsf@gnu.org> <83imh5dnun.fsf@gnu.org> <83h7wpdms7.fsf@gnu.org> <88adcf52-7310-6d48-ab31-5d427deaa89d@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="92401"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: Eli Zaretskii , Stefan Monnier , emacs-devel To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 09 21:12:51 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jXUu3-000Nwr-TM for ged-emacs-devel@m.gmane-mx.org; Sat, 09 May 2020 21:12:51 +0200 Original-Received: from localhost ([::1]:52618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXUu2-0006Cj-G1 for ged-emacs-devel@m.gmane-mx.org; Sat, 09 May 2020 15:12:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXUtO-0005l9-VZ for emacs-devel@gnu.org; Sat, 09 May 2020 15:12:11 -0400 Original-Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:55360) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXUtO-0002ho-95; Sat, 09 May 2020 15:12:10 -0400 Original-Received: by mail-wm1-x331.google.com with SMTP id e26so13595449wmk.5; Sat, 09 May 2020 12:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bkZ3Eo74e8622HkOairDVdfbEx2MjAaPxkOWpwlxV9w=; b=NImzFLNllCmqY+YZIYycY6y3pfVVPEtiH4Z/jKY1cLqwsQwkr5d2TnW+I4oBHJKcnt HemPZJ/dmyiXnRmOrGcUSMW4ApMeOwMPgW8sW1EVtlVS4dCIV7dmxO20Z/KRCZO+U/CN TfYjLa6HpNjkvD1SLvyKXY8HxBF+mZccuFU0kj7IG9tXM2KVN9HEJXhrRQJL8jcbJj4a ADf/BR+Zd3RD6o6dVOYnZjBYHG70HrzZZMT4dKGzH4DjZ4kgQDltBb4jugcis8rgJ080 q5+xyN3i8SFel/sfFAsykeJfPWLKnXXdFY6V1PfRCxfXMxYc92pyE/TPRLPZhvs9Aqjk LBwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bkZ3Eo74e8622HkOairDVdfbEx2MjAaPxkOWpwlxV9w=; b=Yt3SxcSetCRx2cTX7bCDFAnwUJU2pK5U4SYa6yRdztU4jdNx+uXTgsjgeTGspFj0WV A7mGnF2W22q1lRFaw9nOQr2L5sWkNpf6exHx3GdMJmavPT5J1Tbyq19yqRxRRHoiYzL2 BZKZYpSCJ5Q5n5dCev6g0lWDWLHhBgZXXCAM7Z/XGNhYd/sviJzT5/6s9K/b52yiHF2J LXQPxxMJN28IJgKQWXU4XUwUjjlylnSZfGdMdQrUS4MzULYLoNgmUgLgCs/yPwtSJ25X ft0Llool813TYbsR4Dx5vI/d9Jx2mEWVhKdZY3ZbG59Ydi54uXN++1fl6oCKnOLC4ExU 5VQw== X-Gm-Message-State: AGi0PuYN1B4uPAYFGKRvq68ItHJ78i2VigwjzbFMY16yk8votgh/xMnr lYjKCvUndP5QRx5qbTWrkE6o7Ukv X-Google-Smtp-Source: APiQypIKI2/DwWxM5etTdcumK9I46SLI3ArOD/Me/TErZzBKJkBQpyyqInFXzikG75VsRcH/mWEe8A== X-Received: by 2002:a05:600c:296:: with SMTP id 22mr19074885wmk.98.1589051528077; Sat, 09 May 2020 12:12:08 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id m6sm9002965wrq.5.2020.05.09.12.12.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2020 12:12:07 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=raaahh@gmail.com; helo=mail-wm1-x331.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249556 Archived-At: On 09.05.2020 21:47, João Távora wrote: >> That doesn't sound too bad. Bonus points if the same hooks could be >> universal for the LSP protocol, i.e. if lsp-mode could conceivably use >> them too. > > The thing is, you haven't exactly explained why Eglot in core sounds > bad, either. You say Eglot in GNU Elpa is decent already and I agree. Imagine taking the whole of MELPA and putting it inside the Emacs repository. Why would it be a bad idea? Lots of different codebases developed by different people with different responsibilities. Our bug tracker and development workflow has no solutions to this problem: everybody has to read every bug report and every commit message. > But having it in core would bring some advantages, particularly for > me, I admit. Having to jump back and forth between xref.el, project.el, > eldoc.el, flymake.el, jsonrpc.el and eglot.el in different repos is not > much fun. These are just two repositories between these packages. Making concerted changes could become easier sometimes, but it would also become easier to break backward compatibility. All of these packages don't serve Eglot only, and making a change in Emacs separately is a good reminder of that separation.