From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Florian Rommel Newsgroups: gmane.emacs.bugs Subject: bug#55588: pgtk: child-frame-border-width cannot be set to nil Date: Mon, 23 May 2022 00:03:23 +0200 Message-ID: <65b11da33708e6da3989750bfdb59804b8e9be3d.camel@florommel.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-o2xfuUK3aVAs1dv5YAhf" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15761"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.44.1 To: 55588@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 23 03:49:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nsxCA-0003ti-6x for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 May 2022 03:49:18 +0200 Original-Received: from localhost ([::1]:33902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nsxC8-0006eY-HJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 May 2022 21:49:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsxBu-0006eF-Md for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 21:49:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52851) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nsxBu-00023Y-EB for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 21:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nsxBu-00050e-Cc for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 21:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Florian Rommel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 May 2022 01:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55588 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.165327053619226 (code B ref -1); Mon, 23 May 2022 01:49:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 May 2022 01:48:56 +0000 Original-Received: from localhost ([127.0.0.1]:46744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsxBk-0004zx-5Q for submit@debbugs.gnu.org; Sun, 22 May 2022 21:48:55 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:37500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nstfn-0007tP-Kz for submit@debbugs.gnu.org; Sun, 22 May 2022 18:03:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nstfn-00026s-Ej for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 18:03:39 -0400 Original-Received: from read.uberspace.de ([185.26.156.133]:45998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nstfl-0002Kl-Ij for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 18:03:39 -0400 Original-Received: (qmail 23071 invoked by uid 990); 22 May 2022 22:03:28 -0000 Authentication-Results: read.uberspace.de; auth=pass (plain) X-Rspamd-Bar: - X-Rspamd-Report: BAYES_HAM(-2.996284) MIME_GOOD(-0.1) MIME_BASE64_TEXT_BOGUS(1) MIME_BASE64_TEXT(0.1) X-Rspamd-Score: -1.996284 Original-Received: from unknown (HELO unkown) (::1) by read.uberspace.de (Haraka/2.8.28) with ESMTPSA; Mon, 23 May 2022 00:03:28 +0200 Received-SPF: pass client-ip=185.26.156.133; envelope-from=mail@florommel.de; helo=read.uberspace.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 22 May 2022 21:48:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232922 Archived-At: --=-o2xfuUK3aVAs1dv5YAhf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable In pgtk, child-frame-border-width is set to 0 by default, and it cannot be set to nil. According to the manual it should be possible for child-frame-border- width to be nil. In such cases, the value of internal-border-width is used as the border width (see 30.4.3.4 "Layout Parameters"; and function FRAME_INTERNAL_BORDER_WIDTH in frame.h). The problem causes missing child-frame borders for code that depends on this behavior (e.g., lsp-doc-ui in the lsp-ui package), and it will cause errors for code that tries to set child-frame-border-width to nil. The attached patch fixes this. It essentially replicates the respective behavior of xfns.c. --=-o2xfuUK3aVAs1dv5YAhf Content-Disposition: attachment; filename="0001-pgtk-Allow-child-frame-border-width-to-be-nil.patch" Content-Type: text/x-patch; name="0001-pgtk-Allow-child-frame-border-width-to-be-nil.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAwNTQ3OTg0MGMxMjE3NGJhYThiMWRlNjFjODAxNTZlZTdkNTZkZDM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGbG9yaWFuIFJvbW1lbCA8bWFpbEBmbG9yb21tZWwuZGU+CkRh dGU6IFN1biwgMjIgTWF5IDIwMjIgMjM6MzA6NTIgKzAyMDAKU3ViamVjdDogW1BBVENIXSBwZ3Rr OiBBbGxvdyBjaGlsZC1mcmFtZS1ib3JkZXItd2lkdGggdG8gYmUgbmlsCgoqIHNyYy9wZ3RrZm5z LmMgKHBndGtfc2V0X2NoaWxkX2ZyYW1lX2JvcmRlcl93aWR0aCwgeC1jcmVhdGUtZnJhbWUpOgpB bGxvdyBjaGlsZC1mcmFtZS1ib3JkZXItd2lkdGggdG8gYmUgc2V0IHRvIG5pbCwgYW5kIHNldCBp dHMgZGVmYXVsdAp2YWx1ZSB0byBuaWwuCgpDb3B5cmlnaHQtcGFwZXJ3b3JrLWV4ZW1wdDogeWVz Ci0tLQogc3JjL3BndGtmbnMuYyB8IDEyICsrKysrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDkg aW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvcGd0a2Zucy5j IGIvc3JjL3BndGtmbnMuYwppbmRleCAxZmViM2ZlMjUwLi4wNzY0ZTRhMmQ1IDEwMDY0NAotLS0g YS9zcmMvcGd0a2Zucy5jCisrKyBiL3NyYy9wZ3RrZm5zLmMKQEAgLTU2Niw3ICs1NjYsMTQgQEAg cGd0a19zZXRfdG9vbF9iYXJfbGluZXMgKHN0cnVjdCBmcmFtZSAqZiwgTGlzcF9PYmplY3QgdmFs dWUsIExpc3BfT2JqZWN0IG9sZHZhbCkKIHN0YXRpYyB2b2lkCiBwZ3RrX3NldF9jaGlsZF9mcmFt ZV9ib3JkZXJfd2lkdGggKHN0cnVjdCBmcmFtZSAqZiwgTGlzcF9PYmplY3QgYXJnLCBMaXNwX09i amVjdCBvbGR2YWwpCiB7Ci0gIGludCBib3JkZXIgPSBjaGVja19pbnRfbm9ubmVnYXRpdmUgKGFy Zyk7CisgIGludCBib3JkZXI7CisKKyAgaWYgKE5JTFAgKGFyZykpCisgICAgYm9yZGVyID0gLTE7 CisgIGVsc2UgaWYgKFJBTkdFRF9GSVhOVU1QICgwLCBhcmcsIElOVF9NQVgpKQorICAgIGJvcmRl ciA9IFhGSVhOQVQgKGFyZyk7CisgIGVsc2UKKyAgICBzaWduYWxfZXJyb3IgKCJJbnZhbGlkIGNo aWxkIGZyYW1lIGJvcmRlciB3aWR0aCIsIGFyZyk7CiAKICAgaWYgKGJvcmRlciAhPSBGUkFNRV9D SElMRF9GUkFNRV9CT1JERVJfV0lEVEggKGYpKQogICAgIHsKQEAgLTE0MjksOCArMTQzNiw3IEBA IFRoaXMgZnVuY3Rpb24gaXMgYW4gaW50ZXJuYWwgcHJpbWl0aXZlLS11c2UgYG1ha2UtZnJhbWUn IGluc3RlYWQuICAqLyApCiAKICAgICB9CiAKLSAgZ3VpX2RlZmF1bHRfcGFyYW1ldGVyIChmLCBw YXJtcywgUWNoaWxkX2ZyYW1lX2JvcmRlcl93aWR0aCwKLQkJCSBtYWtlX2ZpeG51bSAoMCksCisg IGd1aV9kZWZhdWx0X3BhcmFtZXRlciAoZiwgcGFybXMsIFFjaGlsZF9mcmFtZV9ib3JkZXJfd2lk dGgsIFFuaWwsCiAJCQkgImNoaWxkRnJhbWVCb3JkZXJXaWR0aCIsICJjaGlsZEZyYW1lQm9yZGVy V2lkdGgiLAogCQkJIFJFU19UWVBFX05VTUJFUik7CiAgIGd1aV9kZWZhdWx0X3BhcmFtZXRlciAo ZiwgcGFybXMsIFFyaWdodF9kaXZpZGVyX3dpZHRoLCBtYWtlX2ZpeG51bSAoMCksCi0tIAoyLjM2 LjEKCg== --=-o2xfuUK3aVAs1dv5YAhf--