From: Florian Rommel <mail@florommel.de>
To: 55588@debbugs.gnu.org
Subject: bug#55588: pgtk: child-frame-border-width cannot be set to nil
Date: Mon, 23 May 2022 00:03:23 +0200 [thread overview]
Message-ID: <65b11da33708e6da3989750bfdb59804b8e9be3d.camel@florommel.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
In pgtk, child-frame-border-width is set to 0 by default, and it cannot
be set to nil.
According to the manual it should be possible for child-frame-border-
width to be nil. In such cases, the value of internal-border-width is
used as the border width (see 30.4.3.4 "Layout Parameters"; and
function FRAME_INTERNAL_BORDER_WIDTH in frame.h).
The problem causes missing child-frame borders for code that depends on
this behavior (e.g., lsp-doc-ui in the lsp-ui package), and it will
cause errors for code that tries to set child-frame-border-width to
nil.
The attached patch fixes this. It essentially replicates the respective
behavior of xfns.c.
[-- Attachment #2: 0001-pgtk-Allow-child-frame-border-width-to-be-nil.patch --]
[-- Type: text/x-patch, Size: 1543 bytes --]
From 05479840c12174baa8b1de61c80156ee7d56dd38 Mon Sep 17 00:00:00 2001
From: Florian Rommel <mail@florommel.de>
Date: Sun, 22 May 2022 23:30:52 +0200
Subject: [PATCH] pgtk: Allow child-frame-border-width to be nil
* src/pgtkfns.c (pgtk_set_child_frame_border_width, x-create-frame):
Allow child-frame-border-width to be set to nil, and set its default
value to nil.
Copyright-paperwork-exempt: yes
---
src/pgtkfns.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/pgtkfns.c b/src/pgtkfns.c
index 1feb3fe250..0764e4a2d5 100644
--- a/src/pgtkfns.c
+++ b/src/pgtkfns.c
@@ -566,7 +566,14 @@ pgtk_set_tool_bar_lines (struct frame *f, Lisp_Object value, Lisp_Object oldval)
static void
pgtk_set_child_frame_border_width (struct frame *f, Lisp_Object arg, Lisp_Object oldval)
{
- int border = check_int_nonnegative (arg);
+ int border;
+
+ if (NILP (arg))
+ border = -1;
+ else if (RANGED_FIXNUMP (0, arg, INT_MAX))
+ border = XFIXNAT (arg);
+ else
+ signal_error ("Invalid child frame border width", arg);
if (border != FRAME_CHILD_FRAME_BORDER_WIDTH (f))
{
@@ -1429,8 +1436,7 @@ This function is an internal primitive--use `make-frame' instead. */ )
}
- gui_default_parameter (f, parms, Qchild_frame_border_width,
- make_fixnum (0),
+ gui_default_parameter (f, parms, Qchild_frame_border_width, Qnil,
"childFrameBorderWidth", "childFrameBorderWidth",
RES_TYPE_NUMBER);
gui_default_parameter (f, parms, Qright_divider_width, make_fixnum (0),
--
2.36.1
next reply other threads:[~2022-05-22 22:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 22:03 Florian Rommel [this message]
2022-05-23 4:18 ` bug#55588: pgtk: child-frame-border-width cannot be set to nil Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-23 5:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-23 9:38 ` Florian Rommel
2022-05-23 12:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-21 11:45 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65b11da33708e6da3989750bfdb59804b8e9be3d.camel@florommel.de \
--to=mail@florommel.de \
--cc=55588@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.