From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#58921: Tab completion hangs in eshell Date: Fri, 3 Mar 2023 21:37:05 -0800 Message-ID: <657cb4fc-5162-0a6e-776d-0f34ebce7fc8@gmail.com> References: <2cb2b8aa-0813-5eae-3bfc-27831b3d50dd@housseini.me> <010201842d4961c3-56e13f9e-0c67-4fd2-9731-657c131da32c-000000@eu-west-1.amazonses.com> <537afe67-809e-c09b-db84-05f41ba5d3b4@gmail.com> <714828fe-bf60-f991-363b-6ee86fd70c30@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25139"; mail-complaints-to="usenet@ciao.gmane.io" Cc: reza , 58921@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 04 06:38:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYKbE-0006HF-8x for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Mar 2023 06:38:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYKaq-0006oW-UY; Sat, 04 Mar 2023 00:38:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYKao-0006oE-UH for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 00:38:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYKao-0000NR-Ex for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 00:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYKan-0005VC-Tz for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 00:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Mar 2023 05:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58921 X-GNU-PR-Package: emacs Original-Received: via spool by 58921-submit@debbugs.gnu.org id=B58921.167790823421094 (code B ref 58921); Sat, 04 Mar 2023 05:38:01 +0000 Original-Received: (at 58921) by debbugs.gnu.org; 4 Mar 2023 05:37:14 +0000 Original-Received: from localhost ([127.0.0.1]:35105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYKa2-0005UA-Ab for submit@debbugs.gnu.org; Sat, 04 Mar 2023 00:37:14 -0500 Original-Received: from mail-pj1-f45.google.com ([209.85.216.45]:51948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYKa0-0005Tu-BD for 58921@debbugs.gnu.org; Sat, 04 Mar 2023 00:37:12 -0500 Original-Received: by mail-pj1-f45.google.com with SMTP id kb15so4747569pjb.1 for <58921@debbugs.gnu.org>; Fri, 03 Mar 2023 21:37:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677908226; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=aDWFWPLM9IycvmDtz+B/y/F73/EDQjyogNA4xNcW0vU=; b=S6fWhxi/I+Tq8+sH7WT/LVUTh0LFfbgRd35vmuWo8dURlu/vPBiphYCk9Nvr8Qk5OP LridMgrr8UrqRS/vhY+YEizsa/Rrvv7xMC7tR4+ncazNcpK3CXpjmsIdcFKdqya/sPf3 ymJQ7YIapOsmZs8LJKlUI9ug/soO7Le8aYXj6UNRGI/kfc7TclO9o7GSKR00OCLkouuD TZ4XFp/Jw+ailj1wID5Yl9s3Ubg9l7FPBJzaFL7TnEavzS+9BH5C/QKjrBXJmCsVdfNV BMMYpbyTgxRma+iTPoxFFzr7jHphvkLp04jjIU0QSINzPDUwRXheNnFqXLxk712eQD5A Z++A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677908226; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aDWFWPLM9IycvmDtz+B/y/F73/EDQjyogNA4xNcW0vU=; b=xGYnfYsOVpCDL1iYc8Z9lZMRyT97+tngRksjOJatutPWcUaXKwHTwz18oMKWJ6YHb8 ktGgcQR0aDvSmCfXHKhiwvSRtw0+OrQemRRvZ/CcrjbWXyhDkAsdxZvNswBwbM6Ou0Px o5Q8uBkH9mYEyjQpxKF4dli3PFHQlv7A0bCVRMsbArhSgM9mIq6Bdwis03z2Drcac81b 119KTXWb5nwj+XPHqVYtl2GaA+ky5SKwAq+d0d9es3r5AIxKzpV/Gh4aS+mxlxCfdM26 DWvknQYLo7XOvfD1ZLPmzAnCroPg1S3Ca3QNkGhLctd0atjShWoxoZ8hAkaO8COpeUlx h4Lw== X-Gm-Message-State: AO0yUKVOo8W+xJjOaKT2j1B7xvUVnZMskX3BZNCR4uDuWbow09rtLBnN 59fL4ZmwZ/t0PZ7K7aM4oFw= X-Google-Smtp-Source: AK7set8eRL0k7S8LcHULqfgcqv6OGdwfePVFqJDeupRL6PRxqJurIR9Hkhfm1u8dEZuN4JKcMkjwMg== X-Received: by 2002:a17:90a:13:b0:230:acb2:e3e8 with SMTP id 19-20020a17090a001300b00230acb2e3e8mr3946816pja.23.1677908226244; Fri, 03 Mar 2023 21:37:06 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id g10-20020a17090adb0a00b00233e860f69esm4210206pjv.56.2023.03.03.21.37.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 21:37:05 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257250 Archived-At: On 2/23/2023 12:43 PM, Jim Porter wrote: > Ah, good point. Instead of '(pcomplete-match "\\`--.*=" 0)', I think we > want to handle all args starting with "--", but not matching "^--\\([^= > \t\n\f]*\\)\\'". The goal is to call 'pcomplete-here*' exactly once per > option. > > I did this a slightly different way in the updated patch by moving all > the "--" cases into a single place (likewise with the "-" options). I > think this is easier to follow than before, and makes it more obvious > that we're calling 'pcomplete-here*' the right number of times. Any other thoughts before I merge this patch?