From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Drew Adams <drew.adams@oracle.com>
Newsgroups: gmane.emacs.bugs
Subject: bug#16677: 24.3.50; Wrong type argument: char-or-string-p, 67108923
Date: Fri, 7 Feb 2014 09:02:43 -0800 (PST)
Message-ID: <6576d313-9156-4f44-94aa-2c2d24e963f9@default>
References: <<2ba9d857-f8b1-4f0b-8640-41229d998838@default>>
	<<CAAeL0STsVYYLN+AVaGkA-NAcV5WKyHevGrcdMjBntVWC5Oy=Eg@mail.gmail.com>>
	<<83ppmzxseg.fsf@gnu.org>>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Trace: ger.gmane.org 1391792600 6261 80.91.229.3 (7 Feb 2014 17:03:20 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 7 Feb 2014 17:03:20 +0000 (UTC)
Cc: 16677@debbugs.gnu.org
To: Eli Zaretskii <eliz@gnu.org>, Juanma Barranquero <lekktu@gmail.com>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 07 18:03:26 2014
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1WBopq-0007as-Jj
	for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Feb 2014 18:03:26 +0100
Original-Received: from localhost ([::1]:42729 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1WBopq-000720-8J
	for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Feb 2014 12:03:26 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39307)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WBope-0006vK-5Q
	for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2014 12:03:22 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WBopV-0001di-KR
	for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2014 12:03:14 -0500
Original-Received: from debbugs.gnu.org ([140.186.70.43]:41293)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WBopV-0001dd-HS
	for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2014 12:03:05 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WBopU-0007v9-Kg
	for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2014 12:03:05 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Drew Adams <drew.adams@oracle.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Fri, 07 Feb 2014 17:03:04 +0000
Resent-Message-ID: <handler.16677.B16677.139179257230416@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 16677
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
Original-Received: via spool by 16677-submit@debbugs.gnu.org id=B16677.139179257230416
	(code B ref 16677); Fri, 07 Feb 2014 17:03:04 +0000
Original-Received: (at 16677) by debbugs.gnu.org; 7 Feb 2014 17:02:52 +0000
Original-Received: from localhost ([127.0.0.1]:55311 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1WBopH-0007uV-6j
	for submit@debbugs.gnu.org; Fri, 07 Feb 2014 12:02:51 -0500
Original-Received: from userp1040.oracle.com ([156.151.31.81]:49273)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <drew.adams@oracle.com>) id 1WBopE-0007uL-48
	for 16677@debbugs.gnu.org; Fri, 07 Feb 2014 12:02:49 -0500
Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238])
	by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with
	ESMTP id s17H2jdM031144
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Fri, 7 Feb 2014 17:02:46 GMT
Original-Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86])
	by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id
	s17H2iRs012163
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 7 Feb 2014 17:02:45 GMT
Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18])
	by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id
	s17H2igj015602; Fri, 7 Feb 2014 17:02:44 GMT
In-Reply-To: <<83ppmzxseg.fsf@gnu.org>>
X-Priority: 3
X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8  (707110) [OL
	12.0.6680.5000 (x86)]
X-Source-IP: acsinet22.oracle.com [141.146.126.238]
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 140.186.70.43
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
	the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.bugs:84828
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/84828>

> > +    (unless (characterp char)
> > +      (user-error "%s is not a character"
> > +                  (help-key-description (vector char) nil)))
>=20
> "%s is not a valid character" is a better error message, IMO.

Yes; thanks to both of you for such a fix.