From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Merten Newsgroups: gmane.emacs.devel Subject: Re: Re-including rst.el into Emacs repository Date: Tue, 29 May 2012 22:30:00 +0200 Message-ID: <6563.1338323400@theowa.merten-home.homelinux.org> References: <30996.1335792548@eskebo.merten-home.homelinux.org> <7259.1336421206@theowa.merten-home.homelinux.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1338323430 12593 80.91.229.3 (29 May 2012 20:30:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 May 2012 20:30:30 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 29 22:30:29 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SZT3l-0000Ut-Ff for ged-emacs-devel@m.gmane.org; Tue, 29 May 2012 22:30:29 +0200 Original-Received: from localhost ([::1]:36584 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZT3l-000686-32 for ged-emacs-devel@m.gmane.org; Tue, 29 May 2012 16:30:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZT3h-00067f-Dv for emacs-devel@gnu.org; Tue, 29 May 2012 16:30:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZT3a-00008x-D8 for emacs-devel@gnu.org; Tue, 29 May 2012 16:30:24 -0400 Original-Received: from moutng.kundenserver.de ([212.227.17.8]:51716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZT3a-00007m-3D for emacs-devel@gnu.org; Tue, 29 May 2012 16:30:18 -0400 Original-Received: from theowa.merten-home.homelinux.org (ip-109-84-0-11.web.vodafone.de [109.84.0.11]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0MRQIm-1SSuXU3X8C-00Ss8w; Tue, 29 May 2012 22:30:13 +0200 Original-Received: by theowa.merten-home.homelinux.org (Postfix, from userid 1000) id EEA95401D4; Tue, 29 May 2012 22:30:00 +0200 (CEST) Original-Received: from theowa.merten-home.homelinux.org (localhost [127.0.0.1]) by theowa.merten-home.homelinux.org (Postfix) with ESMTP id EC5B07A009 for ; Tue, 29 May 2012 22:30:00 +0200 (CEST) In-reply-to: Comments: In-reply-to Stefan Monnier message dated "Mon, 07 May 2012 21:42:04 -0400." X-Mailer: MH-E 8.2; nmh 1.3; GNU Emacs 23.1.1 X-Provags-ID: V02:K0:3fy+iykx8ME5O8IV3mRISmXPbSHfVXeEnOoL/KYe6CN pbRsnVxVuvsWw2TQQmdWK6J11cpENnwsgEuCZB7odC+cb+KJgN 64q0pOe809/nRqIcqGVWzxsIBIhe1puv8l1AxCDCEEzVBcMcf9 VSmwFA7hiReFqkB71xDDmVyt47Q04lzFUFnxjim8J2G3RmAsT6 22YpfG+yCjUE0hGOFpyW2TanaTBPLCeu4NUxziOZqFcmBhmoTG Vgv8o/DtFigek5saxqChjgzXBzHDsKI7KNjEkxu4K8/fUAWbYf WjffzEvZP2v0RKyRyyLEL19GQAlgkBGdJLDPa3DJ/rh7XLrQvE xs0waHHht4P1YcT4P9zBmYhojLgRpzElge1sTmJqoEfDEpSqE7 Cfop5p3G/Uj0jvPdh+jiRY6h5IdrGF7T8s= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.227.17.8 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:150683 Archived-At: --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Hi StefanMo and all! 3 weeks (21 days) ago Stefan Monnier wrote: >> Just committed. I'd appreciate a thorough review. >=20 > See some comments below (the patch is much too large to review in > detail, and I trust you on the meat of the code, concentrating on > nitpicks instead). Thanks for the nitpicks. I implemented nearly all of your suggestions. >>> But please try to keep some reference to the >>> "common ancestor" and "tip" of the branch being merged (that's done >>> automatically as Bzr metadata when it's a normal merge, but I suspect in >>> your case the branch from which you merge is external). >> I did this in the log message including a reference to the Docutils >> subversion revision. >=20 > Thanks, tho you only put the tip of the merge, and forgot its base. I don't understand. What do you mean by the base of the merge? > If you check the ChangeLog guidelines, they recommend the use of the > present tense: describe what the change does. [...] > Additionally, try and use the active > form Done. Please note that I'm German. We *love* the passive form over here ;-) . >> + (let (rst-re-alist) >> + (dolist (re rst-re-alist-def) >> + (setq rst-re-alist >> + (nconc rst-re-alist >> + (list (list (car re) (apply 'rst-re (cdr re))))))) >> + rst-re-alist) > > Not that it matters, but this is an O(N^2) algorithm which you can turn > into a O(N) algorithm by using (push (list (car re) (apply 'rst-re (cdr > re)))) rst-re-alist) and a final nreverse. > That's a classic "Elisp code pattern". That doesn't work (unit tests fail). This whole thing is not very nice because of the cyclic dependency between defining the constant and `rst-re' - which also annoys the byte compiler... This will vanish anyway when `sregex` or `rx` is used at some point. Gr=FC=DFe Stefan --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQCVAwUBT8UxxQnTZgC3zSk5AQKo8gP/c/LoDH7OLZ+9Fui1+rfGMh9vLn8iKw52 fg1EHzONVpW8PgMp634cXQaL8T9a2QONVmafvLxqZBBWfK7nlwNoyViCWlc7e8Ej 9x2RBDDhDbaG4oUNyt6G2qrLhUx/7pQs8GHUL+z5NjHjropcvNrbGYLHMGlddzb+ PWpcK82L100= =Yfyo -----END PGP SIGNATURE----- --=-=-=--