From: Stefan Merten <smerten@oekonux.de>
To: emacs-devel@gnu.org
Subject: Re: Re-including rst.el into Emacs repository
Date: Tue, 29 May 2012 22:30:00 +0200 [thread overview]
Message-ID: <6563.1338323400@theowa.merten-home.homelinux.org> (raw)
In-Reply-To: <jwvhavry0kt.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1873 bytes --]
Hi StefanMo and all!
3 weeks (21 days) ago Stefan Monnier wrote:
>> Just committed. I'd appreciate a thorough review.
>
> See some comments below (the patch is much too large to review in
> detail, and I trust you on the meat of the code, concentrating on
> nitpicks instead).
Thanks for the nitpicks. I implemented nearly all of your suggestions.
>>> But please try to keep some reference to the
>>> "common ancestor" and "tip" of the branch being merged (that's done
>>> automatically as Bzr metadata when it's a normal merge, but I suspect in
>>> your case the branch from which you merge is external).
>> I did this in the log message including a reference to the Docutils
>> subversion revision.
>
> Thanks, tho you only put the tip of the merge, and forgot its base.
I don't understand. What do you mean by the base of the merge?
> If you check the ChangeLog guidelines, they recommend the use of the
> present tense: describe what the change does.
[...]
> Additionally, try and use the active
> form
Done. Please note that I'm German. We *love* the passive form over
here ;-) .
>> + (let (rst-re-alist)
>> + (dolist (re rst-re-alist-def)
>> + (setq rst-re-alist
>> + (nconc rst-re-alist
>> + (list (list (car re) (apply 'rst-re (cdr re)))))))
>> + rst-re-alist)
>
> Not that it matters, but this is an O(N^2) algorithm which you can turn
> into a O(N) algorithm by using (push (list (car re) (apply 'rst-re (cdr
> re)))) rst-re-alist) and a final nreverse.
> That's a classic "Elisp code pattern".
That doesn't work (unit tests fail). This whole thing is not very nice
because of the cyclic dependency between defining the constant and
`rst-re' - which also annoys the byte compiler... This will vanish
anyway when `sregex` or `rx` is used at some point.
Grüße
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 307 bytes --]
next prev parent reply other threads:[~2012-05-29 20:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 13:29 Re-including rst.el into Emacs repository Stefan Merten
2012-04-30 13:37 ` Deniz Dogan
2012-04-30 15:02 ` Stefan Monnier
2012-05-07 20:06 ` Stefan Merten
2012-05-08 1:42 ` Stefan Monnier
2012-05-29 20:30 ` Stefan Merten [this message]
2012-05-30 2:36 ` Stefan Monnier
2012-05-30 19:15 ` Stefan Merten
2012-05-31 18:15 ` Glenn Morris
2012-05-31 19:22 ` Leo
2012-06-02 12:16 ` Wrong direction of C-M-a/e in rst-mode (was: Re: Re-including rst.el into Emacs repository) Stefan Merten
2012-06-03 2:08 ` Wrong direction of C-M-a/e in rst-mode Leo
2012-06-02 10:05 ` Using cl in rst.el and elsewhere (was: Re: Re-including rst.el into Emacs repository) Stefan Merten
2012-06-02 19:15 ` Using cl in rst.el and elsewhere Glenn Morris
2012-06-03 3:23 ` Stefan Monnier
2012-06-03 3:57 ` Leo
2012-06-02 19:56 ` Stefan Monnier
2012-06-03 2:21 ` Leo
2012-06-03 3:12 ` Miles Bader
2012-06-03 13:41 ` Stefan Merten
2012-06-03 13:47 ` Pascal J. Bourguignon
2012-06-03 15:15 ` Stefan Monnier
2012-06-03 18:30 ` Richard Stallman
2012-06-04 13:23 ` Stefan Monnier
2012-06-05 19:38 ` Stefan Merten
2012-05-02 16:59 ` Re-including rst.el into Emacs repository Barry Warsaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6563.1338323400@theowa.merten-home.homelinux.org \
--to=smerten@oekonux.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.