From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Date: Sat, 29 Oct 2022 08:24:53 -0700 Message-ID: <6549.1667057093@alto> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17839"; mail-complaints-to="usenet@ciao.gmane.io" To: Eli Zaretskii , 58721@debbugs.gnu.org, Gustavo Barros Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 29 17:26:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oonjB-0004Wo-MT for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Oct 2022 17:26:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooniq-0005ti-PX; Sat, 29 Oct 2022 11:26:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oonil-0005qz-HK for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 11:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oonik-000835-KW for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 11:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oonik-00042L-7C for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 11:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Oct 2022 15:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58721 X-GNU-PR-Package: emacs Original-Received: via spool by 58721-submit@debbugs.gnu.org id=B58721.166705710315444 (code B ref 58721); Sat, 29 Oct 2022 15:26:02 +0000 Original-Received: (at 58721) by debbugs.gnu.org; 29 Oct 2022 15:25:03 +0000 Original-Received: from localhost ([127.0.0.1]:36363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oonhn-000411-DZ for submit@debbugs.gnu.org; Sat, 29 Oct 2022 11:25:03 -0400 Original-Received: from shell1.rawbw.com ([198.144.192.42]:19543 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oonhk-00040V-3R for 58721@debbugs.gnu.org; Sat, 29 Oct 2022 11:25:02 -0400 Original-Received: from alto (135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 29TFOrwh024697 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 29 Oct 2022 08:24:58 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged) claimed to be alto In-Reply-To: My message of "Fri, 28 Oct 2022 22:25:16 -0700." <189664.1667021116@alto> X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.0.50 Content-ID: <6548.1667057093.1@alto> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246540 Archived-At: Mike Kupfer wrote: > * copy-directory("/tmp/emacs-git" "/home/kupfer/.local/share/Trash/files= /emacs-gitH0l..." t nil) > rename-file("/tmp/emacs-git" "/home/kupfer/.local/share/Trash/files/em= acs-gitH0l..." t) > move-file-to-trash("/tmp/emacs-git") > delete-directory("/tmp/emacs-git" always t) > dired-delete-file("/tmp/emacs-git" top t) > dired-internal-do-deletions((("/tmp/emacs-git" . #>)) nil t) > dired-do-flagged-delete() > funcall-interactively(dired-do-flagged-delete) > call-interactively(dired-do-flagged-delete nil nil) > command-execute(dired-do-flagged-delete) [...] > Hrm. Shouldn't the call to copy-directory look like > = > copy-directory("/tmp/emacs-git" "/home/kupfer/.local/share/Trash/files= /emacs-gitH0l..." t nil t) > ^^^ I played with this some more this morning, this time on Emacs 29. It looks like rename-file should have called copy-directory as copy-directory("/tmp/emacs-git" "/home/kupfer/.local/share/Trash/files/emacs-gitH0lx1e/" t nil t) That is, 2 changes from current behavior are needed: append a "/" to the target name, and specify copy-contents as t. The test case that I used to emulate the current behavior is 1. mkdir a; touch a/b 2. mkdir /tmp/newa (This assumes that /tmp is a different filesystem than the filesystem where "a" was created.) 3. M-: (copy-directory "a" "/tmp/newa" t nil) RET That gives the already-exists error. With (copy-directory "a" "/tmp/newa/" t nil), I get /tmp/newa/a/b, which isn't what's wanted for the Trash directory. With (copy-directory "a" "/tmp/newa/" t nil t), I get /tmp/newa/b, which is what's desired. mike