all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: CHENG Gao <chenggao@gmail.com>
Subject: Patch to lisp/bs.el
Date: Sat, 20 Nov 2004 00:13:39 +0800	[thread overview]
Message-ID: <6541lsuk.fsf@gmail.com> (raw)

Reading Coding Conventions, I found it's not desirable to use
next-line/previous-line. Searching Emacs files generate some files that
dont follow this.

Below is patch to lisp/bs.el with next-line/previous replaced with
forward-line.

--- bs.el.orig	2004-11-19 23:55:04.000000000 +0800
+++ bs.el	2004-11-19 23:56:08.000000000 +0800
@@ -1006,7 +1006,7 @@
   "Move cursor vertically up one line.
 If on top of buffer list go to last line."
   (interactive "p")
-  (previous-line 1)
+  (forward-line -1)
   (if (<= (count-lines 1 (point)) (1- bs-header-lines-length))
       (progn
 	(goto-char (point-max))
@@ -1027,7 +1027,7 @@
   (let ((last (line-end-position)))
     (if (eq last (point-max))
 	(goto-line (1+ bs-header-lines-length))
-      (next-line 1))))
+      (forward-line 1))))
 
 (defun bs-visits-non-file (buffer)
   "Return t or nil whether BUFFER visits no file.

-- 
德不孤,必有邻
         -- 《论语-里仁》

             reply	other threads:[~2004-11-19 16:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-19 16:13 CHENG Gao [this message]
2004-11-19 16:41 ` Patch to lisp/bs.el Andreas Schwab
2004-11-19 17:11   ` CHENG Gao
2004-11-19 18:36     ` Thien-Thi Nguyen
2004-11-21  1:10 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6541lsuk.fsf@gmail.com \
    --to=chenggao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.