From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/widen-less a4ba846: Replace prog-widen with consolidating widen calls Date: Wed, 20 Dec 2017 02:07:07 +0200 Message-ID: <651cc325-d8ec-9d8e-9cfc-eced5de1d8fe@yandex.ru> References: <8e5adcd7-e085-e8d2-085f-398c660cd34d@yandex.ru> <578E6C44-1D80-42BF-91A2-94C44355A1D8@sap.com> <1113b16e-8fe5-b43b-160c-4d4df9ed960e@yandex.ru> <0BBE54AA-6DAC-44B9-BFF1-7701013F8DFB@sap.com> <98B32A7F-6D39-4341-B7BA-73714C55AEF1@sap.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1513728363 6466 195.159.176.226 (20 Dec 2017 00:06:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 20 Dec 2017 00:06:03 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Thunderbird/58.0 To: "Wedler, Christoph" , Eli Zaretskii , "monnier@iro.umontreal.ca" , "emacs-devel@gnu.org" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 20 01:05:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRRtU-00010b-JP for ged-emacs-devel@m.gmane.org; Wed, 20 Dec 2017 01:05:56 +0100 Original-Received: from localhost ([::1]:46061 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRRvR-00030c-Bx for ged-emacs-devel@m.gmane.org; Tue, 19 Dec 2017 19:07:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRRun-0002zo-7s for emacs-devel@gnu.org; Tue, 19 Dec 2017 19:07:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRRuj-0004D8-Kr for emacs-devel@gnu.org; Tue, 19 Dec 2017 19:07:17 -0500 Original-Received: from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]:44579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRRuj-0004BG-B9; Tue, 19 Dec 2017 19:07:13 -0500 Original-Received: by mail-wr0-x236.google.com with SMTP id l41so8623957wre.11; Tue, 19 Dec 2017 16:07:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=a8B4Hnf1H6S0qjXJbcHCJIvTA1VCmMTxHaS2mnwExyk=; b=NKo7RZX1L2EpHzZWx6bJ/onP7cpc9hhfK02oPxeQkN7hxMne6OfFuRoOW89g3Qd3+M CSY5W99+/lc6ERocYaSiAQQ7p3VnZBpBYhRkTZntg0E0TQDwe7TpEJV8M93oyZVMHl9D RM8Bn867s7RB9gSYJaXKzngoPYncH30czSm9m4vMEcW3UwB1OI1r7sNqx+3CJ90gPOub 0XevCgkMnDE3V4VTCh6tRBD2cqK3t7DrJREfr5orK8W8n6zGRW78/iMowRHd5Q+2E0AT E85oUVNBGDQ2uXz7WBDnStDd7ONqjn6FY2rLNeLHg8xReH6Ha1mlgwu9x4U/NNJxxd2L j/Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=a8B4Hnf1H6S0qjXJbcHCJIvTA1VCmMTxHaS2mnwExyk=; b=ldbsbZr7uzzUdEREi1478px/kWMsBHKJUpkJjVRaWrqtbIYrZqnrh14eB5JhPB1oCl slkH8N8fhlo/kF0azDNqnmn1N9ZZel6AS5Y+772GFLFqaULqCZnlQ/BTJBcDsshG9vZ7 y/xtSiDU7I/4TbwZjpZWOY8tVo156FmAvcvvjPpdIdaY3B3qy9FKBKUXjPKCyfuPTaEE VaNLqWebHW5ItY6Z+Fxso1pm3ndr7aQ7JMD/jByUiY570QtTj4iLZDGLefX5hUkMd+DF BraX33I6OiNaoAqiwArV5No7Lzg46gMkWv56TfmqXAewo16GHv5XqzE3734I5c2URefO CdWw== X-Gm-Message-State: AKGB3mLH5nsp5MJNK7jjoOXWkBmBuodjrl9FCSdkKpeSDsjfyScYiqEx ordgcigBOwnjIZDMag5DSVT8b7S4 X-Google-Smtp-Source: ACJfBotvMGX+9a7qpftD3FIuDelrhkwcXN2NWwH3EzVsz/8Ks5Yc6YpoGlYZPis/UI40CYiZeJcNwA== X-Received: by 10.223.202.1 with SMTP id o1mr6819837wrh.233.1513728431645; Tue, 19 Dec 2017 16:07:11 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id 4sm7688984wrh.70.2017.12.19.16.07.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Dec 2017 16:07:10 -0800 (PST) In-Reply-To: <98B32A7F-6D39-4341-B7BA-73714C55AEF1@sap.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221263 Archived-At: On 12/19/17 1:27 PM, Wedler, Christoph wrote: > I do not see why it should now behave correctly > (the “called” funcall is outside “save-restriction – widen”) Ouch. Thanks for that, should be fixed now. I only tested this with indent-region, in fact. And emacs-lisp-mode has a dedicated indent-region-function. >> I don't get syntax highlighting there, but indentation works fine. I >> just needed to know which part of the example file to test. > > Hm, with src/emacs –q & and M-x load-file /antlr-mode.elc > I get the result of the attached screenshot area. Hmm, yes. This way it works. But not with my full configuration (just omitting -q from this scenario). Not sure what can be going wrong there; maybe incompatibility with some minor modes. All I can say is that font-lock-keywords don't end up having the entry for the Python keywords in the latter case. Nor the entries for the constants or built-in functions, for that matter. Anyway, that's not a big problem for me. No immediate plans to edit Antlr grammars. > (region still active) TAB -> works (i.e., no deletion of the spaces) > (region no longer active) TAB -> deletes the 2 spaces (wrong as before) Right, I only tested the first case originally.