From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#41524: 26.3; Request for 'x' for 'execute' in dired menu Date: Mon, 24 Aug 2020 08:09:04 -0700 (PDT) Message-ID: <64f184cb-21ed-4181-9e61-9d08041c8740@default> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34696"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jan , 41524@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 24 17:10:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAE6q-0008qx-OE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 17:10:08 +0200 Original-Received: from localhost ([::1]:54250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAE6p-0004Sp-QT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 11:10:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAE6k-0004Sf-5o for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 11:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47351) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAE6j-0001Th-RX for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 11:10:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAE6j-0004sB-MS for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 11:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Aug 2020 15:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41524-submit@debbugs.gnu.org id=B41524.159828175818670 (code B ref 41524); Mon, 24 Aug 2020 15:10:01 +0000 Original-Received: (at 41524) by debbugs.gnu.org; 24 Aug 2020 15:09:18 +0000 Original-Received: from localhost ([127.0.0.1]:58897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAE61-0004r3-VJ for submit@debbugs.gnu.org; Mon, 24 Aug 2020 11:09:18 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:42046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAE61-0004qr-11 for 41524@debbugs.gnu.org; Mon, 24 Aug 2020 11:09:17 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07OF9Bjh151031; Mon, 24 Aug 2020 15:09:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=zYMMlQhEzIJ8ySSlBGbBUH542whKUfK9ayp9MSRSQSs=; b=gGkqtnXAsGI8l7gHZpTB4WXmOaYmv1vcIj4VSbIQ3Wqyp39Pe3oaehaMVc2tJYkQl5Kv lunH5VQ6Ug2RiW5FWOozn5LdQtLpnDLyccvvHWX6JeZmlNpmccqnUEMYbRnbSCbJlYlS zSosb8lLS8dU4WopWGM7+D8uAkautrhWYGOXs+zLczyCD2KTQZLRVZGNX/75UKdyd3mT +VH2d7+bKneFyz23XWeRZAWXE/IXQVEFxbmA5TOo6jGj6ric1brKTr/F7w7TVpTakJNc mP77r8Pag80HBWPbkcVkeO7WssmQyX/gTJkZz8QPTng5PHXqUm7DkxCkWG9q6GTzKCLQ OQ== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 333w6tknkh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 24 Aug 2020 15:09:11 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07OF0ZCZ036132; Mon, 24 Aug 2020 15:09:06 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 333rtwmw9n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Aug 2020 15:09:06 +0000 Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07OF95nm008539; Mon, 24 Aug 2020 15:09:05 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9722 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxlogscore=885 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008240121 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9722 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 impostorscore=0 mlxlogscore=879 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1011 mlxscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008240122 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186167 Archived-At: > > Yes, `x' is not in a menu-bar menu. It should be. > > > > If you use Dired+, it is. There, you have submenu > > `Delete', with menu items `Delete Marked (not Flagged)' > > and `Delete Flagged'. The former has key `D', and the > > latter has key `x'. > > > > (In Dired+, menu-bar menu `Operate' is named `Multiple', > > so submenu `Delete' is `Multiple > Delete', not `Operate > >> Delete'.) >=20 > How does the attached patch look? >=20 > (I had a look at Dired+ and lifted some help strings from there. > Thanks Drew.) Thanks for looking into this. I don't think this belongs on menu `Mark', however. It belongs on menu `Operate', as it operates on the (typically) multiple files that are marked (or flagged). Menu `Mark' is for marking files, not for acting on marked files. IMO, it would not be good to start mixing up marking with acting on marked files, on the same menu. That would set a bad precedent. Once things get set in an Emacs menu, it seems to take a major earthquake to later change them, so it's better to try to keep things clear from the outset. [When I said in my previous post, that Dired+ has a `Delete' submenu, I should have mentioned that it is on menu `Multiple' (which corresponds to vanilla menu `Operate'), not on menu `Marks' (which corresponds to vanilla menu `Mark'.]