From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64055: Implementation of modifying VC change comments for Git Date: Mon, 21 Oct 2024 00:55:12 +0100 Message-ID: <64eb22e7-4cec-42c3-8dcc-d838c72860f8@yandex.ru> References: <874j59wym3.fsf@melete.silentflame.com> <868qukl73k.fsf@gnu.org> <87bjzfuzaq.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33692"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Morgan.J.Smith@outlook.com, 64055@debbugs.gnu.org To: Sean Whitton , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 21 01:55:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2fm6-0008ZM-Jr for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Oct 2024 01:55:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2fls-0007jg-Jd; Sun, 20 Oct 2024 19:55:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2flp-0007jT-Ef for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 19:55:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2flp-0006oH-6H for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 19:55:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=uEDLqacim3t+Cw8zY3sZx30OuNyI+UB7xdQGkfBJppk=; b=oqMg8LL+WUEQ58AZ7eA0bAEihltfKPubBBRv9njReq6QAw0R9C180IRZjiTbULjiDXuZyDoe/WMFA1i1UIWXxweFSzuejsGdZRrkzQz8L7xfCGbb6TCZWD01QWt/1UN4BA69/zQ5wF/2aSXN7eXrJDa1Du/F6K5vaVYdrMqXhRhsKfHp7dHM4jI1xHj8ZKEkDtDISqh/1PSR7hfvLUGrKIe4BCS9odWo8oC0Uvul2Al6luTuweiOg7TV4dvB27dWvGvjhbtgmK6sTz4D4H3EE5LSp2keF8APBW0LJ/4rzotHxTIOzP2/hJ5bAKPhb+l7l5tjgS/Bz4fBeLGgkfXLFw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2fmE-0005Lh-IB for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 19:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2024 23:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.172946855020527 (code B ref 64055); Sun, 20 Oct 2024 23:56:02 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 20 Oct 2024 23:55:50 +0000 Original-Received: from localhost ([127.0.0.1]:49342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2fm1-0005L0-JL for submit@debbugs.gnu.org; Sun, 20 Oct 2024 19:55:49 -0400 Original-Received: from forward502a.mail.yandex.net ([178.154.239.82]:56534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2fly-0005Kj-F5 for 64055@debbugs.gnu.org; Sun, 20 Oct 2024 19:55:48 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-91.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-91.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:1eaf:0:640:53c2:0]) by forward502a.mail.yandex.net (Yandex) with ESMTPS id 9360660F94; Mon, 21 Oct 2024 02:55:18 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-91.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id EtaNc7WpCuQ0-OPETXeX1; Mon, 21 Oct 2024 02:55:17 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1729468517; bh=uEDLqacim3t+Cw8zY3sZx30OuNyI+UB7xdQGkfBJppk=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=sunJMFgUqzJD+kU4ZGnYc8jpjkMA7Jq+IcKtawt3R3ZcOKi1wm8dnPPwqWk52U5Er Hw8vqd/7uEfVaS/S3zbl1JPwjoOvtruAmw79m9FLw++fsB6fL1lqlzChVHDqf/a8y4 LuuBFiS6Izkf5HKkr+CCEf/EdwT3EWuX/Ya0wI9E= Authentication-Results: mail-nwsmtp-smtp-production-main-91.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfauth.phl.internal (Postfix) with ESMTP id A81C8120007A; Sun, 20 Oct 2024 19:55:14 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Sun, 20 Oct 2024 19:55:14 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehkedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnegovehorghsthgrlhdqrfegfedtqdeigeculdeftddtmdenucfj ughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhmihhtrh ihucfiuhhtohhvuceoughguhhtohhvseihrghnuggvgidrrhhuqeenucggtffrrghtthgv rhhnpeehuddtieetuedvvedvjeejtdefkeefudeuvefgvdefleduudejhedvgfekieevge enucffohhmrghinheprhgvphholhhoghihrdhorhhgnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepughguhhtohhvodhmvghsmhhtphgruhhthh hpvghrshhonhgrlhhithihqddufeeffeelleehhedvqddvleegjeejjeejiedqughguhht ohhvpeephigrnhguvgigrdhruhesfhgrshhtmhgrihhlrdgtohhmpdhnsggprhgtphhtth hopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsphifhhhithhtohhnsehs phifhhhithhtohhnrd X-ME-Proxy: Feedback-ID: ib1d9465d:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Oct 2024 19:55:13 -0400 (EDT) Content-Language: en-US In-Reply-To: <87bjzfuzaq.fsf@melete.silentflame.com> X-Yandex-Filter: 1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294010 Archived-At: On 20/10/2024 08:19, Sean Whitton wrote: >> When I do the above, I get an error message: >> >> vc-do-command: Failed (status 128): git --no-pager commit --only >> --allow-empty -F c:/Users/EliZ/AppData/Local/Temp/git-msgWaNflu >> >> and the*vc* buffer says: >> >> fatal: No paths with --include/--only does not make sense. >> >> It's possible my Git is very old, but shouldn't this command work with >> old versions as well? > I've looked into it and what's required is Git 2.11.1 from early 2017. > > I think we can support older by stashing and unstashing. So please try > the attached patch, which does that. Just to note, looking at https://repology.org/project/git/versions, support for Git 2.11 seems ubiquitous enough, even the next-to-last Trisquel release (based on Ubuntu 2020) has 2.25. And the very newest versions are available in Git for Windows. And since this is an optional feature, we might as well limit ourselves to certain newer Git versions.