From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display box cursor under image with margins Date: Sat, 25 Apr 2020 09:19:23 -0400 Message-ID: <649812fa-75a6-ef86-6933-723ef2e3389f@gmail.com> References: <83imhwk7sr.fsf@gnu.org> <835zdn97k8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="122927"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 25 15:20:23 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSKjH-000Vti-8R for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Apr 2020 15:20:23 +0200 Original-Received: from localhost ([::1]:36948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSKjG-00084X-7t for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Apr 2020 09:20:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55216) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSKiN-0006p2-Ms for emacs-devel@gnu.org; Sat, 25 Apr 2020 09:19:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSKiM-0001AA-CR for emacs-devel@gnu.org; Sat, 25 Apr 2020 09:19:27 -0400 Original-Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]:37406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSKiL-00019o-SO for emacs-devel@gnu.org; Sat, 25 Apr 2020 09:19:26 -0400 Original-Received: by mail-qk1-x741.google.com with SMTP id s63so13199273qke.4 for ; Sat, 25 Apr 2020 06:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=s26/JGJOpo+2sNEk+lvAV35vqa4iJr6vYwY1nlg4tzA=; b=hsP9zZ8BuArIiywooG3Av3iIQsDDzo0np9jvqF8OFzvlK33R97jrwRfwxGYWqjB5Zx uf8dQ+tROD5Z2N8CLzfSS0hJ7ZQPl8BUButoKmCNAdiLKsjJbW3y0tSO5t92nDb7S0p7 R3BlRW4URHN5PpYtKpe8DUX0i7HLIuoezvcOta9/cWw784cIwhFckqvo93ln1a+G/cFp 2DH1G7OWGPnuNTOYW7CssIksJ660pMQxXh9FaB/MrMAc2BxsIB+juKSDEaBVcZpn5Haq vP+21uX/yf5jbrRDy5nrFeEbT2+vcm4h9U/DSZbkVCc5d9ocffHt3JkhAwZEZk9xAWHe aIbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s26/JGJOpo+2sNEk+lvAV35vqa4iJr6vYwY1nlg4tzA=; b=dEG5A6ipgD5v3f+PpHqChoOpt/y5I8Fqd1SjUrYrjmJ29y21QIzL6YSv3BuMVmHIRg PwIt5ghptnBV3hhYpSzh0DxVfcnzhUjWkJ3DFOzkaqjeHefH4FkW08D2ySF5k16givbL /TFWTiIITn2PXbmf1JtIvd1JObFHnA8f+zyPopY0T8ihOk61WBFA0uYfTXsC9Plcb65C 19ECGXdmhv6f5/dUNb8o7SYghTSTvtixl2NMbXn66hc4L98ESTKB9RAYqzbZfQtN2Hl2 obylg8bFsYAfn9WceZ2V8bFb9j0vsb2AlHZNaGzO4Q+Mio6DSPKoDNk2AyIPmZH7WFpN Rglw== X-Gm-Message-State: AGi0PubLCFitAxrVOw8v8YOB9PNtjf8AHfxnKaMOJp7fOG36o7PoLzke aIQPVcKnHSh/EKpPi9ssHhJRUXf2QH8= X-Google-Smtp-Source: APiQypIIg4/XuFTTIx8sWzDPSL9DHjw0o24DZ/VTF6VAOwro7FDcIEhMt7lGoquQ/PVDwp0erJ9jGw== X-Received: by 2002:a05:620a:88f:: with SMTP id b15mr13264415qka.118.1587820764352; Sat, 25 Apr 2020 06:19:24 -0700 (PDT) Original-Received: from ?IPv6:2601:184:4180:66e7:54d6:bfeb:aa49:9d3b? ([2601:184:4180:66e7:54d6:bfeb:aa49:9d3b]) by smtp.googlemail.com with ESMTPSA id a22sm5654947qko.81.2020.04.25.06.19.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Apr 2020 06:19:23 -0700 (PDT) In-Reply-To: <835zdn97k8.fsf@gnu.org> Content-Language: en-GB Received-SPF: pass client-ip=2607:f8b0:4864:20::741; envelope-from=cpitclaudel@gmail.com; helo=mail-qk1-x741.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2607:f8b0:4864:20::741 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247777 Archived-At: On 25/04/2020 06.35, Eli Zaretskii wrote: >> From: Evgeny Zajcev >> Date: Sat, 18 Apr 2020 21:05:16 +0300 >> Cc: emacs-devel >> >> > Here is the patch to fix issue making cursor hollow under non-mask image, but containing margins. >> This >> > patch keeps box cursor to be box in case image has margins. >> >> Could you please give an example of such an image and what the results >> look like, before and after the patch? It's hard to understand the >> details of this otherwise. >> >> Here is first screenshot how hollow cursor looks on image with margin - >> http://lgarc.narod.ru/pics/emacs-hollow-cursor.png >> >> And here is how it looks with patch applied - http://lgarc.narod.ru/pics/emacs-box-cursor.png >> >> Without patch, look of the cursor won't change, it will remain being hollow > > Thanks. Frankly, I'm not sure the change is for the better. > > Does anyone else have an opinion? I'm not sure I understood the patch fully; it seems to be about displaying two lines instead of a box? If so, I think I prefer the box (but generally speaking, respecting the cursor shape would be ideal (using a bar when the cursor is a bar, and replacing the background of the image when the cursor is a box)