From: Chetan Pandya <pandyacus@sbcglobal.net>
To: Juanma Barranquero <lekktu@gmail.com>,
Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: error in server-running-p on M$
Date: Tue, 9 Dec 2008 23:05:45 -0800 (PST) [thread overview]
Message-ID: <649677.20897.qm@web83208.mail.mud.yahoo.com> (raw)
In-Reply-To: <jwvbpvlw0km.fsf-monnier+emacs@gnu.org>
I haven't seen earlier messages, but I am glad something is being done here.
--- On Tue, 12/9/08, Stefan Monnier <monnier@IRO.UMontreal.CA> wrote:
> Looks good, tho see comment below.
>
> > + (and (process-contact proc :server)
> > + (eq (process-status proc) 'closed)
> > + (ignore-errors (delete-file (process-get proc
> :server-file))))
> > (server-log (format "Status changed to %s:
> %s" (process-status
>
> It would be good to keep some comment about the fact that we don't know
> for sure that the file is ours.
It isn't too difficult to check that. Here is a version that checks that the file has the same pid.
(let ((server-file (process-get proc :server-file)))
(with-temp-buffer
(set-buffer-multibyte nil)
(insert-file server-file)
(beginning-of-buffer)
(end-of-line)
(skip-chars-backward "0-9")
(if (eq (read (current-buffer)) (emacs-pid))
(ignore-errors (delete-file server-file)))))
> > + (if (not (server-running-p server-name))
> > + (ignore-errors (delete-file server-file))
> > + (setq server-mode nil) ;; already set by the minor
> mode code
> > + (error "Server %S is already running"
> server-name))
> Finally, for the purpose of server-start, we don't
> necessarily care if
> there is a server named "foo" running on some
> other machine, so maybe in
> the server-use-tcp case, if the IP is not 127.0.0.1,
> server-running-p
> might return a special value like `remote' and
> server-start might treat
> it like "not running" (i.e. it will remove the
> server-file).
It is possible for the IP to be 127.0.0.1 and still the server be running on another system.
Chetan
next prev parent reply other threads:[~2008-12-10 7:05 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 11:44 error in server-running-p on M$ dhruva
2008-11-22 11:58 ` Juanma Barranquero
2008-11-22 12:51 ` Eli Zaretskii
2008-11-22 13:00 ` Juanma Barranquero
2008-11-22 13:20 ` Eli Zaretskii
2008-11-22 13:37 ` Juanma Barranquero
2008-11-22 13:53 ` Eli Zaretskii
2008-11-22 14:13 ` Ulrich Mueller
2008-11-22 14:17 ` Juanma Barranquero
2008-11-22 14:29 ` Ulrich Mueller
2008-11-22 14:36 ` Juanma Barranquero
2008-11-22 15:35 ` Ulrich Mueller
2008-11-22 16:04 ` Juanma Barranquero
2008-11-22 16:52 ` Ulrich Mueller
2008-11-22 21:47 ` Juanma Barranquero
2008-11-23 3:56 ` dhruva
2008-11-23 3:59 ` Juanma Barranquero
2008-11-23 4:01 ` dhruva
2008-11-23 4:03 ` Juanma Barranquero
2008-11-23 4:10 ` dhruva
2008-11-23 4:15 ` Juanma Barranquero
2008-11-23 4:17 ` dhruva
2008-11-23 4:19 ` Juanma Barranquero
2008-11-23 8:14 ` Server protocol (was: Re: error in server-running-p on M$) Ulrich Mueller
2008-11-23 11:33 ` Juanma Barranquero
2008-11-23 16:33 ` dhruva
2008-11-23 17:48 ` Juanma Barranquero
2008-11-23 4:02 ` error in server-running-p on M$ Stefan Monnier
2008-11-23 4:10 ` Juanma Barranquero
2008-11-23 5:21 ` Stefan Monnier
2008-11-23 5:32 ` Juanma Barranquero
2008-11-23 5:57 ` Stefan Monnier
2008-11-23 11:26 ` Juanma Barranquero
2008-11-23 12:46 ` Juanma Barranquero
2008-11-23 13:13 ` Ulrich Mueller
2008-11-24 2:55 ` Stefan Monnier
2008-11-24 14:46 ` Juanma Barranquero
2008-11-24 15:10 ` Ulrich Mueller
2008-11-24 15:16 ` Juanma Barranquero
2008-11-24 15:34 ` Ulrich Mueller
2008-11-24 15:45 ` Juanma Barranquero
2008-12-09 20:46 ` Stefan Monnier
2008-12-10 7:05 ` Chetan Pandya [this message]
2008-12-10 12:59 ` Juanma Barranquero
2008-12-10 18:30 ` Stefan Monnier
2008-12-10 18:47 ` Juanma Barranquero
2008-12-11 2:07 ` Stefan Monnier
2008-12-11 16:30 ` Juanma Barranquero
2008-12-11 18:47 ` Stefan Monnier
2008-12-12 0:40 ` Juanma Barranquero
2008-12-12 4:51 ` Stefan Monnier
2008-12-12 8:19 ` Juanma Barranquero
2008-12-12 18:49 ` Stefan Monnier
2008-12-12 20:20 ` Juanma Barranquero
2008-11-23 3:58 ` Stefan Monnier
2008-11-23 3:59 ` Stefan Monnier
2008-11-23 4:12 ` Juanma Barranquero
2008-11-23 5:19 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=649677.20897.qm@web83208.mail.mud.yahoo.com \
--to=pandyacus@sbcglobal.net \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.