From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#25875: 26.0.50; Hang logging out of MS-Windows Date: Mon, 27 Feb 2017 17:37:36 -0500 Message-ID: <648f03f0-e4d4-c04e-afbf-d8ef8741b15e@cornell.edu> References: <83lgsuqacv.fsf@gnu.org> <83efylq7m4.fsf@gnu.org> <834lzgreqq.fsf@gnu.org> <3f07808e-ab1c-d6b5-9ea0-dfc4c6fd6fc9@cornell.edu> <8337f0rbz6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------D449AD32CFD6AC8A636BF736" X-Trace: blaine.gmane.org 1488235159 32513 195.159.176.226 (27 Feb 2017 22:39:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 27 Feb 2017 22:39:19 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 Cc: 25875@debbugs.gnu.org To: Richard Copley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 27 23:39:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciTwh-0007bB-Jg for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Feb 2017 23:39:07 +0100 Original-Received: from localhost ([::1]:57314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciTwn-0005hr-Gf for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Feb 2017 17:39:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciTvj-0004zt-Uo for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2017 17:38:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciTvf-0003xL-1n for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2017 17:38:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60600) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ciTve-0003w4-Tt for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2017 17:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ciTve-0002CX-GE for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2017 17:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Feb 2017 22:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25875 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25875-submit@debbugs.gnu.org id=B25875.14882350618433 (code B ref 25875); Mon, 27 Feb 2017 22:38:02 +0000 Original-Received: (at 25875) by debbugs.gnu.org; 27 Feb 2017 22:37:41 +0000 Original-Received: from localhost ([127.0.0.1]:58799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciTvJ-0002Bw-AH for submit@debbugs.gnu.org; Mon, 27 Feb 2017 17:37:41 -0500 Original-Received: from limerock01.mail.cornell.edu ([128.84.13.241]:40596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciTvH-0002Bi-Fo for 25875@debbugs.gnu.org; Mon, 27 Feb 2017 17:37:39 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v1RMbXME008540; Mon, 27 Feb 2017 17:37:33 -0500 Original-Received: from [192.168.1.4] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v1RMbVfW021240 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 27 Feb 2017 17:37:32 -0500 In-Reply-To: X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129912 Archived-At: This is a multi-part message in MIME format. --------------D449AD32CFD6AC8A636BF736 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2/27/2017 3:14 AM, Richard Copley wrote: > Sorry Ken, I can't sabotage myself like that, I have work to do. FWIW, I'm attaching a corrected version of the patch. With one exception, it only replaces SendMessage by SendMessageTimeout in cases where the return value of SendMessage was not used. In the exceptional case, the return value was only tested to see if it was 0 or not, so I think the replacement is still correct. Richard, it's your call whether or not it's worthwhile for you to run with this patch for a while and see what happens. I understand that this might not give a definitive answer. I still want to eventually apply the patch I posted in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25875#41, which I think will solve the problem in a less satisfactory way. But I'd rather hold off on that in the hope that we'll get some evidence as to whether we've correctly diagnosed the problem. Ken --------------D449AD32CFD6AC8A636BF736 Content-Type: text/plain; charset=UTF-8; name="SendMessageTimeout.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="SendMessageTimeout.patch" ZGlmZiAtLWdpdCBhL3NyYy93MzJ0ZXJtLmMgYi9zcmMvdzMydGVybS5jCmluZGV4IGQ2Yjc4 ZmQuLmJhNjQ2ZmIgMTAwNjQ0Ci0tLSBhL3NyYy93MzJ0ZXJtLmMKKysrIGIvc3JjL3czMnRl cm0uYwpAQCAtNTQ4LDcgKzU0OCw4IEBAIHhfdXBkYXRlX3dpbmRvd19iZWdpbiAoc3RydWN0 IHdpbmRvdyAqdykKICAgLyogSGlkZSB0aGUgc3lzdGVtIGNhcmV0IGR1cmluZyBhbiB1cGRh dGUuICAqLwogICBpZiAodzMyX3VzZV92aXNpYmxlX3N5c3RlbV9jYXJldCAmJiB3MzJfc3lz dGVtX2NhcmV0X2h3bmQpCiAgICAgewotICAgICAgU2VuZE1lc3NhZ2UgKHczMl9zeXN0ZW1f Y2FyZXRfaHduZCwgV01fRU1BQ1NfSElERV9DQVJFVCwgMCwgMCk7CisgICAgICBTZW5kTWVz c2FnZVRpbWVvdXQgKHczMl9zeXN0ZW1fY2FyZXRfaHduZCwgV01fRU1BQ1NfSElERV9DQVJF VCwgMCwgMCwKKwkJCSAgMCwgMTAwLCBOVUxMKTsKICAgICB9CiAKICAgdy0+b3V0cHV0X2N1 cnNvciA9IHctPmN1cnNvcjsKQEAgLTcxNCw3ICs3MTUsOCBAQCB4X3VwZGF0ZV93aW5kb3df ZW5kIChzdHJ1Y3Qgd2luZG93ICp3LCBib29sIGN1cnNvcl9vbl9wLAogICAgICB4X3VwZGF0 ZV93aW5kb3dfYmVnaW4uICAqLwogICBpZiAodzMyX3VzZV92aXNpYmxlX3N5c3RlbV9jYXJl dCAmJiB3MzJfc3lzdGVtX2NhcmV0X2h3bmQpCiAgICAgewotICAgICAgU2VuZE1lc3NhZ2Ug KHczMl9zeXN0ZW1fY2FyZXRfaHduZCwgV01fRU1BQ1NfU0hPV19DQVJFVCwgMCwgMCk7Cisg ICAgICBTZW5kTWVzc2FnZVRpbWVvdXQgKHczMl9zeXN0ZW1fY2FyZXRfaHduZCwgV01fRU1B Q1NfU0hPV19DQVJFVCwgMCwgMCwKKwkJCSAgMCwgMTAwLCBOVUxMKTsKICAgICB9CiB9CiAK QEAgLTM2NjgsOCArMzY3MCw4IEBAIHN0YXRpYyBCT09MCiBteV9zaG93X3dpbmRvdyAoc3Ry dWN0IGZyYW1lICpmLCBIV05EIGh3bmQsIGludCBob3cpCiB7CiAjaWZuZGVmIEFUVEFDSF9U SFJFQURTCi0gIHJldHVybiBTZW5kTWVzc2FnZSAoRlJBTUVfVzMyX1dJTkRPVyAoZiksIFdN X0VNQUNTX1NIT1dXSU5ET1csCi0JCSAgICAgIChXUEFSQU0pIGh3bmQsIChMUEFSQU0pIGhv dyk7CisgIHJldHVybiBTZW5kTWVzc2FnZVRpbWVvdXQgKEZSQU1FX1czMl9XSU5ET1cgKGYp LCBXTV9FTUFDU19TSE9XV0lORE9XLAorCQkJICAgICAoV1BBUkFNKSBod25kLCAoTFBBUkFN KSBob3csIDAsIDEwMCwgTlVMTCk7CiAjZWxzZQogICByZXR1cm4gU2hvd1dpbmRvdyAoaHdu ZCwgaG93KTsKICNlbmRpZgpAQCAtMzY4Nyw3ICszNjg5LDggQEAgbXlfc2V0X3dpbmRvd19w b3MgKEhXTkQgaHduZCwgSFdORCBod25kQWZ0ZXIsCiAgIHBvcy5jeCA9IGN4OwogICBwb3Mu Y3kgPSBjeTsKICAgcG9zLmZsYWdzID0gZmxhZ3M7Ci0gIFNlbmRNZXNzYWdlIChod25kLCBX TV9FTUFDU19TRVRXSU5ET1dQT1MsIChXUEFSQU0pICZwb3MsIDApOworICBTZW5kTWVzc2Fn ZVRpbWVvdXQgKGh3bmQsIFdNX0VNQUNTX1NFVFdJTkRPV1BPUywgKFdQQVJBTSkgJnBvcywg MCwKKwkJICAgICAgMCwgMTAwLCBOVUxMKTsKICNlbHNlCiAgIFNldFdpbmRvd1BvcyAoaHdu ZCwgaHduZEFmdGVyLCB4LCB5LCBjeCwgY3ksIGZsYWdzKTsKICNlbmRpZgpAQCAtMzY5Nywy OSArMzcwMCwzMSBAQCBteV9zZXRfd2luZG93X3BvcyAoSFdORCBod25kLCBIV05EIGh3bmRB ZnRlciwKIHN0YXRpYyB2b2lkCiBteV9zZXRfZm9jdXMgKHN0cnVjdCBmcmFtZSAqIGYsIEhX TkQgaHduZCkKIHsKLSAgU2VuZE1lc3NhZ2UgKEZSQU1FX1czMl9XSU5ET1cgKGYpLCBXTV9F TUFDU19TRVRGT0NVUywKLQkgICAgICAgKFdQQVJBTSkgaHduZCwgMCk7CisgIFNlbmRNZXNz YWdlVGltZW91dCAoRlJBTUVfVzMyX1dJTkRPVyAoZiksIFdNX0VNQUNTX1NFVEZPQ1VTLAor CQkgICAgICAoV1BBUkFNKSBod25kLCAwLCAwLCAxMDAsIE5VTEwpOwogfQogI2VuZGlmCiAK IHN0YXRpYyB2b2lkCiBteV9zZXRfZm9yZWdyb3VuZF93aW5kb3cgKEhXTkQgaHduZCkKIHsK LSAgU2VuZE1lc3NhZ2UgKGh3bmQsIFdNX0VNQUNTX1NFVEZPUkVHUk9VTkQsIChXUEFSQU0p IGh3bmQsIDApOworICBTZW5kTWVzc2FnZVRpbWVvdXQgKGh3bmQsIFdNX0VNQUNTX1NFVEZP UkVHUk9VTkQsIChXUEFSQU0pIGh3bmQsIDAsCisJCSAgICAgIDAsIDEwMCwgTlVMTCk7CiB9 CiAKIAogc3RhdGljIHZvaWQKIG15X2Rlc3Ryb3lfd2luZG93IChzdHJ1Y3QgZnJhbWUgKiBm LCBIV05EIGh3bmQpCiB7Ci0gIFNlbmRNZXNzYWdlIChGUkFNRV9XMzJfV0lORE9XIChmKSwg V01fRU1BQ1NfREVTVFJPWVdJTkRPVywKLQkgICAgICAgKFdQQVJBTSkgaHduZCwgMCk7Cisg IFNlbmRNZXNzYWdlVGltZW91dCAoRlJBTUVfVzMyX1dJTkRPVyAoZiksIFdNX0VNQUNTX0RF U1RST1lXSU5ET1csCisJCSAgICAgIChXUEFSQU0pIGh3bmQsIDAsIDAsIDEwMCwgTlVMTCk7 CiB9CiAKIHN0YXRpYyB2b2lkCiBteV9icmluZ193aW5kb3dfdG9fdG9wIChIV05EIGh3bmQp CiB7Ci0gIFNlbmRNZXNzYWdlIChod25kLCBXTV9FTUFDU19CUklOR1RPVE9QLCAoV1BBUkFN KSBod25kLCAwKTsKKyAgU2VuZE1lc3NhZ2VUaW1lb3V0IChod25kLCBXTV9FTUFDU19CUklO R1RPVE9QLCAoV1BBUkFNKSBod25kLCAwLAorCQkgICAgICAwLCAxMDAsIE5VTEwpOwogfQog CiAvKiBDcmVhdGUgYSBzY3JvbGwgYmFyIGFuZCByZXR1cm4gdGhlIHNjcm9sbCBiYXIgdmVj dG9yIGZvciBpdC4gIFcgaXMKQEAgLTY1MzgsNyArNjU0Myw4IEBAIHhfaWNvbmlmeV9mcmFt ZSAoc3RydWN0IGZyYW1lICpmKQogICB4X3NldF9iaXRtYXBfaWNvbiAoZik7CiAKICAgLyog U2ltdWxhdGUgdGhlIHVzZXIgbWluaW1pemluZyB0aGUgZnJhbWUuICAqLwotICBTZW5kTWVz c2FnZSAoRlJBTUVfVzMyX1dJTkRPVyAoZiksIFdNX1NZU0NPTU1BTkQsIFNDX01JTklNSVpF LCAwKTsKKyAgU2VuZE1lc3NhZ2VUaW1lb3V0IChGUkFNRV9XMzJfV0lORE9XIChmKSwgV01f U1lTQ09NTUFORCwgU0NfTUlOSU1JWkUsIDAsCisJCSAgICAgIDAsIDEwMCwgTlVMTCk7CiAK ICAgU0VUX0ZSQU1FX1ZJU0lCTEUgKGYsIDApOwogICBTRVRfRlJBTUVfSUNPTklGSUVEIChm LCB0cnVlKTsK --------------D449AD32CFD6AC8A636BF736--