From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Benjamin Orthen Newsgroups: gmane.emacs.bugs Subject: bug#63916: 30.0.50; use-package: changes do not propagate to elpa-devel Date: Mon, 11 Sep 2023 11:58:45 +0200 Message-ID: <647c4e7a08e8a4b048b3fe386ac67604d79198c2.camel@orthen.net> References: <4b1ff1660351348f3d5f1bc848965d59@orthen.net> <874jnf3d0c.fsf@posteo.net> <87wn0a2sp8.fsf@posteo.net> <87fs6y6jkq.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-Tyq70y3UDtGxMBjrIX7n" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40477"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , 63916@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 11 11:59:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfdhG-000AI0-Nl for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Sep 2023 11:59:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfdh8-0005Tn-1I; Mon, 11 Sep 2023 05:59:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfdh4-0005TU-Fg for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 05:59:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfdh4-000785-7Y for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 05:58:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfdh8-0005Co-5P for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 05:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Benjamin Orthen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2023 09:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63916 X-GNU-PR-Package: emacs Original-Received: via spool by 63916-submit@debbugs.gnu.org id=B63916.169442633519998 (code B ref 63916); Mon, 11 Sep 2023 09:59:02 +0000 Original-Received: (at 63916) by debbugs.gnu.org; 11 Sep 2023 09:58:55 +0000 Original-Received: from localhost ([127.0.0.1]:52164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfdh0-0005CT-Hd for submit@debbugs.gnu.org; Mon, 11 Sep 2023 05:58:55 -0400 Original-Received: from mailproxy01.manitu.net ([217.11.48.65]:56676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfdgx-0005CH-8o for 63916@debbugs.gnu.org; Mon, 11 Sep 2023 05:58:52 -0400 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270033 Archived-At: --=-Tyq70y3UDtGxMBjrIX7n Content-Type: multipart/alternative; boundary="=-J6iBT+L5Q00JwpFQK48i" --=-J6iBT+L5Q00JwpFQK48i Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, I've sent the mail to assign@gnu.org=C2=A0and request the assignment form. I modified the changes according to your and Philip's remarks. On Fri, 2023-09-08 at 15:35 -0400, Stefan Monnier wrote: > Hi, >=20 > > Instead of looking only at the git log of the main package file, we > > look instead at the git log of all files of the core package. > > This way, a new devel version is created when any other package > > file is > > changed, not just the main file. >=20 > It has a minor downside which is that it slows down the overwhelming > cases (where there are no changes), but it's probably lost in the > noise, > so it sounds like a very good idea, thank you. >=20 > > Is this the right mailing list to send the patch? >=20 > Yes. >=20 > [ BTW, Philip's `list-ensure` is called `ensure-list` :-) > =C2=A0 And yes, I think it's OK to use functionality from Emacs-28.=C2=A0= ] >=20 > > +=C2=A0 (when-let > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ((core (elpaa--spec-get pkg-spec :core)= )) >=20 > AFAICT this code is only used when `:core` is non-nil, so better > either > not test for it redundantly, or do it via `cl-assert`. Done >=20 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unless (member item excludes= ) >=20 > The code looks generally good, but I'm not sure about the one line > above: > - I know it won't do the right thing for ERC's "lisp/erc/ChangeLog.*" > =C2=A0 but it's probably harmless (those files basically never change > =C2=A0 anyway). > - I have the impression that it won't do the right thing for > =C2=A0 `use-package`'s "bind-key.el" I changed the code to ignore files using the wildcards in :excludes. This still does not work for "bind-key.el", but IMO this can and should be solved by changing it to "lisp/use-package/bind-key.el",=C2=A0 similar to how erc is doing it ("lisp/erc/erc-loaddefs.el" ). (The commentary says: ";; Exclude matches must be against the full file-name, substring matches don't ;; work unless wildcards are used (e.g. use "etc/*" instead of "etc/").") >=20 > Also, I see you do (concat item file) but you only know that `item` > is > a directory, not that it ends with a `/`.=C2=A0 Better use `file-name- > concat`. With `directory-files-recursively` this has resolved itself. >=20 > Last but not least: I think this doesn't quite qualify as "trivial" > so > we'd need you to sign the copyright paperwork (well, maybe with some > of > the suggested simplifications, it could qualify as "trivial", but > it's > easier if you sign the paperwork so we don't have to worry about it, > especially if you ever submit more code, which I hope you will). > To that end, please fill the form below and email it to the FSF as > instructed so they can send you the appropriate paperwork to sign. >=20 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Stefan >=20 >=20 > Please email the following information to assign@gnu.org, and we > will send you the assignment form for your past and future changes. >=20 > Please use your full legal name (in ASCII characters) as the subject > line of the message. > ---------------------------------------------------------------------- > REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES >=20 > [What is the name of the program or package you're contributing to?] > Emacs >=20 > [Did you copy any files or text written by someone else in these > changes? > Even if that material is free software, we need to know about it.] >=20 >=20 > [Do you have an employer who might have a basis to claim to own > your changes?=C2=A0 Do you attend a school which might make such a claim?= ] >=20 >=20 > [For the copyright registration, what country are you a citizen of?] >=20 >=20 > [What year were you born?] >=20 >=20 > [Please write your email address here.] >=20 >=20 > [Please write your postal address here.] >=20 >=20 >=20 >=20 >=20 > [Which files have you changed so far, and which new files have you > written > so far?] >=20 --=-J6iBT+L5Q00JwpFQK48i Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Hi,

I've sent the mail t= o assign@gnu.org and request the= assignment form.

I modified the changes according= to your and Philip's remarks.

On Fri, 2023-09-08 = at 15:35 -0400, Stefan Monnier wrote:
Hi,

Instead of loo= king only at the git log of the main package file, we
look in= stead at the git log of all files of the core package.
This w= ay, a new devel version is created when any other package file is
=
changed, not just the main file.

=
It has a minor downside which is that it slows down the overwhelming
cases (where there are no changes), but it's probably lost in = the noise,
so it sounds like a very good idea, thank you.
=

Is this the right mail= ing list to send the patch?

Yes.<= br>

[ BTW, Philip's `list-ensure` is called `ensur= e-list` :-)
  And yes, I think it's OK to use functional= ity from Emacs-28.  ]

+  (when-let
+      ((c= ore (elpaa--spec-get pkg-spec :core)))

AFAICT this code is only used when `:core` is non-nil, so better eith= er
not test for it redundantly, or do it via `cl-assert`.
=

Done

+    &n= bsp;            = ;   (unless (member item excludes)
The code looks generally good, but I'm not sure about the one l= ine
above:
- I know it won't do the right thing= for ERC's "lisp/erc/ChangeLog.*"
  but it's probably ha= rmless (those files basically never change
  anyway).
- I have the impression that it won't do the right thing for
  `use-package`'s "bind-key.el"

I changed the code to ignore files using the wildcards in := excludes.
This still does not work for "bind-key.el", but IMO thi= s can and should be solved by changing it to "lisp/use-package/bind-key.el"= , 
similar to how erc is doing it ("lisp/erc/erc-loaddefs.el= " ).

(The commentary says: ";; Exclude matches mus= t be against the full file-name, substring matches don't
;; work = unless wildcards are used (e.g. use "etc/*" instead of "etc/").")


Also, I see you d= o (concat item file) but you only know that `item` is
a direc= tory, not that it ends with a `/`.  Better use `file-name-concat`.
=

With `directory-files-recursively` t= his has resolved itself.

Last but not least: I think this doesn't quite qualify as "trivial" so
we'd need you to sign the copyright paperwork (well, maybe with= some of
the suggested simplifications, it could qualify as "= trivial", but it's
easier if you sign the paperwork so we don= 't have to worry about it,
especially if you ever submit more= code, which I hope you will).
To that end, please fill the f= orm below and email it to the FSF as
instructed so they can s= end you the appropriate paperwork to sign.

        Stefan


Please email the following information to assign@gnu.org, and we
wi= ll send you the assignment form for your past and future changes.
=

Please use your full legal name (in ASCII characters) a= s the subject
line of the message.
------------= ----------------------------------------------------------
RE= QUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[= What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text w= ritten by someone else in these changes?
Even if that materia= l is free software, we need to know about it.]


[Do you have an employer who might have a basis to claim to= own
your changes?  Do you attend a school which might m= ake such a claim?]


[For the cop= yright registration, what country are you a citizen of?]

=

[What year were you born?]


[Please write your email address here.]


[Please write your postal address here.]
=





=
[Which files have you changed so far, and which new files have y= ou written
so far?]


--=-J6iBT+L5Q00JwpFQK48i-- --=-Tyq70y3UDtGxMBjrIX7n Content-Disposition: attachment; filename*0=0001-Add-elpa-core-files-to-get-more-exact-devel-versions.pat; filename*1=ch Content-Type: text/x-patch; name="0001-Add-elpa-core-files-to-get-more-exact-devel-versions.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAwMjkwZTJmMmU5YmM1YTM2MTVkZGU1NGMxNDJhZTNjYjU0ZGMyMjc0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBPcnRoZW4gPGdpdEBvcnRoZW4ubmV0PgpEYXRl OiBGcmksIDggU2VwIDIwMjMgMTI6MDU6MTQgKzAyMDAKU3ViamVjdDogW1BBVENIXSBBZGQgZWxw YS0tY29yZS1maWxlcyB0byBnZXQgbW9yZSBleGFjdCBkZXZlbC12ZXJzaW9ucyBmb3IKIGNvcmUg cGFja2FnZXMKCi0tLQogZWxwYS1hZG1pbi5lbCB8IDU0ICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQzIGluc2VydGlv bnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2VscGEtYWRtaW4uZWwgYi9lbHBh LWFkbWluLmVsCmluZGV4IDJjMmQyYWVhYjcuLmQ5YTIyYjAwNTUgMTAwNjQ0Ci0tLSBhL2VscGEt YWRtaW4uZWwKKysrIGIvZWxwYS1hZG1pbi5lbApAQCAtOTA4LDIwICs5MDgsNTIgQEAgb2YgdGhl IGN1cnJlbnQgYHByb2Nlc3MtZW52aXJvbm1lbnQnLiAgUmV0dXJuIHRoZSBtb2RpZmllZCBjb3B5 LiIKICAgICAgICAgICAgICAgIDApKSkKICAgICAoZW5jb2RlLXRpbWUgKGxpc3QgcyBtaSBoIGQg bW8geSBuaWwgbmlsIHpzKSkpKQogCisoZGVmdW4gZWxwYWEtLWNvcmUtZmlsZXMgKHBrZy1zcGVj KQorICAiR2V0IGEgbGlzdCBvZiBjb3JlIGZpbGVzIChhbmQgb25seSBmaWxlcykgZm9yIFBLRy1T UEVDLgorQ29yZSBmb2xkZXJzIGFyZSByZWN1cnNpdmVseSBzZWFyY2hlZCwgZXhjbHVkZWQgZmls ZXMgYXJlIGlnbm9yZWQuIgorICAobGV0KiAoKGZpbGUtcGF0dGVybnMgKGVuc3VyZS1saXN0IChl bHBhYS0tc3BlYy1nZXQgcGtnLXNwZWMgOmNvcmUpKSkKKyAgICAgICAgIChleGNsdWRlcyAoZWxw YWEtLXNwZWMtZ2V0IHBrZy1zcGVjIDpleGNsdWRlcykpCisgICAgICAgICAoZW1hY3MtcmVwby1y b290IChleHBhbmQtZmlsZS1uYW1lICJlbWFjcyIpKQorICAgICAgICAgKGRlZmF1bHQtZGlyZWN0 b3J5IGVtYWNzLXJlcG8tcm9vdCkKKyAgICAgICAgIChjb3JlLWZpbGVzIG5pbCkpCisKKyAgICA7 OyBlbnN1cmUgd2UgbG9vayBhdCBmaWxlcyBmcm9tIGEgY29yZSBwYWNrYWdlCisgICAgKGNsLWFz c2VydCBmaWxlLXBhdHRlcm5zKQorCisgICAgOzsgd2UgbG9vayBhdCBlYWNoIGZpbGUgb3IgZmls ZXMgaW4gZm9sZGVyIGFuZCBhZGQgdGhlbQorICAgIDs7IHRvIGNvcmUtZmlsZXMKKyAgICAoZG9s aXN0IChpdGVtIGZpbGUtcGF0dGVybnMpCisgICAgICAoaWYgKGZpbGUtZGlyZWN0b3J5LXAgaXRl bSkKKyAgICAgICAgICAoc2V0cSBjb3JlLWZpbGVzIChhcHBlbmQgY29yZS1maWxlcyAoZGlyZWN0 b3J5LWZpbGVzLXJlY3Vyc2l2ZWx5IGl0ZW0gIi4qIikpKQorICAgICAgICAocHVzaCBpdGVtIGNv cmUtZmlsZXMpKSkKKworICAgIDs7IHJlbW92ZSBhbGwgZmlsZXMgd2hpY2ggbWF0Y2ggYSB3aWxk Y2FyZCBpbiB0aGUgZXhjbHVkZXMKKyAgICAoc2V0cSBjb3JlLWZpbGVzIChjbC1yZW1vdmUtaWYK KyAgICAgICAgICAgICAgICAgICAgICAobGFtYmRhIChmaWxlLW5hbWUpCisgICAgICAgICAgICAg ICAgICAgICAgICAoc2VxLXNvbWUKKyAgICAgICAgICAgICAgICAgICAgICAgICAobGFtYmRhICh3 aWxkY2FyZCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctbWF0Y2gtcCAod2ls ZGNhcmQtdG8tcmVnZXhwIHdpbGRjYXJkKSBmaWxlLW5hbWUpKQorICAgICAgICAgICAgICAgICAg ICAgICAgIGV4Y2x1ZGVzKSkKKyAgICAgICAgICAgICAgICAgICAgICBjb3JlLWZpbGVzKSkKKyAg ICBjb3JlLWZpbGVzKSkKKwogKGRlZnVuIGVscGFhLS1nZXQtZGV2ZWwtdmVyc2lvbiAoZGlyIHBr Zy1zcGVjKQogICAiQ29tcHV0ZSB0aGUgZGF0ZS1iYXNlZCBwc2V1ZG8tdmVyc2lvbiB1c2VkIGZv ciBkZXZlbCBidWlsZHMuIgotICAobGV0KiAoKGZ0biAoZmlsZS10cnVlbmFtZSAgICAgIDs7IEZv bGxvdyBzeW1saW5rcyEKLSAgICAgICAgICAgICAgKGV4cGFuZC1maWxlLW5hbWUgKGVscGFhLS1t YWluLWZpbGUgcGtnLXNwZWMpIGRpcikpKQotICAgICAgICAgKGRlZmF1bHQtZGlyZWN0b3J5IChm aWxlLW5hbWUtZGlyZWN0b3J5IGZ0bikpCi0gICAgICAgICAoZ2l0ZGF0ZQorICAobGV0KiAoKGdp dGRhdGUKICAgICAgICAgICAod2l0aC10ZW1wLWJ1ZmZlcgotICAgICAgICAgICAoaWYgKHBsaXN0 LWdldCAoY2RyIHBrZy1zcGVjKSA6Y29yZSkKLSAgICAgICAgICAgICAgIDs7IEZvciBjb3JlIHBh Y2thZ2VzLCBkb24ndCB1c2UgdGhlIGRhdGUgb2YgdGhlIGxhc3QKLSAgICAgICAgICAgICAgIDs7 IGNvbW1pdCB0byB0aGUgYnJhbmNoLCBidXQgdGhhdCBvZiB0aGUgbGFzdCBjb21taXQKLSAgICAg ICAgICAgICAgIDs7IHRvIHRoZSBtYWluIGZpbGUuCi0gICAgICAgICAgICAgICAoZWxwYWEtLWNh bGwgdCAiZ2l0IiAibG9nIiAiLS1wcmV0dHk9Zm9ybWF0OiVjSSIgIi0tbm8tcGF0Y2giCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgIi0xIiAiLS0iIChmaWxlLW5hbWUtbm9uZGlyZWN0b3J5 IGZ0bikpCi0gICAgICAgICAgICAgKGVscGFhLS1jYWxsIHQgImdpdCIgInNob3ciICItLXByZXR0 eT1mb3JtYXQ6JWNJIiAiLS1uby1wYXRjaCIpKQorICAgICAgICAgICAgKGlmIChwbGlzdC1nZXQg KGNkciBwa2ctc3BlYykgOmNvcmUpCisgICAgICAgICAgICAgICAgKGxldAorICAgICAgICAgICAg ICAgICAgICAoKGNvcmUtZmlsZXMgKGVscGFhLS1jb3JlLWZpbGVzIHBrZy1zcGVjKSkKKyAgICAg ICAgICAgICAgICAgICAgIChkZWZhdWx0LWRpcmVjdG9yeSAoZXhwYW5kLWZpbGUtbmFtZSAiZW1h Y3MiKSkpCisgICAgICAgICAgICAgICAgICA7OyBGb3IgY29yZSBwYWNrYWdlcywgZG9uJ3QgdXNl IHRoZSBkYXRlIG9mIHRoZSBsYXN0CisgICAgICAgICAgICAgICAgICA7OyBjb21taXQgdG8gdGhl IGJyYW5jaCwgYnV0IHRoYXQgb2YgdGhlIGxhc3QgY29tbWl0CisgICAgICAgICAgICAgICAgICA7 OyB0byB0aGUgY29yZSBmaWxlcy4KKyAgICAgICAgICAgICAgICAgIChhcHBseSAjJ2VscGFhLS1j YWxsIHQgImdpdCIgImxvZyIgIi0tcHJldHR5PWZvcm1hdDolY0kiICItLW5vLXBhdGNoIgorICAg ICAgICAgICAgICAgICAgICAgICAgICItMSIgIi0tIiBjb3JlLWZpbGVzKSkKKyAgICAgICAgICAg ICAgKGxldCogKChmdG4gKGZpbGUtdHJ1ZW5hbWUgICAgICA7OyBGb2xsb3cgc3ltbGlua3MhCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAoZXhwYW5kLWZpbGUtbmFtZSAoZWxwYWEtLW1haW4t ZmlsZSBwa2ctc3BlYykgZGlyKSkpCisgICAgICAgICAgICAgICAgICAgICAoZGVmYXVsdC1kaXJl Y3RvcnkgKGZpbGUtbmFtZS1kaXJlY3RvcnkgZnRuKSkpCisgICAgICAgICAgICAgICAgKGVscGFh LS1jYWxsIHQgImdpdCIgInNob3ciICItLXByZXR0eT1mb3JtYXQ6JWNJIiAiLS1uby1wYXRjaCIp KSkKICAgICAgICAgICAgIChidWZmZXItc3RyaW5nKSkpCiAgICAgICAgICAodmVyZGF0ZQogICAg ICAgICAgIDs7IENvbnZlcnQgR2l0J3MgZGF0ZSBpbnRvIHNvbWV0aGluZyB0aGF0IGxvb2tzIGxp a2UgYSB2ZXJzaW9uIG51bWJlci4KLS0gCjIuNDEuMAoK --=-Tyq70y3UDtGxMBjrIX7n--