From: Yuan Fu <casouri@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 61205@debbugs.gnu.org, "Theodor Thornhill" <theo@thornhill.no>,
"Jostein Kjønigsen" <jostein@secure.kjonigsen.net>,
"randy taylor" <dev@rjt.dev>
Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list
Date: Thu, 2 Feb 2023 18:38:37 -0800 [thread overview]
Message-ID: <645D27C7-0376-45F9-A5C9-CD84F9467ED4@gmail.com> (raw)
In-Reply-To: <eed522ba-bfb6-ca03-4e5a-a987298e9d71@yandex.ru>
> On Feb 2, 2023, at 12:25 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:
>
> On 01/02/2023 07:18, Yuan Fu wrote:
>>> On Jan 31, 2023, at 6:08 PM, Dmitry Gutov<dgutov@yandex.ru> wrote:
>>>
>>> X-Debbugs-Cc: Yuan Fu<casouri@gmail.com>, Randy Taylor<dev@rjt.dev>
>>>
>>> Some new built-in modes has 'function' feature highlighting thus enabled by default.
>>>
>>> rust-ts-mode, go-ts-mode, cmake-mode
>>>
>>> Should we move it to 4 for consistency with the rest?
>>>
>>> Previously, we talked about that and concluded that function calls are usually everywhere and are easy to notice without additional highlighting.
>> Right, I think they should be level 4.
>
> On a related note: 'property' is in level 3 in c-ts-mode.
>
> Should it to go level 4?
I believe property is level 3. Quoting the (emacs) manual:
Level 1
This level usually fontifies only comments and function names in
function definitions.
Level 2
This level adds fontification of keywords, strings, and data types.
Level 3
This is the default level; it adds fontification of assignments,
numbers, properties, etc.
Level 4
This level adds everything else that can be fontified: operators,
delimiters, brackets, other punctuation, function names in function
calls, variables, etc.
Yuan
next prev parent reply other threads:[~2023-02-03 2:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 2:08 bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Dmitry Gutov
2023-02-01 5:18 ` Yuan Fu
2023-02-02 2:34 ` Dmitry Gutov
2023-02-02 3:18 ` Randy Taylor
2023-02-02 11:03 ` Dmitry Gutov
2023-02-02 20:25 ` Dmitry Gutov
2023-02-03 2:38 ` Yuan Fu [this message]
2023-02-03 2:51 ` Dmitry Gutov
2023-02-03 6:45 ` Eli Zaretskii
2023-02-03 6:46 ` Eli Zaretskii
2023-02-03 11:42 ` Dmitry Gutov
2023-02-03 12:19 ` Eli Zaretskii
2023-02-03 15:15 ` Dmitry Gutov
2023-02-03 15:54 ` Eli Zaretskii
2023-02-03 17:10 ` Dmitry Gutov
2023-02-04 3:36 ` Dmitry Gutov
2023-02-04 6:53 ` Eli Zaretskii
2023-02-04 23:44 ` Dmitry Gutov
2023-02-05 6:05 ` Eli Zaretskii
2023-02-05 13:52 ` Dmitry Gutov
2023-02-02 2:34 ` Randy Taylor
2023-02-02 2:44 ` Dmitry Gutov
2023-02-02 3:29 ` Randy Taylor
2023-02-02 11:11 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=645D27C7-0376-45F9-A5C9-CD84F9467ED4@gmail.com \
--to=casouri@gmail.com \
--cc=61205@debbugs.gnu.org \
--cc=dev@rjt.dev \
--cc=dgutov@yandex.ru \
--cc=jostein@secure.kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.