From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#33530: 26.1.90; D-Bus crashes Emacs: consp, Fatal error 7: Bus error Date: Tue, 27 Nov 2018 21:40:55 -0800 Organization: UCLA Computer Science Department Message-ID: <644e275a-e9c0-4330-aa70-64969d4159d7@cs.ucla.edu> References: <87va4i1bl6.fsf@cassou.me> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------73BDD737DCB45C12A45C962A" X-Trace: blaine.gmane.org 1543383977 555 195.159.176.226 (28 Nov 2018 05:46:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Nov 2018 05:46:17 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 Cc: Michael Albinus To: Damien Cassou , 33530-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 28 06:46:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRsfq-0008Ua-Bz for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Nov 2018 06:46:10 +0100 Original-Received: from localhost ([::1]:46076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRshw-0005J5-M9 for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Nov 2018 00:48:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRsbv-0006lv-QV for bug-gnu-emacs@gnu.org; Wed, 28 Nov 2018 00:42:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRsbs-0005vM-Gr for bug-gnu-emacs@gnu.org; Wed, 28 Nov 2018 00:42:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48483) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRsbq-0005uP-ND for bug-gnu-emacs@gnu.org; Wed, 28 Nov 2018 00:42:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gRsbq-0005Sm-Ge for bug-gnu-emacs@gnu.org; Wed, 28 Nov 2018 00:42:02 -0500 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Nov 2018 05:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 33530 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 33530@debbugs.gnu.org, eggert@cs.ucla.edu, damien@cassou.me Original-Received: via spool by 33530-done@debbugs.gnu.org id=D33530.154338366520934 (code D ref 33530); Wed, 28 Nov 2018 05:42:02 +0000 Original-Received: (at 33530-done) by debbugs.gnu.org; 28 Nov 2018 05:41:05 +0000 Original-Received: from localhost ([127.0.0.1]:52739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRsav-0005RZ-Bo for submit@debbugs.gnu.org; Wed, 28 Nov 2018 00:41:05 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRsat-0005Qy-9E for 33530-done@debbugs.gnu.org; Wed, 28 Nov 2018 00:41:03 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E40A816009D; Tue, 27 Nov 2018 21:40:56 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id EQwyqSdHxVHU; Tue, 27 Nov 2018 21:40:56 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2223F1600EE; Tue, 27 Nov 2018 21:40:56 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id j9G3lvQBRRhU; Tue, 27 Nov 2018 21:40:56 -0800 (PST) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id EA85116009D; Tue, 27 Nov 2018 21:40:55 -0800 (PST) In-Reply-To: <87va4i1bl6.fsf@cassou.me> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152842 Archived-At: This is a multi-part message in MIME format. --------------73BDD737DCB45C12A45C962A Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting that. I installed the attached into the master branch and am marking the bug as fixed. Not sure whether it's worth installing into the emacs-26 branch. It is a serious problem if Lisp code can make Emacs crash; on the other hand, the usage is erroneous. --------------73BDD737DCB45C12A45C962A Content-Type: text/x-patch; name="0001-Fix-core-dump-in-dbus-message-internal.patch" Content-Disposition: attachment; filename="0001-Fix-core-dump-in-dbus-message-internal.patch" Content-Transfer-Encoding: quoted-printable >From cef3f8fbf98296eaa59f80716db33b4f8689889a Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 27 Nov 2018 21:36:18 -0800 Subject: [PATCH] Fix core dump in dbus-message-internal MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * src/dbusbind.c (Fdbus_message_internal): Don=E2=80=99t go past array end (Bug#33530). --- src/dbusbind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dbusbind.c b/src/dbusbind.c index 9bc344e961..403fc598c0 100644 --- a/src/dbusbind.c +++ b/src/dbusbind.c @@ -1423,7 +1423,7 @@ usage: (dbus-message-internal &rest REST) */) for (; count < nargs; ++count) { dtype =3D XD_OBJECT_TO_DBUS_TYPE (args[count]); - if (XD_DBUS_TYPE_P (args[count])) + if (count + 1 < nargs && XD_DBUS_TYPE_P (args[count])) { XD_DEBUG_VALID_LISP_OBJECT_P (args[count]); XD_DEBUG_VALID_LISP_OBJECT_P (args[count+1]); --=20 2.17.1 --------------73BDD737DCB45C12A45C962A--