From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60953: The :match predicate with large regexp in tree-sitter font-lock seems inefficient Date: Wed, 1 Feb 2023 18:16:05 -0800 Message-ID: <644EE883-9DC1-44B6-BD6C-2082319324F2@gmail.com> References: <7624dddc-4600-9a03-ac8b-d3c9e0ab618c@yandex.ru> <83wn5ag4nc.fsf@gnu.org> <01b5d074-fb12-6b1f-cbfb-5e759833b854@yandex.ru> <838rhpg57n.fsf@gnu.org> <5026D975-983F-4D18-8690-BE139C92825D@gmail.com> <83pmb1emxi.fsf@gnu.org> <6f318afc-ca71-8b7e-c822-52e6635b5718@yandex.ru> <83sffxcfxw.fsf@gnu.org> <83pmb1cbg5.fsf@gnu.org> <2da844d3-ea31-289e-2821-aa174e365ffd@yandex.ru> <6784f9e7-844b-374d-2a1e-8a61cebe0d7e@yandex.ru> <83zga03yne.fsf@gnu.org> <373a575f-c683-1581-c3e6-502e9897fb04@yandex.ru> <83mt603vrc.fsf@gnu.org> <83e58a1b-2e4a-356a-36d8-c756ff105b62@yandex.ru> <83bkmf52va.fsf@gnu.org> <33cad4c1-4af5-37bb-05bc-79a4d9c1a700@yandex.ru> <83wn533lut.fsf@gnu.org> <19892f55-498e-1109-2229-2ddd984849a4@yandex.ru> <83tu073ksp.fsf@gnu.org> <83sffr2xq2.fsf@gnu.org> <30b047a9-dfe3-948a-a123-2e15221c239d@yandex.ru> <83tu05zeqe.fsf@gnu.org> <957c7e3e-830e-0a03-562f-fdddc6bd1c06@yandex.ru> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2842"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 60953@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 02 03:17:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNPAC-0000Wa-Mc for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Feb 2023 03:17:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNP9w-0008Dq-89; Wed, 01 Feb 2023 21:17:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNP9s-0008Cy-7S for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2023 21:17:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNP9r-0000Ju-5N for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2023 21:17:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNP9q-00024s-Tv for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2023 21:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 02:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60953 X-GNU-PR-Package: emacs Original-Received: via spool by 60953-submit@debbugs.gnu.org id=B60953.16753041847896 (code B ref 60953); Thu, 02 Feb 2023 02:17:02 +0000 Original-Received: (at 60953) by debbugs.gnu.org; 2 Feb 2023 02:16:24 +0000 Original-Received: from localhost ([127.0.0.1]:60182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNP9E-00023H-7K for submit@debbugs.gnu.org; Wed, 01 Feb 2023 21:16:24 -0500 Original-Received: from mail-pl1-f175.google.com ([209.85.214.175]:40829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNP9D-000233-3s for 60953@debbugs.gnu.org; Wed, 01 Feb 2023 21:16:23 -0500 Original-Received: by mail-pl1-f175.google.com with SMTP id be8so443860plb.7 for <60953@debbugs.gnu.org>; Wed, 01 Feb 2023 18:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JPx6jeI1Sa9CCyOeKgpaxHkYRohmeOwjbWyee+q70cY=; b=hKAxHoEcoQutZQlueg6dRRkKLHYFIS6ofSRq53HY9kRlZ0mj0EduEJ8jtN7QsKitG5 kyQ+JiSeWhc6clZE1UiUPprsTSH+dBga+Ru19zmUfCfI6Y5YHmnmDx4eRwYokxqnjyii K6KlORhxpM+YKVLxL5bqNiZjQ2UfnGP+/EP+zQvgjuwYzuLHUyYFexvY+PaF4y9wIE0t okP01sh0HO+z181jIcvwGXbgFWLWib/z7VAv4iWcJ/HYdDsUmHMlt8tqjjPS2n4VWxLv xYK0UzbSCIlVR3pDO5J26T0Xwtf7YG3BDOW4D6ZBmtmO2kfn2LD2yh4w89qT+FkMAivG uPIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JPx6jeI1Sa9CCyOeKgpaxHkYRohmeOwjbWyee+q70cY=; b=FsZR3refYOJDfSEqG0xUZg7v12p74+pnlHwaKfZe7yupuvnPANkefo9ipDhaTUzZ9S XO9G3mtrWg+lpCE4yzpcsLdjk1NO0eVD5X/Rxsi5eEYY8AaPDvkdcxiZJ5Kf5XMfCQpW c0Ranf8CyeA055NovMIFS43mp+lct8lopYy5lc0cogLJe0v6yl9o8s2y6CYEjmIM7lsE lvIcOF5r2LeYEXkYTYZr3DlnXqOhTwsXDZ7Wrl7LCBRO+NX03smkiwvgdwmLKjByfMCW XawczEUPV+NO7W8tjTZNtbF8bHkX8zWDcpF+7ptWjeqCLpeRsoUA12wIvUwhkAnluAfw 2g1Q== X-Gm-Message-State: AO0yUKUvCrWSKCbOJWTnEUSGRPiq782c7CjrRbXvuDVoKrU4rlr3eB3C 3jq2JVZHkibPF6YWkDHXJF4= X-Google-Smtp-Source: AK7set8DEVCCyhkxVd86Fzs6haQ6L+Qg2qzZnJ1NEA8LLLnpz0Vvl98Gq1qVP97X1hmsGLtTlel2Ww== X-Received: by 2002:a17:90a:1a46:b0:227:c69:3ca7 with SMTP id 6-20020a17090a1a4600b002270c693ca7mr5033665pjl.10.1675304177035; Wed, 01 Feb 2023 18:16:17 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id f22-20020a17090ac29600b00228f45d589fsm2010996pjt.29.2023.02.01.18.16.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Feb 2023 18:16:16 -0800 (PST) In-Reply-To: <957c7e3e-830e-0a03-562f-fdddc6bd1c06@yandex.ru> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254614 Archived-At: > On Feb 1, 2023, at 1:20 PM, Dmitry Gutov wrote: > > On 01/02/2023 15:39, Eli Zaretskii wrote: >>> Please see the attachment. >>> >>> To note the numbers: the first patch does quite well to improve the >>> performance of modes which use :match in queries which match a lot of >>> nodes (e.g. rust-ts-mode or ruby-ts-mode). There boost in those was on >>> the order of 25%. >>> >>> The second one is longer, and the boost (on top of the first one) is >>> around 5-6%, stable. Not as impressive, but at least it brings :match's >>> performance a little above :pred's in my example. >> Fine by me, if Yuan also approves. > > For emacs-29, right? > > Waiting for Yuan's confirmation. Yeah please go ahead :-) Yuan