From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Daniel Clemente <n142857@gmail.com>
Cc: 73022@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#73022: 31.0.50; Crash in build_frame_matrix_from_leaf_window after C-x 2 and reducing terminal size
Date: Sun, 8 Sep 2024 16:36:24 +0200 [thread overview]
Message-ID: <6421c647-1675-4e28-80ad-43eea06cf5fe@gmx.at> (raw)
In-Reply-To: <CAJKAhPBjuvicyTcDcjxmx5xCRsUqWkUw9LEOf7oQoHr6trVh_w@mail.gmail.com>
> We're dealing with two type of assertion violations / crashes / backtraces:
> - in update_frame_line, that causes chcheckmagic to fail
> - in build_frame_matrix_from_leaf_window, assertion violation
>
> With the same build I mentioned in the top post (that is, without any
> code change), I can see both, after following the same instructions I
> posted.
> The update_frame_line happens much more frequently, therefore I
> thought that the update_frame_line was fixed in 71289; but it's not: I
> just reproduced the update_frame_line issue.
Good to know.
> So you can't be sure that the original assertion violation is gone.
Right.
> Your build may have crashed with the update_frame_line crash, before
> reaching the build_frame_matrix_from_leaf_window crash.
Right again. But I think that with my initial patch, the likeliness of
the later has decreased.
> The best would be to solve both crashes :-)
>
> I don't know whether both crashes are related.
They are both caused by shrinking the frame size to something Emacs
doesn't like. Note the
if (width > 5 && height > 2)
check in handle_window_change_signal and the
/* Don't allow too small height of text-mode frames, or else cm.c
might abort in cmcheckmagic. */
if ((FRAME_TERMCAP_P (f) || FRAME_MSDOS_P (f)) && NILP (horizontal))
{
int min_height = (FRAME_MENU_BAR_LINES (f)
+ FRAME_TAB_BAR_LINES (f)
+ FRAME_WANTS_MODELINE_P (f)
+ 2); /* one text line and one echo-area line */
if (retval < min_height)
retval = min_height;
}
in frame_windows_min_size. People always were aware of the problem but
with split windows these values are of no use.
martin
next prev parent reply other threads:[~2024-09-08 14:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 6:09 bug#73022: 31.0.50; Crash in build_frame_matrix_from_leaf_window after C-x 2 and reducing terminal size Daniel Clemente
[not found] ` <handler.73022.B.172543028723315.ack@debbugs.gnu.org>
2024-09-04 6:25 ` bug#73022: Acknowledgement (31.0.50; Crash in build_frame_matrix_from_leaf_window after C-x 2 and reducing terminal size) Daniel Clemente
2024-09-04 7:28 ` bug#73022: 31.0.50; Crash in build_frame_matrix_from_leaf_window after C-x 2 and reducing terminal size martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-04 12:21 ` Eli Zaretskii
2024-09-04 13:23 ` Eli Zaretskii
2024-09-05 8:18 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 9:19 ` Eli Zaretskii
2024-09-05 14:46 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 14:58 ` Eli Zaretskii
2024-09-05 15:48 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 16:05 ` Eli Zaretskii
2024-09-05 16:30 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 16:58 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 18:41 ` Eli Zaretskii
2024-09-05 18:15 ` Eli Zaretskii
2024-09-08 11:07 ` Daniel Clemente
2024-09-08 14:36 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-09-05 8:18 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 9:18 ` Eli Zaretskii
2024-09-05 14:45 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 15:10 ` Eli Zaretskii
2024-09-05 16:27 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-08 11:08 ` Daniel Clemente
2024-09-08 11:31 ` Eli Zaretskii
2024-09-08 14:58 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-10 17:43 ` Daniel Clemente
2024-09-11 8:07 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-11 12:22 ` Eli Zaretskii
2024-09-11 14:37 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-11 15:06 ` Eli Zaretskii
2024-09-12 9:49 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-08 11:09 ` Daniel Clemente
2024-09-08 14:43 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-08 15:32 ` Eli Zaretskii
2024-09-08 17:01 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6421c647-1675-4e28-80ad-43eea06cf5fe@gmx.at \
--to=bug-gnu-emacs@gnu.org \
--cc=73022@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=n142857@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.