From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#67126: eshell breaking tramp-remote-path Date: Sun, 12 Nov 2023 12:18:11 -0800 Message-ID: <640dd52c-69f6-15c6-a602-d6982f7bbf8a@gmail.com> References: <87y1f3s6a9.fsf@vvvu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3020"; mail-complaints-to="usenet@ciao.gmane.io" To: Xiaoyue Chen , 67126-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 12 21:19:42 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2Gvm-0000fw-JC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Nov 2023 21:19:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2GvY-0007kC-G5; Sun, 12 Nov 2023 15:19:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2GvS-0007jl-8D for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 15:19:22 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2GvR-0007Kg-TL for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 15:19:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2Gw5-00007u-MU for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 15:20:01 -0500 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Nov 2023 20:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 67126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 67126@debbugs.gnu.org, jporterbugs@gmail.com, xchen@vvvu.org Original-Received: via spool by 67126-done@debbugs.gnu.org id=D67126.1699820347410 (code D ref 67126); Sun, 12 Nov 2023 20:20:01 +0000 Original-Received: (at 67126-done) by debbugs.gnu.org; 12 Nov 2023 20:19:07 +0000 Original-Received: from localhost ([127.0.0.1]:57077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2GvD-00006Y-8o for submit@debbugs.gnu.org; Sun, 12 Nov 2023 15:19:07 -0500 Original-Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]:51661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2Gv7-00005z-LN for 67126-done@debbugs.gnu.org; Sun, 12 Nov 2023 15:19:06 -0500 Original-Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6bd0e1b1890so2766448b3a.3 for <67126-done@debbugs.gnu.org>; Sun, 12 Nov 2023 12:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699820294; x=1700425094; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=EhR8dI0W1VG5lx8LTt8I7N0HcHqzMPEHB3W0Z1MrgMM=; b=SydG5ZyEom9LD/RvGCBG9ux5OM7pTG1eSSYNeM/eaIwSEpsCGw40aueI6UrL58j5iY bGWI8HXgcwdVDMbTwDjbknuuYcIP9y+3nSDylsIL3RzlyuClhh5fKte7nwK9duQQ1pOx C3tTHVnRzKhGhdoaNfAOEPDlVS3k5HTpuoFBmKV05ZLhCTu34BkCTI+NFU9JpBUJwX2X qdfK/faeFyujmBrWgP7meHgZThBKQ54PUyTCYFpuRkU6qBrFdinCob1pTXPotm1e8icR EaMYY5Yces3vlBLAETbyGTUm6ssgKKNgI3tZAqH1qFbCQVH5TlVg+hY/3x64HPCu0pai 0saA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699820294; x=1700425094; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EhR8dI0W1VG5lx8LTt8I7N0HcHqzMPEHB3W0Z1MrgMM=; b=q5e4k/70tJ2nhaGewnBAszv5SoWGqgzet99SIp61Fxiu5FbW6zwlYvY03htNmuQ1wX IA9m/3IHNpjadtatBhGCeIY2amegwuIaG7AdPTDNCY9m7N+ik/v9ND0bW/46ZgHCVJnB 0KhQ01+bqH7sZWqfQGp4+yPngONxdY2V5uMy9beeK8IYFFcGiiyhus+eT47XsMIUot++ YdwYBl8FH+5p8U+AQoECpFvI9QUgUMjbkDy3xuPKwsxfP0GHHSPAUnV/uiP7pIaD7Rf+ yALt/oIEtCu5DwSd6oBgWu1ITuh2WeYVGy5gohlXQFhDbgbx34hhM7oqgMEDtTrgE/qd T5Rw== X-Gm-Message-State: AOJu0YzByoo5WLCxISamHgXYR/I9wR20CCs0Q9L9Kx6Of2yABYWYkHKD TBDA/T+FKse9jt4oyqPtu2I= X-Google-Smtp-Source: AGHT+IEBb+ntNMDw70zdcI+xHVMlsUVrFaBzDSAlewiDHe6auJIbawzwfSZWoolhBanCtvulL5T8bg== X-Received: by 2002:a05:6a00:1594:b0:6c5:d2bd:ad8b with SMTP id u20-20020a056a00159400b006c5d2bdad8bmr2618212pfk.31.1699820294548; Sun, 12 Nov 2023 12:18:14 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id n41-20020a056a000d6900b006bddd1ee5f0sm2799959pfv.5.2023.11.12.12.18.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Nov 2023 12:18:13 -0800 (PST) Content-Language: en-US In-Reply-To: <87y1f3s6a9.fsf@vvvu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274225 Archived-At: Version: 30.1 On 11/12/2023 12:52 AM, Xiaoyue Chen wrote: > Tags: patch > > Hello, > > Commit 2af092741e5 broke tramp-remote-path, making eshell unusable for > sudo, ssh, etc. So any emacs version after that is effected. I found the > issue on emacs 29.1.90. Thanks for the fix! I tried your patch and everything seems ok, plus it's obviously correct by inspection. Applied on the master branch as 52afc64bad7 and the emacs-29 branch as 5bebd292c63. (I accidentally merged to master first. Oh well.) Closing this now.