From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#50340: Fix remote-location in vc-git-log-incoming Date: Sat, 4 Sep 2021 04:50:35 +0300 Message-ID: <63fb440c-a393-541d-2f92-fe28130c899e@yandex.ru> References: <87k0jz9clq.fsf@mail.linkov.net> <87o89aaxhj.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16640"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: 50340@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 04 03:51:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMKpq-0004Ca-S1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Sep 2021 03:51:10 +0200 Original-Received: from localhost ([::1]:33224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMKpo-0002fo-RQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Sep 2021 21:51:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMKpi-0002fQ-MF for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 21:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMKpi-0003sp-8T for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 21:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mMKpi-0001IQ-5J for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 21:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Sep 2021 01:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50340 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50340-submit@debbugs.gnu.org id=B50340.16307202454958 (code B ref 50340); Sat, 04 Sep 2021 01:51:02 +0000 Original-Received: (at 50340) by debbugs.gnu.org; 4 Sep 2021 01:50:45 +0000 Original-Received: from localhost ([127.0.0.1]:46179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMKpR-0001Ht-50 for submit@debbugs.gnu.org; Fri, 03 Sep 2021 21:50:45 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:46068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMKpP-0001Hh-L2 for 50340@debbugs.gnu.org; Fri, 03 Sep 2021 21:50:44 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id j17-20020a05600c1c1100b002e754875260so621634wms.4 for <50340@debbugs.gnu.org>; Fri, 03 Sep 2021 18:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=U5L2GPc+ohnMZ9sg+8AfGBnFcINnac8K9szCBkK4a2c=; b=UjzSK5xNx6sYwxwCGQnC6nOV8pJkXuTbtgeKSCRU0vb3ZFXTn5HXf/RS4zfhUetZG/ yjNPBRCWkRYl7dNOGWqITY4yk+EQoFnsueQJHW1lacOf+L3cgUKqZyA2XjhUKkj8kkuv VW3FOMKXhYjLzIlONWhBmy+p+UUw91DkiCPHfbYp8uCl+BwBuVHqCcWhdBA8K3itZ1dw hxu0Q/oeeQoMeZRyzrIEbn+K7ppTt+/o/aXY103y/pBp+lKQskE+BBQlCrNbB+mgzS+e tU38tD4nlBH/XR7vSI489FFWXkz5YxlJohPhQgrGrIlA5rmn+yZAEsTRloOgk997T0PS /9RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U5L2GPc+ohnMZ9sg+8AfGBnFcINnac8K9szCBkK4a2c=; b=XgYKZIA93uIywlWgSj8dL0yPeKZQpslMU4cUWGGqSCTAP890eOihhwZ2ZmPTUgD2R9 FeV3zZhOJ8SArc8vjGjHHenr4oPpXxfa/MGUMtZHMqCLMOK+vSyU80NHvzgrFKaDljJh YAD0TybzuwUF4i5uQZorkzDGJa9LALgMday2f1z9JSaUzVXUxeHgjEZRyv/C0rC7NWqz YEDsut5GsxcVZIhWqDcXsAtUusaC67Z3gnpMc0oq5kiSmne3mhoJwWTet1p9k69C7O9u C89WSuKPeg2peLSB9Mjoe32AaJdoTcJxAAv0cZB7tNXgfw6catQ/FEUcfyE0ttSxQpxE FLXQ== X-Gm-Message-State: AOAM53332ekXFvVhJ8tHNgCXFp7f5xVyMqsJMZPg0rt+3pJwnJsMD0oA lFTHX1mjAhW7He/kW9Dn3Dk/tVaC5o0= X-Google-Smtp-Source: ABdhPJyPLaYuvsYFtuoJC0+0ZV78upZXy5ZK7d5KmnVZi9VN29nFlzgfo47U/qwlObdOkHGvKFs+0A== X-Received: by 2002:a7b:c745:: with SMTP id w5mr1255538wmk.17.1630720237660; Fri, 03 Sep 2021 18:50:37 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j18sm796536wrd.56.2021.09.03.18.50.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 18:50:37 -0700 (PDT) In-Reply-To: <87o89aaxhj.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213376 Archived-At: On 03.09.2021 11:12, Juri Linkov wrote: >>> - (vc-git-command nil 0 nil "fetch") >>> + (vc-git-command nil 0 nil "fetch" (unless (string= remote-location "") >>> + remote-location)) >> >> I'm not sure which scenario this fixes (pressing RET after 'C-u C-x v I' >> works fine here), but it shouldn't hurt either. > > It fixes the scenario with a non-default remote. Could you try 'C-u C-x v I' > and typing the name of a non-default remote in a repo with two remotes? > I wonder if it already worked, and maybe I have some misconfiguration. Ah, I see what you are referring to. But does the feature work then? With your patch, I can pass some alternative upstream to the command, and it fails at the end with something like: fatal: ambiguous argument 'HEAD..upstream': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' >> So if you have a stable repro (some alternative completing-read-function?), >> you can go ahead and install. > > Regarding the default completing-read-function, the prompt of 'C-u C-x v I' > doesn't provide completion on remote names. Maybe this should be improved > as well. I guess some new backend action ('remote-locations'?) could help with that.