From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#60854: [PATCH] Make warnings show a "warning" emoji instead of a stop-sign Date: Fri, 31 Mar 2023 11:10:25 +0300 Message-ID: <63e35a46b8ea9bbac0fed0fe8e97b06a47b9b563.camel@yandex.ru> References: <20230211084559.516124-1-Hi-Angel@yandex.ru> <83h6vsjxpe.fsf@gnu.org> <1214753ab8b9b72bb2dbbeb4113e67ab0b088167.camel@yandex.ru> <9f05f1a05b9d8f1a496aed84bf44b039ac7bb662.camel@yandex.ru> <83355l4g7w.fsf@gnu.org> <7378ade3da2c8965c410b4135db74736d42cd4b2.camel@yandex.ru> <83pm8p2yej.fsf@gnu.org> <83h6u12w4u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20868"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.46.4 Cc: 60854@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 31 10:11:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pi9qs-0005G9-8w for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Mar 2023 10:11:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pi9qh-0007nc-W1; Fri, 31 Mar 2023 04:11:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pi9qg-0007nE-0V for bug-gnu-emacs@gnu.org; Fri, 31 Mar 2023 04:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pi9qf-0005LR-Oi for bug-gnu-emacs@gnu.org; Fri, 31 Mar 2023 04:11:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pi9qf-0005hC-Kd for bug-gnu-emacs@gnu.org; Fri, 31 Mar 2023 04:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Mar 2023 08:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60854-submit@debbugs.gnu.org id=B60854.168025023121859 (code B ref 60854); Fri, 31 Mar 2023 08:11:01 +0000 Original-Received: (at 60854) by debbugs.gnu.org; 31 Mar 2023 08:10:31 +0000 Original-Received: from localhost ([127.0.0.1]:60321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pi9qB-0005gU-Dp for submit@debbugs.gnu.org; Fri, 31 Mar 2023 04:10:31 -0400 Original-Received: from forward502b.mail.yandex.net ([178.154.239.146]:48694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pi9q8-0005gK-MB for 60854@debbugs.gnu.org; Fri, 31 Mar 2023 04:10:30 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-57.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-57.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:2fa6:0:640:9857:0]) by forward502b.mail.yandex.net (Yandex) with ESMTP id 7DB8F5EE13; Fri, 31 Mar 2023 11:10:26 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-57.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id PAFhswADZOs0-oMm3Hkdg; Fri, 31 Mar 2023 11:10:26 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1680250226; bh=t164H+Epjz01vdRCUN3SHdgVYh3S1JL9ONBb1cZa6dk=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=u6b2PHOMNKwpw2I+hU0TyWJsjyIPVdHLYi/fiAIynpq6EZiygDwfqacUE0NRxwVDD 2X/rSP4jpilfLrptv81u/xeURgJZn23hqULH6oGLSgN0sb19CzjPBbISzk8w3EmAZW 33PYG/B4KGi7cCogJElcXN80kPjBRcb6VH6ARonw= Authentication-Results: mail-nwsmtp-smtp-production-main-57.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru In-Reply-To: <83h6u12w4u.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258986 Archived-At: On Fri, 2023-03-31 at 10:54 +0300, Eli Zaretskii wrote: > > From: Konstantin Kharlamov > > Cc: 60854@debbugs.gnu.org > > Date: Fri, 31 Mar 2023 10:48:12 +0300 > >=20 > > FWIW, I co-maintain a color-identifiers mode on github, and I have > > occasionally > > introduced new native-comp warnings (about a variable being referred in= a > > function before its `defvar`). This happens because you debug and test = ELisp > > code without it being compiled at all. Then later after everything seem= s to > > work, you test that byte-compilation produces no warnings. But at that = point > > you > > don't know there isn't any warnings from native-comp, so you also need = to > > load > > the byte-compiled file, which is easy to forget. >=20 > Better testing should fix these. Sure. Setting up a CI to run upon PRs before they're merged would be ideal.= But I don't believe people will start doing that just because there is native-c= omp now. > > That, and given that some modes in (M)Elpa may be unmaintained =E2=80= =94 I don't see > > native-comp warnings go away any time soon. >=20 > Well, they went away in Emacs a long time ago.=C2=A0 So it's doable. Last I checked Emacs was maintained =F0=9F=98=84 For unmaintained modes the= re will be simply no one to merge fixes that someone creates. > > Simply changing emoji would still show interested users there is a prob= lem > > with > > their mode that they can fix, but at the same time would avoid attribut= ing > > negative experience to Emacs per se. >=20 > Feel free to suggest defcustoms to allow users to customize the > symbols.=C2=A0 That should leave everyone happy. The problem is about OOTB behaviour. (although now that I think about that,= Doom Emacs which seems quite popular could maybe replace the emoji in their conf= ig. Hmm=E2=80=A6) > In any case, it's too late to suggest such changes for the emacs-29 > branch. I see. Oh, well=E2=80=A6