From: "Harald Jörg" <haj@posteo.de>
To: emacs-devel@gnu.org
Subject: cperl-mode: Eliminating references to obsolete packages
Date: Wed, 23 Sep 2020 20:37:27 +0200 [thread overview]
Message-ID: <63ad78b2-ec6b-8215-e775-db5889f4f94e@posteo.de> (raw)
Hello Emacs,
My history with Emacs development is rather short, so I'd like to
check some assumptions. cperl-mode.el has quite some conditionals
checking for features of which I assume that they are now either
completely dead, or always available:
- (featurep 'choose-color): choose-color.el used to be downloadable
from Ilya Zakharevich's web page in the 20th century, but it is
gone now. I suggest it is safe to assume the value is always nil.
- (featurep 'font-lock-extra): I failed to find any reference where
this came from and suggest also to assume the value is always nil.
- (featurep 'mode-compile): It seems that mode-compile.el was never
part of GNU Emacs, and it seems to be abandoned by now. I suggest
it should be eliminated.
- (boundp 'font-lock-constant-face): - also for other faces. I guess
it is safe to assume this is always true, and the current list of
available faces as visible in the info page "Faces for Font Lock"
hasn't changed (much) since Emacs 26. I'd be grateful for a
pointer to recent changes in this face list!
I'd like to prepare a patch which removes all conditionals querying
these functions, the associate code branches, and related
customization variables. But before I do so, I'd like to check with
people who have been contributing to Emacs longer than I have.
Are there any opinions or objections?
--
Cheers,
haj
next reply other threads:[~2020-09-23 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 18:37 Harald Jörg [this message]
2020-09-23 19:16 ` cperl-mode: Eliminating references to obsolete packages Stefan Monnier
2020-09-23 19:38 ` Harald Jörg
2020-09-23 19:50 ` Stefan Monnier
2020-09-24 15:34 ` Harald Jörg
2020-09-24 17:09 ` Stefan Monnier
2020-09-24 18:43 ` Harald Jörg
2020-09-24 22:20 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ad78b2-ec6b-8215-e775-db5889f4f94e@posteo.de \
--to=haj@posteo.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.