From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.bugs Subject: bug#70086: Mouse clicks in tab-bar don't call commands bound in keymap properties Date: Sun, 31 Mar 2024 11:15:06 -0500 Message-ID: <6393275a-0009-46f0-9eff-c1149c2e0ee4@alphapapa.net> References: <948ee96f-52d5-4cd5-be84-70368cff214f@alphapapa.net> <86ttknd3kd.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38811"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 70086@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 31 18:16:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqxr5-0009uD-P1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Mar 2024 18:16:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqxqk-0003dK-I5; Sun, 31 Mar 2024 12:16:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqxqj-0003d2-0y for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2024 12:16:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rqxqi-0001lA-Iy for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2024 12:16:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rqxqk-0002W4-Dq for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2024 12:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Adam Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Mar 2024 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70086 X-GNU-PR-Package: emacs Original-Received: via spool by 70086-submit@debbugs.gnu.org id=B70086.17119017159506 (code B ref 70086); Sun, 31 Mar 2024 16:16:02 +0000 Original-Received: (at 70086) by debbugs.gnu.org; 31 Mar 2024 16:15:15 +0000 Original-Received: from localhost ([127.0.0.1]:48302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqxpy-0002TG-LH for submit@debbugs.gnu.org; Sun, 31 Mar 2024 12:15:14 -0400 Original-Received: from antelope.elm.relay.mailchannels.net ([23.83.212.4]:14787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqxpw-0002T4-9G for 70086@debbugs.gnu.org; Sun, 31 Mar 2024 12:15:13 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4529B760411; Sun, 31 Mar 2024 16:15:08 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a291.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D0DF57618AB; Sun, 31 Mar 2024 16:15:07 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1711901707; a=rsa-sha256; cv=none; b=ZjTEw53YfKhoKv+ACSvjRIJ75xfFAJFpdJgBOR02m2wcnJQSsK+/Ql0+369ELjBw51wP0q +YoGXv1P1d+jrwwoJEHG8L4lHnh02+vTaeidnYzHj+h3yC99GR1Y3XBMnDwoM/YxaH0gHY 6axUjZJ1LIWoGU1W2f9KWoHjtwIOY4gmcfVgxuv7cuJ+hhZ0d5dd8le5I+hXonza+a8pVr LA55CFzw9QKBStE0DaP6U54nfOSfnxGv4Jx6QdN4SaRzHlKkWLRZsGFlpNOWl0i2PJIgK8 MIuEN+zJQOBPqX/euZ7KArFUxvHMpvDJ473bMsrdrRTyJRA5S3J/lYxPc6480g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1711901707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=llCWkjqCLpE4uUcPrXtIx0vnc/tabjed1K5OpPOrkyE=; b=sgiXAxcgrnlorThGe04CcxWtHGBwg1s6dZv6TzPngnfRi0Vxpg8UiclBjjnwCelDcAWFg8 ssHYqCmH0qTwyAkrvoUn8yN7R87znqnSCzI1XuN/gi6ZQGF/+on8WSpDmGlnYATCtIC76/ IV+PHV0VAVIohoCSiZ5ykv8vRWdBumDVnwAJqoN3jiyQdJXV9fFvUJiWMmEAAEQEZ/D95r mw0kKEP1dLNFZGMybgzsY4rdovTXnLUKkt0Yg6YTYHXHlqHS/0o/SmPsiZO8BIrWf1Lx5h cJuTqANj1PjWQpClDjbvy0KLRTiO2vQdthvN4FSjEN/7ZLSDfSDV7Rk3OlzHgA== ARC-Authentication-Results: i=1; rspamd-699949c56f-24fdp; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Harmony-Spot: 7753475c4739aa42_1711901708081_1654637294 X-MC-Loop-Signature: 1711901708081:2691692904 X-MC-Ingress-Time: 1711901708080 Original-Received: from pdx1-sub0-mail-a291.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.112.72.244 (trex/6.9.2); Sun, 31 Mar 2024 16:15:08 +0000 Original-Received: from [10.43.1.194] (unknown [193.56.116.15]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a291.dreamhost.com (Postfix) with ESMTPSA id 4V6zkg2rxszJF; Sun, 31 Mar 2024 09:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1711901707; bh=llCWkjqCLpE4uUcPrXtIx0vnc/tabjed1K5OpPOrkyE=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=DvSL4FhoRpbMKSSSZvlZr6S5FHMSWV6Zz++RuCih8gzpOmJFxGJHztg/m6AufWfLJ 01L2hsRqgMYxE4/nWz6TECY1YYu1a+jS9QLMjv8OCFGQq5Zu+pyKnxZsfz+Mi32R4B Oa+vH5XD6PKuaiIMCxFFUYX9x5s8KinJdzoFekzmvsToAHthr5gV+Sb7Zr/DKK82KF Ht4YIQ7QUgQfcf6MCqGuGcHUok+ywRlLwcdSH1M8MJ/AdJPttlUOdpHwA9O+dKHPy5 Y8qM90LTv7/erBhgBvY2GLckRgORpNuXdCIVrUb9wCZMHg2vSZBYsQJIrHLk5D0K4y Abjbn1KXdp93g== Content-Language: en-US In-Reply-To: <86ttknd3kd.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282443 Archived-At: Hi Juri, On 3/30/24 13:16, Juri Linkov wrote: >> In my listen.el package on GNU ELPA, I'm trying to make mouse clicks in the >> `global-mode-string' construct work when `mode-line-misc-info' is shown in >> the tab-bar by including `tab-bar-format-global' in `tab-bar-format'. I'm >> including this construct in the `global-mode-string': >> >> >> `(listen-mode (:propertize listen-mode-lighter >> keymap ,listen-mode-lighter-map)) > > Thanks for the request. If possible could you send a minimal test case > to see what exactly do you need. Sure, the following code in a clean Emacs config seems to demonstrate the problem: (require 'cl-lib) (defvar tab-bar-ecm-keymap (let ((map (make-sparse-keymap))) (define-key map [tab-bar mouse-1] (lambda (&rest _) (interactive) (message "tab-bar-ecm-lighter clicked with mouse-1"))) map)) (defvar tab-bar-ecm-lighter "TAB-BAR-ECM-LIGHTER") (define-minor-mode tab-bar-ecm-mode "DOCSTRING" :global t (let ((lighter `(tab-bar-ecm-mode (:propertize tab-bar-ecm-lighter keymap ,tab-bar-ecm-keymap)))) (if tab-bar-ecm-mode (progn (cl-pushnew lighter global-mode-string :test #'equal) (unless (memq 'tab-bar-format-global tab-bar-format) (cl-callf append tab-bar-format '(tab-bar-format-global)))) (cl-callf2 remove lighter global-mode-string)))) Evaluate that code and then enable `tab-bar-mode' and `tab-bar-ecm-mode'. Then you can see that "C-h k" followed by a click on the "TAB-BAR-ECM-LIGHTER" text in the tab-bar shows that the anonymous command is bound to that sequence, yet clicking the text doesn't call it. > And the same should work on `tab-line-format' as well. I haven't tried that, but sure, sounds good to me. :) > Indeed, events on the tab-bar have a different design where > `tab-bar--event-to-item' should be used to get a bound command. > You can see an example in `tab-bar-mouse-down-1' that uses > (if (functionp (nth 1 item)) (call-interactively (nth 1 item)) > to call an arbitrary command. I see, thanks. --Adam