From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#60423: 29.0.60; goto-address and shr/textsec don't play nicely together Date: Wed, 16 Oct 2024 14:45:39 -0700 Message-ID: <63831.1729115139@alto.camomileplus.org> References: <175894.1672372745@alto> <831qoh6j0i.fsf@gnu.org> <69964.1728432546@alto.camomileplus.org> <86jzeh4g7x.fsf@gnu.org> <51018.1728603976@alto.camomileplus.org> <86zfnbyywr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22725"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60423@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 16 23:47:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t1BrB-0005ky-1B for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Oct 2024 23:47:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1Bqw-0002Ob-5l; Wed, 16 Oct 2024 17:46:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1Bqt-0002OS-RZ for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 17:46:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1Bqt-0003y0-It for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 17:46:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:From:References:In-reply-to:To:Subject; bh=9z9oFMyRJAQt8KXDKAPXKJs9FbAParWYcaPZ62Jlrc0=; b=T+YsYccnknRfk1G0Wxi7qtsXNO5+jDhEhOdDQoOJquLlKaNU5RYBVRbwCu2TrA5jLDkLw2uYeARNcBugsRAl+rUfzsRZDo8fHQCHdKs6SznrZv2si/DBLk3lQj/QFJA6NlteaU6nzLXNIiYJFpNwfkjj1ZM0opsE4ivFV2fROkJ+iM3Z/vtGrDXCS4fDfPQoCruJ30MA+M5dF8xBbSO0pbmluWXLEUoAB0M34IuHgwpX7gy+y5WhAJZrB2+wjecW9H0+07Q5/wlvJXvCfS5VeyNm+G5/EBvQV4Jxr6s3enjm514lKuq/7kiQIuoV99vhmzZ0UH5Zg6Mu21fDMEQNPg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1BrC-0007At-Ir for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 17:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2024 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60423 X-GNU-PR-Package: emacs Original-Received: via spool by 60423-submit@debbugs.gnu.org id=B60423.172911516927497 (code B ref 60423); Wed, 16 Oct 2024 21:47:02 +0000 Original-Received: (at 60423) by debbugs.gnu.org; 16 Oct 2024 21:46:09 +0000 Original-Received: from localhost ([127.0.0.1]:60732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1BqK-00079Q-N7 for submit@debbugs.gnu.org; Wed, 16 Oct 2024 17:46:09 -0400 Original-Received: from shell1.rawbw.com ([198.144.192.42]:29541 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1BqJ-00079H-6k for 60423@debbugs.gnu.org; Wed, 16 Oct 2024 17:46:07 -0400 Original-Received: from alto.camomileplus.org (135-180-174-211.dsl.dynamic.sonic.net [135.180.174.211] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 49GLjdr1015547 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 16 Oct 2024 14:45:45 -0700 (PDT) (envelope-from kupfer@rawbw.com) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-211.dsl.dynamic.sonic.net [135.180.174.211] (may be forged) claimed to be alto.camomileplus.org In-reply-to: <86zfnbyywr.fsf@gnu.org> Comments: In-reply-to Eli Zaretskii message dated "Fri, 11 Oct 2024 08:46:44 +0300." X-Mailer: MH-E 8.6+git; nmh 1.8-RC2; Emacs 30.0.91 Content-ID: <63830.1729115139.1@alto.camomileplus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293692 Archived-At: Eli Zaretskii wrote: > AFAIU from your analysis of the problem, it happens because the same > text is covered by both a text property and an overlay with the same > property. If that is indeed the reason, then the only conflict that I > could see in this situation is for the 'face' property: both shr-tag-a > and goto-address use it, one as a text property and the other as an > overlay property. The other properties you mention aren't used by > goto-address, so they cannot conflict with what shr-tag-a. Am I > missing something? Yes, goto-address also sets the 'help-echo' and 'mouse-face' properties, though the latter is only set for email addresses. (Sorry, I didn't call this out in my earlier email.) > Testing unrelated properties might give us false positives, so I think > we should avoid that. Agreed about trying to avoid false positives. The complete list of overlay properties that goto-address-fontify sets is - evaporate - face - follow-link - goto-address - help-echo - keymap - mouse-face We agree about checking for 'face'. I'm still holding out for checking for 'help-echo' and 'mouse-face'. After reviewing the documentation for the other properties, I'd also like to check for 'keymap' and 'follow-link'. I don't see a reason to check for 'evaporate'. 'goto-address' is not documented and appears to be used to mark the overlay as belonging to goto-address, so no need to check for it. mike