From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Should (buffer-list) ever return killed buffers? Date: Mon, 24 May 2021 16:50:48 +0200 Message-ID: <6381ce45-24d5-90f7-c490-7006460f7f43@gmx.at> References: <87wnrpujo0.fsf@osv.gnss.ru> <871r9w5jws.fsf_-_@osv.gnss.ru> <83a6okdx60.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35572"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii , Sergey Organov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 16:51:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llBvp-00094i-HL for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 16:51:49 +0200 Original-Received: from localhost ([::1]:59450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llBvo-00054v-Kh for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 10:51:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llBv0-0003wc-UB for emacs-devel@gnu.org; Mon, 24 May 2021 10:50:58 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:33911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llBuy-0000W8-QR; Mon, 24 May 2021 10:50:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1621867851; bh=/21iGcpEFUF31s+uUxu3ZiCiiIBzYVQZZYZCVtC0wtw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Z4tJPaYsSqRFVhEZQKIUmvn0AwcD2d/Bsbk4pGcklufs2EdRd09fNW4wC+BCw0Yaq zjZoQf2M27LY+FKk5g0F2uVS0l1dJh8Rnm0ZceGRjMwMRZ5sFKzJxB/A/wi8nYR05e zoPXyEmcEwl1V9A3evDDTV9/K/97HEsRiG0U0uQA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.177]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MlNtP-1l1dMl2gnt-00lqS3; Mon, 24 May 2021 16:50:50 +0200 In-Reply-To: <83a6okdx60.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:DmzmK7n3vMCshwW1cQGxWBYn/eN/u7BZ5Ny6J6kiRnR1owKUgaz VCmomVI/lsf2jJ6i5hMZJfDkd2Hu0aH7sVmKHbcylmkUT2yUuPV6iZwEI3Nb0yx+91qCVs8 2gHL3ntLHeG7M+6z1KPZNXsoJUdu4/kfB1s053PSw6o6K/o3oFctKEv5QfbtBvyfMCnrz0H Ij5GsPjSnCb3DlM6lHaGg== X-UI-Out-Filterresults: notjunk:1;V03:K0:nCBH0tYPlxs=:dfNmTcPCpMPCzkJCzjk42L RNsK9jBSVq89ltYTy5NGBNJ/MBV1qMkazxJvn0teZDE154NO/8uT754Ba8DP1mQX29wNPMWWT v6PhlLRxPPWNoWTNqtOv79tPq++smaSFs33JvdpkRfeeXWkRdT0OkOE06NCmbOQsr1CcXPxvj jG+NAdZ3kCeIVN3bTDUxdd3gnKiTuFbKthlkyPbFvniZfL3S/d/W86v2v2zb/zkhm1QQdSTLQ jEnVtAekyCaUVSwFSXVTJjX+iYvr2XrhiQBx9ZsOGTUfUzQD5BO1rt/VmA8sysTqO9/vgLdyD o28xJZuGVwZLI/YWPeoE2GCbay2/GYBRKGCB9lxB61zb7mXSDYBAk3LVy18wPQiKhGt5Zm7mM Wnx9REeVVnJd8qvFlbmmFdVg2BhfVpY3WgM1Zr2rzXRPkIabv+ZSJXddaCkHucRIzbVqMgHwh SvHFN4LhQm2TJcSDml/dYfNPI9ab0yiJCCbzaFH01JMWYUugbbD9q6U84lx+MB+75pi8AixYK 0F/AmJHr9DV8ETEIOKsNzToFfkGhPH08sBgTZ5u6AEp5qvM+nVXjH1aafitiCW0QnGDNhhp8O g8EWjsUiVt5OMIUapeMAyk8vJ57EMhRbqOHARngvEP0zauDszE95mljafH+HIsSJGBWtRtepO A/eCghIjeshOc5cv7uOUOaK73gfLhxnQzzkU4d4e7yfo7tIpFRStFrTWyct2TBY+0ejcLCiL7 LShteXKcnTcivZXkXi7Ra7jwoVF4VqRtDQlWFQa7w9hHqGC/2pfuFKlXKpgCtvurpjHXQdEM Received-SPF: pass client-ip=212.227.15.15; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269762 Archived-At: >> + (unless (or (nill bufname) >> + (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers >> (string-match-p preserve-regexp bufname)) >> (kill-buffer buffer))))) >> (delete-other-windows) > > AFAICT, kill-buffer already is a no-op when the buffer is dead. So > what exactly does this fix? (Apologies if I'm missing something: I > cannot say that I've read all the discussions in this thread to the > last detail.) Sergey never told us but it's likely `aref' choking on nil. martin