region-active-p et al

region-active-p et al

[Andreas Röhler]

Happy new year!

Got a bug-report at 
https://gitlab.com/python-mode-devs/python-mode/issues/27 which points 
me at a quirk in region-active-p:

Questioning transient-mark-mode does not belong here. It's a 
user/convenience thing whilst
region-active-p is a core thing.

A work-around in python-mode.el would ask (and (mark) (not (eq (mark) 
(point)))) instead of
region-active-p resp. use-region-p.

Cheers,

Andreas

Re: region-active-p et al

[Eli Zaretskii]

> From: Andreas Röhler <andreas.roehler@online.de>
> Date: Mon, 2 Jan 2017 12:50:35 +0100
> 
> Happy new year!

And the same to you.

> Got a bug-report at 
> https://gitlab.com/python-mode-devs/python-mode/issues/27 which points 
> me at a quirk in region-active-p:
> 
> Questioning transient-mark-mode does not belong here. It's a 
> user/convenience thing whilst
> region-active-p is a core thing.

Actually, both region-active-p and use-region-p are explicitly
documented to pay attention to transient-mark-mode.  These two
functions exist to allow applications to change their behavior when an
active region (not just any region) exists.

If python-mode wants to act on region regardless of
transient-mark-mode, it should look at the mark, and not use these two
functions.  They are not meant for that use case.