From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#1305: All code that currently beeps should use visual bell instead Date: Wed, 21 Apr 2021 17:45:38 +0300 Message-ID: <62fee2e3-8ae2-cbc9-9681-4d7f0fe680c0@yandex.ru> References: <87blabpy54.fsf@gnus.org> <87lf9eo3mq.fsf@gnus.org> <0d7924a2-d09f-e2d0-f0e7-6b5ee3a7a7f2@yandex.ru> <192e82f20f5deb690394@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28006"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 Cc: Alan Third , 1305@debbugs.gnu.org, Michael Welsh Duggan , Stefan Kangas , jasonspiro4@gmail.com, monnier@iro.umontreal.ca, Lars Ingebrigtsen To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 21 16:46:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZE7R-00079Y-Ms for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 16:46:21 +0200 Original-Received: from localhost ([::1]:41068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZE7Q-00005t-PY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 10:46:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZE79-00005j-93 for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:46:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZE78-0000bT-LY for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZE78-0003LM-Ha for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Apr 2021 14:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1305 X-GNU-PR-Package: emacs Original-Received: via spool by 1305-submit@debbugs.gnu.org id=B1305.161901635812833 (code B ref 1305); Wed, 21 Apr 2021 14:46:02 +0000 Original-Received: (at 1305) by debbugs.gnu.org; 21 Apr 2021 14:45:58 +0000 Original-Received: from localhost ([127.0.0.1]:59370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZE70-0003Kq-6V for submit@debbugs.gnu.org; Wed, 21 Apr 2021 10:45:58 -0400 Original-Received: from mail-ej1-f54.google.com ([209.85.218.54]:44559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZE6u-0003KX-1F for 1305@debbugs.gnu.org; Wed, 21 Apr 2021 10:45:52 -0400 Original-Received: by mail-ej1-f54.google.com with SMTP id r20so14131678ejo.11 for <1305@debbugs.gnu.org>; Wed, 21 Apr 2021 07:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7HQkg7HCe6d5p+ux8ui0AjStEiJCJ51P6CfqMry4L4s=; b=uh8fi4oUgsNZZ5iXkiSdvRNCqw6Ky8I2Up/DUH04acIKjYTSWj2RI+ZyYf98qCEiR8 YsdxTqfG1ziekPGHCk1zur3QZuGSHUsFzyAkKGd17RjZEOVxBaNNrwQpGOaRZktyf5Ru NDb7qbk0Z4N/2QzpfZX0/F/zbBX/DZLSAIcbj1/rGzjTbuOcHdBibKe0Aaa8R9+CtDN4 Y/kTqREsVhGWK9YRLfq77k6s+cNP6yBvk/YvfU9IRQKMB9UWSrdEaIewxHWy8s8TjIGS IAoLC2wSLghfGsFzC7DIOUIAtWodd+X9OBMK+8byvcPBhkY5z32scH5SNk0DsMEwRY8f BwqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7HQkg7HCe6d5p+ux8ui0AjStEiJCJ51P6CfqMry4L4s=; b=hZFwTN36amL0S4qYvwPUE7nyQ30g5ED90LoHYXtXZkAX8O0dyeFH6vlRq2Nbdv22fz B2PyaB35ApVWxhA0X66DSy/SjfejPZ5dkv/F6oQwXrtV4XxvwcoAkX7Hv/QEMSvQ/oSd iA/sBRlJTlLvdSp9P8a8zq34cHkL5ZjclEkWJz4MgCcKRTBmFUdQUnZw7KwHIxHgJFN6 U0/aG43JvVNwqWPtW5/GY3Ypxw5QWTsHO6ePLhY5d6uCC2CCSnEpM10q1fQIWFAh+Hh4 JjIsCecNQS3WhL+hGOTS6IiCDFPf2BlSrtbIvDQdb84CHPNgDBvrVjkan9Woa89QMJuo UraQ== X-Gm-Message-State: AOAM5339cRBT3fqxVXr72PfUKhEq6iZztBXqzfZL2/nx+KB8Uf9q6H9x 07yx/vvagKb3SlrPedCzpTc= X-Google-Smtp-Source: ABdhPJz0qJZgbZVBE5OOrnvlnEArRjTA+CMH8145leowOB2udRmN8OcSq8q9lTLu6kMRqvLz5jxxbg== X-Received: by 2002:a17:906:cb88:: with SMTP id mf8mr33867526ejb.541.1619016341123; Wed, 21 Apr 2021 07:45:41 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id mj7sm2627379ejb.39.2021.04.21.07.45.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Apr 2021 07:45:40 -0700 (PDT) In-Reply-To: <192e82f20f5deb690394@heytings.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204622 Archived-At: On 21.04.2021 09:47, Gregory Heytings wrote: > >>>> And it turns the cursor red irreversibly in my config (but not in >>>> 'emacs -Q'). >>> >>> That's rather strange, color-bell--cursor-background is saved only >>> once, when visual-bell is called for the first time.  I'll try to >>> reproduce the issue, but some more detailed information (e.g. with >>> debug-on-variable-change) would be welcome. >> >> I'll try bisecting when I have the time. In any case, it's just an >> implementation bug, not a blocker. >> > > Does the attached patch fix the problem in your config?  It is probably > safer to check the cursor color each time color-bell is entered. It does not, sorry. Anyway, speaking about other faces you could inherit from (for the echo area flash), how about 'highlight' instead of 'match'? Seems more appropriate. >>>> Is nobody bothered by having this kind of visual indication while >>>> 'visible-bell' is nil, though? >>> >>> It's easy to turn off, as indicated in NEWS: (setq ring-bell-function >>> nil). >> >> I mean, like, semantically: this new proposal is also visual/visible. >> >> But 'visible-bell' is nil. >> > > Yes, it's perhaps a bit unfortunate that "visible-bell" is nil in this > case, but note that with visible-bell t and ring-bell-function ignore > you also do not have what you could expect.  The semantics of > visible-bell and ring-bell-function are a bit unclear, but they cannot > be fixed anymore without introducing backward incompatible changes. Perhaps a good idea would be introduce a visible-bell-function. But that's hard to do without overriding current customizations, as you described. > I understand that you're accustomed to what visible-bell t does on > GNU/Linux, but frankly, its ugly.  Ask their opinion to non-Emacs users > about that bell, I'd be surprised if they like it. Do we have anything to compare to in other editors, BTW? Ones that non-Emacs users employ and could consider preferable.