From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' Date: Thu, 7 Jul 2016 02:34:48 +0000 (UTC) Message-ID: <62e491fa-9863-47d6-8954-26b6368185f9@default> References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> <87poqyi05f.fsf@gmail.com> <126bba1e-3f86-4ae3-b7b5-59532f62e4f6@default> <87bn2acmye.fsf@users.sourceforge.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1467858928 25277 80.91.229.3 (7 Jul 2016 02:35:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Jul 2016 02:35:28 +0000 (UTC) Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 07 04:35:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bKz9n-0008B9-0k for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jul 2016 04:35:15 +0200 Original-Received: from localhost ([::1]:37066 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKz9m-0003k1-2O for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Jul 2016 22:35:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKz9e-0003h3-HN for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 22:35:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKz9a-0007ah-AC for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 22:35:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKz9a-0007ac-6n for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 22:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bKz9Z-0002hf-Qc for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 22:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jul 2016 02:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo notabug Original-Received: via spool by 19362-submit@debbugs.gnu.org id=B19362.146785890010381 (code B ref 19362); Thu, 07 Jul 2016 02:35:01 +0000 Original-Received: (at 19362) by debbugs.gnu.org; 7 Jul 2016 02:35:00 +0000 Original-Received: from localhost ([127.0.0.1]:40081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKz9Y-0002hN-9r for submit@debbugs.gnu.org; Wed, 06 Jul 2016 22:35:00 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:33047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKz9W-0002hA-Sh for 19362@debbugs.gnu.org; Wed, 06 Jul 2016 22:34:59 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u672YoWi018747 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Jul 2016 02:34:51 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u672YoxJ015650 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Jul 2016 02:34:50 GMT Original-Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u672Ym3h017193; Thu, 7 Jul 2016 02:34:49 GMT In-Reply-To: <87bn2acmye.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120550 Archived-At: > Well, we could have all saved some time if you had taken your own advice > to diff the code; not pp.el vs elisp-mode.el, but emacs-24.5's > lisp-mode.el vs the new elisp-mode.el. You can see in the attached diff > (exerpted to leave only the relevant functions) that the only changes > are renaming of functions, and some minor refactoring in > elisp--preceding-sexp (it now handles =E2=80=98foo=E2=80=99 as well as `f= oo'). I never suggested diffing pp.el against either lisp-mode.el or elisp-mode.el. And actually I did compare lisp-mode.el with elisp-mode.el and different versions of lisp-mode.el. I said this, which I maintain: > Yes, well, it's quite difficult. Some of the code from lisp-mode.el > was moved to elisp-mode.el. And then it was modified, in some cases > radically. Dunno why, except that some of the changes seem to have > involved integrating eldoc. But most of the changes presumably do not > concern this bug, which is only about the part of lisp-mode.el that > had functions that correspond to pp.el functions.) It should be clear that wrt what I was following (and comparing) of the evolution, what I saw was not just renaming of functions and minor refactoring. But of course I was also trying to see how the changes compared to the pp.el code - what corresponding changes might be in order for pp.el. That was, uh, the point of the report. Whatever. Thanks for taking a look anyway. Sorry that you apparently wasted your time.