From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Thu, 5 Mar 2020 16:03:37 +0200 Message-ID: <62da5d4c-2db8-864e-0d08-ed751ff82c0b@yandex.ru> References: <288610218.111246.1578330546916@office.mailbox.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="52883"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 05 15:04:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9r6j-000DcT-0Y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 15:04:13 +0100 Original-Received: from localhost ([::1]:49720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9r6h-0005dP-Vg for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 09:04:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58456) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9r6a-0005dC-3C for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 09:04:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9r6Z-0007uM-1E for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 09:04:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36405) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9r6X-0007sz-Tn for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 09:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9r6X-00045j-PU for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 09:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 14:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158341703715714 (code B ref 38992); Thu, 05 Mar 2020 14:04:01 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 14:03:57 +0000 Original-Received: from localhost ([127.0.0.1]:42378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9r6S-00045O-TA for submit@debbugs.gnu.org; Thu, 05 Mar 2020 09:03:57 -0500 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:51940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9r6Q-00045B-Ok for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 09:03:55 -0500 Original-Received: by mail-wm1-f45.google.com with SMTP id a132so6453687wme.1 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 06:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6UEnx2JzXfGy7OlrU/5R98Dze3jagNLwpJ+1PUy5mts=; b=cTI5LHGqYoRcE2TFehgvZGNRO6iw4w0vh5m6VO1vLsTG1DFoFdyxQWUngvfirxhHWj xF0daeidq69r00bG5FDK6yvp3vCHtKjgDJs2HuAstBXDIdXP1b1jmnErpK0l4EwDdJ37 jL/ki/of1WZFaiXOniGV61qRh3Qe0wwpz6AANcFhkHwYXZeuGD8l0rPgqdVfIDBCkkD5 /6CGkeCphkzxix+vHB3jJTlmG3oXiqc2oRcELMQiqfHJxWe89r/x6dOOW8gbZLrHWvaK WSHcwO876Ro6qTHE17JsAylzRxxGE6cafvKoUyYZ90BOq3jdvjokDRQUAM6mNgKRfUww YMzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6UEnx2JzXfGy7OlrU/5R98Dze3jagNLwpJ+1PUy5mts=; b=E+x6AB7zqZ1/eFSryofDt2zadpWdipuw7YeHk7CAbcsojVOkNJkPfGpomFa1hqBICU J5cD2IzjJcJQRzrcEDNJwgFlt3NfeYk0IG1v0dmFlNkDXIp+hF6P85eghYHn7Pw9PDqp wsbTe/c1HduuwnLp1GZ9lb/5oHFGN6dAoaURRLfg1O+VnctWNBVnkCpel75aZsr8ymOl mr0Tvor/b9fh5evwtSxbVityoztmZqCSO+k0x8yXxS3kJxSeLb+eAPyfD8Oo7ZtrCQYO WSWDjbQ03zmPJy7FuHh3k7Pg5EUB5V4ltI1LmRutr1FGT+hqtwsJMUcEEKNsGhAmqhJf QDFg== X-Gm-Message-State: ANhLgQ32r4c2+DRJd3YZ8zqV2sDbid6LpH2T3tfBrGRJ1N3Gr+YLkmK/ QMfJo9cCcu3u87x03ScZqK0= X-Google-Smtp-Source: ADFU+vt5DJ81VLCK2uQdQrbsCpxqibIe2zcvpvENUDlZSGuyyHmIYGaFKCeg/sM3eGqFXx5uBA2M7A== X-Received: by 2002:a1c:1d8d:: with SMTP id d135mr9915625wmd.107.1583417028849; Thu, 05 Mar 2020 06:03:48 -0800 (PST) Original-Received: from [192.168.0.155] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id o26sm8926821wmc.33.2020.03.05.06.03.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2020 06:03:47 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176906 Archived-At: On 05.03.2020 15:54, João Távora wrote: > Second: trapped by the UI or not, we are still limited by what values > the program that called completing-read is prepared to handle. > > > Of course.  What I'm saying it that there may be completing-read > that may benefit from an informed exit with something not in the > completion list. Calculating a completion list is fickle and often > it fails by scarceness. OK, fair enough. > I mean... if your idea of an "out" is to give it a "finger-contorting" > binding and a secret password, of course that's unlikely to cause many > problems. > > > Yep, that's my idea. Or a C-u to your icomplete-fido-exit would do just > fine, > too.  Assume "secret password" is you being funny. How about 'M-x exit-minibuffer RET'? :-) If it's indeed a rare situation. > I don't know how (or why) to add instructions to the docstring for > something that we advise against doing, though. What phrasing to > use, etc. > > > Well, I don't advise against it, you do. I just want to give users > a better library. But if you're fine with C-u. I will recuse myself by saying I have no opinion on C-u. > And also, here's a thought: anytime you feel like using > 'exit-minibuffer' to counter the REQUIRE-MATCH=t argument, that should > probably be accompanied by a patch to the caller function to change > that > argument to nil. > > > Sure, time-permitting, of course.  But again, not that the changing of > the argument might _not_ be the fix.  I expect the real fix in those > situations to be about the computation of the allowed completions. > Those are probably more complex fixes. That makes sense, but in general, when the caller fails to enumerate all possibilities, it should set require-match to nil. But it's not so black-or-white, OK.