From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#60953: The :match predicate with large regexp in tree-sitter font-lock seems inefficient Date: Thu, 26 Jan 2023 19:12:05 +0200 Message-ID: <62d8ea72-3cf6-7c1a-4fce-53f5ee435215@yandex.ru> References: <7624dddc-4600-9a03-ac8b-d3c9e0ab618c@yandex.ru> <04729838-b7d4-8a08-2b71-12536a28aebb@yandex.ru> <83wn5ag4nc.fsf@gnu.org> <01b5d074-fb12-6b1f-cbfb-5e759833b854@yandex.ru> <838rhpg57n.fsf@gnu.org> <5026D975-983F-4D18-8690-BE139C92825D@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11448"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 60953@debbugs.gnu.org To: Yuan Fu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 26 18:13:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pL5oV-0002ff-1F for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Jan 2023 18:13:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pL5o8-0007y7-QI; Thu, 26 Jan 2023 12:13:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pL5o7-0007xt-Ai for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2023 12:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pL5o6-0002aB-MO for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2023 12:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pL5o6-0005hU-Hs for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2023 12:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Jan 2023 17:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60953 X-GNU-PR-Package: emacs Original-Received: via spool by 60953-submit@debbugs.gnu.org id=B60953.167475313421850 (code B ref 60953); Thu, 26 Jan 2023 17:13:02 +0000 Original-Received: (at 60953) by debbugs.gnu.org; 26 Jan 2023 17:12:14 +0000 Original-Received: from localhost ([127.0.0.1]:36073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pL5nK-0005gL-94 for submit@debbugs.gnu.org; Thu, 26 Jan 2023 12:12:14 -0500 Original-Received: from mail-ej1-f54.google.com ([209.85.218.54]:37674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pL5nI-0005g8-VP for 60953@debbugs.gnu.org; Thu, 26 Jan 2023 12:12:13 -0500 Original-Received: by mail-ej1-f54.google.com with SMTP id ud5so6900894ejc.4 for <60953@debbugs.gnu.org>; Thu, 26 Jan 2023 09:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=go50RHfZJjwyYHgB6J0z/W4Lq43QyL4Jf2dlZUIrPP0=; b=InAibHfsCrvQfPsVBV/iM2cSZRVLLFyYDYgxl44Q9unbH5GdA91agKf3xxJkE3PEHF LBszO5L5uATU8yMFTjYiK9+N3RXXoNn1ccFvMFoFohyJcygBUHoQ29SgziRmZkvViNwc BrkrO/hO2sKb5kI6xoYcoRjLlAxRQdQwJAMGZwkMtUpnsFYcYk+bEEiLXr5B3NYTswnK Zbg65yISQM9/CmGqIxJF9AbZAYHO7yiFV0+ER+/rnXm2AcLHCGlQB01TuBy+jUQjT3VX Xlz7/iQf8UWF22tJRwGUO1nFdeitJKBnymG3QdjzxvSI/v44GAQibmqHDEunscTSex/J 28Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=go50RHfZJjwyYHgB6J0z/W4Lq43QyL4Jf2dlZUIrPP0=; b=cq1LkNQJ5Ee35FceEf6C5fF9Abj8Iz3q6L54r2YMYBs7UhBh9IDwx/7fyTgRx/l4bU RZvTXqPPoxVuCvTVAnZ3S6ooW/J71YwWor50+m47xU+t6G/lEcUVY2stBDxc67lQ6Yye cN0HHIHOClqdTIytsrXTd0k9hxnTqdd3eOa2eX13ylXCECrYVctIT3OgKG9ndQWQhRy/ HF+6HXIjjA0CiLjKg4cPsWhd9uZbntx2xZOkQrk8WRBtvsQ0C0H/vvUzvO2BCNMBXtel 0yWfei+8dS8ItzrILXh5qkBLg/IByGYVCXNkgkuYRCYA5IAx3uR/nClhk/R4bjbhnVSg e+fA== X-Gm-Message-State: AFqh2koOnqPOmMMLjbTmgwum2211n3eibPoxRZEDjlRlb8HMeq23KfgO dKFcdbvi8lrlLOHpZ4jhKJs= X-Google-Smtp-Source: AMrXdXvuBslwLyUQXmrpBn1zhkd0MxBqyAD94kZamVAOEjoCIZoQznXSoz2E2gh555EEjF443EpgUQ== X-Received: by 2002:a17:907:8d18:b0:7c0:d6b6:1ee9 with SMTP id tc24-20020a1709078d1800b007c0d6b61ee9mr42763950ejc.11.1674753127032; Thu, 26 Jan 2023 09:12:07 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z4-20020a170906714400b0087223b8d6efsm872369ejj.16.2023.01.26.09.12.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 09:12:06 -0800 (PST) Content-Language: en-US In-Reply-To: <5026D975-983F-4D18-8690-BE139C92825D@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254221 Archived-At: On 26/01/2023 09:17, Yuan Fu wrote: > If anything, the :pred predicates should be more expensive, since they execute lisp functions and conses tree-sitter nodes into lisp objects. Doesn't the :match predicate "cons tree-sitter nodes into lisp objects"? IIUC the list of captures is produced inside treesit-query-capture exactly the same way before the predicates are processed -- whether they are :pred, or :match, or a combination. But indeed, I (and most other users) would expect :match to be faster than :pred if the predicate does a regexp check anyway. That's the essence of this bug report.